Implement cargo clippy suggestions

Author: MateusRodCosta

src/main.rs

@@ -20,9 +20,7 @@ use crate::{
 fn main() -> ExitCode {
     let mut args = Arguments::from_env();
 
-    if let Err(e) =
-        ThumbnailerCommand::try_from(&mut args).and_then(|cmd| bign_handheld_thumbnailer(cmd))
-    {
+    if let Err(e) = ThumbnailerCommand::try_from(&mut args).and_then(bign_handheld_thumbnailer) {
         eprintln!("{e}");
         return ExitCode::FAILURE;
     }

src/n3ds/structures/cci.rs

@@ -18,10 +18,7 @@ impl CCIPartition {
         let length = u32::from_le_bytes(partition_bytes[4..].try_into().unwrap()); //in media units
         let length = length * MEDIA_UNIT_SIZE;
 
-        CCIPartition {
-            offset,
-            length,
-        }
+        CCIPartition { offset, length }
     }
 }
 
@@ -35,8 +32,11 @@ impl SMDHIcon {
         f.seek(SeekFrom::Start(CCI_HEADER_MAGIC_OFFSET))?;
         let mut cci_magic = [0u8; 4];
         f.read_exact(&mut cci_magic)?;
-        if CCI_MAGIC_STR.as_bytes() != &cci_magic {
-            return Err(N3DSParsingError::FileMagicNotFound(CCI_MAGIC_STR, cci_magic));
+        if CCI_MAGIC_STR.as_bytes() != cci_magic {
+            return Err(N3DSParsingError::FileMagicNotFound(
+                CCI_MAGIC_STR,
+                cci_magic,
+            ));
         }
         f.seek(SeekFrom::Start(CCI_HEADER_PARTITION_TABLE_OFFSET))?;
         let mut partition_table = [0u8; CCI_HEADER_PARTITION_TABLE_SIZE];

src/n3ds/structures/cia.rs

@@ -257,9 +257,8 @@ impl SMDHIcon {
             + ticket_size_with_padding
             + tmd_size_with_padding;
 
-        Self::from_cia_tmd(f, offset_content).or_else(|error| {
+        Self::from_cia_tmd(f, offset_content).inspect_err(|_| {
             eprintln!("Failed to parse SMDH from CIA's CXI");
-            Err(error.into())
         })
     }
 

src/n3ds/structures/cxi.rs

@@ -52,7 +52,7 @@ impl SMDHIcon {
         f.seek(SeekFrom::Start(cxi_start_pos + CXI_HEADER_MAGIC_OFFSET))?;
         let mut cxi_magic = [0u8; 4];
         f.read_exact(&mut cxi_magic)?;
-        if CXI_MAGIC_STR.as_bytes() != &cxi_magic {
+        if CXI_MAGIC_STR.as_bytes() != cxi_magic {
             return Err(N3DSParsingError::FileMagicNotFound(
                 CXI_MAGIC_STR,
                 cxi_magic,

src/utils/rgb888.rs

@@ -3,9 +3,7 @@ pub struct Bgr555(pub u16);
 
 impl From<[u8; 2]> for Bgr555 {
     fn from(value: [u8; 2]) -> Self {
-        Self {
-            0: u16::from_le_bytes(value),
-        }
+        Self(u16::from_le_bytes(value))
     }
 }
 
@@ -14,9 +12,7 @@ pub struct Rgb565(pub u16);
 
 impl From<[u8; 2]> for Rgb565 {
     fn from(value: [u8; 2]) -> Self {
-        Self {
-            0: u16::from_le_bytes(value),
-        }
+        Self(u16::from_le_bytes(value))
     }
 }