Independent FullForm #1316
Open
Independent FullForm #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullform
|
Let's defer this until after a release, which I think may happen this weekend. |
|
Sure. I just put this here in relation with the other PR. |
mmatera
force-pushed
the
makeboxes_refactor_2025_step_0p5
branch
from
3b54e1b to
74bb87c
Compare
rocky
reviewed
Feb 11, 2025
| @@ -183,14 +183,10 @@ def do_format_rational( | |||
| if not isinstance(element, Rational): | |||
| return None | |||
| if form is SymbolFullForm: | |||
There was a problem hiding this comment.
I realize this is not part of the changed code, but I have this nagging feeling that code like if form is ... is not the right way ultimately we should be approaching this.
There was a problem hiding this comment.
@rocky, feel free to push over all the changes you find useful.
There was a problem hiding this comment.
Right now, I'd like to defer work on this kind of code until a better handle on MakeBox migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to handle the FullForm outside the evaluation process, for example, in debugging, or as a last resource with the standard evaluation process fails.