Skip to content

Commit adb9f96

Browse files
gforsythMathisHammel
gforsyth
authored and
MathisHammel
committed
Add shellcheck to pre-commit and fix warnings (rapidsai#4954)
`shellcheck` is a fast, static analysis tool for shell scripts. It's good at flagging up unused variables, unintentional glob expansions, and other potential execution and security headaches that arise from the wonders of `bash` (and other shlangs). This PR adds a `pre-commit` hook to run `shellcheck` on all of the `sh-lang` files in the `ci/` directory, and the changes requested by `shellcheck` to make the existing files pass the check. xref: rapidsai/build-planning#135 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) - Don Acosta (https://github.com/acostadon) - Chuck Hastings (https://github.com/ChuckHastings) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#4954
1 parent 575ba6c commit adb9f96

25 files changed

+216
-219
lines changed

‎.pre-commit-config.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,8 @@ repos:
6565
hooks:
6666
- id: rapids-dependency-file-generator
6767
args: ["--clean"]
68+
- repo: https://github.com/shellcheck-py/shellcheck-py
69+
rev: v0.10.0.1
70+
hooks:
71+
- id: shellcheck
72+
args: ["--severity=warning"]

‎benchmarks/cugraph/standalone/run_all_nightly_benches.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# Copyright (c) 2021-2022, NVIDIA CORPORATION.
2+
# Copyright (c) 2021-2025, NVIDIA CORPORATION.
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
55
# You may obtain a copy of the License at
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
THIS_SCRIPT_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) && pwd)
15+
THIS_SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
1616

1717
#WEIGHTED_ALGOS="--algo=bfs --algo=sssp"
1818
#UNWEIGHTED_ALGOS="--algo=wcc"
@@ -34,7 +34,7 @@ for scale in $SCALE_VALUES; do
3434
echo ""
3535
echo ">>>>>>>>>>>>>>>>> EDGEFACTOR: $edgefactor"
3636
#env CUDA_VISIBLE_DEVICES="$gpus" python "$THIS_SCRIPT_DIR"/main.py $WEIGHTED_ALGOS --scale=$scale --symmetric-graph
37-
env CUDA_VISIBLE_DEVICES="$gpus" python "$THIS_SCRIPT_DIR"/main.py $UNWEIGHTED_ALGOS --unweighted --symmetric-graph --scale=$scale --edgefactor=$edgefactor
37+
env CUDA_VISIBLE_DEVICES="$gpus" python "$THIS_SCRIPT_DIR"/main.py "$UNWEIGHTED_ALGOS" --unweighted --symmetric-graph --scale="$scale" --edgefactor="$edgefactor"
3838
done
3939
done
4040
mv out.csv random_scale_"$scale".csv

‎benchmarks/shared/build_cugraph_ucx/build-ucx.sh

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
#!/bin/bash
2-
# Copyright (c) 2023-2024, NVIDIA CORPORATION.
2+
# Copyright (c) 2023-2025, NVIDIA CORPORATION.
33
# SPDX-License-Identifier: Apache-2.0
44
set -ex
55

66
UCX_VERSION_TAG=${1:-"v1.14.x"}
77
CUDA_HOME=${2:-"/usr/local/cuda"}
88
# Send any remaining arguments to configure
9-
CONFIGURE_ARGS=${@:2}
9+
CONFIGURE_ARGS=("${@:2}")
1010
git clone https://github.com/openucx/ucx.git
1111
cd ucx
12-
git checkout ${UCX_VERSION_TAG}
12+
git checkout "${UCX_VERSION_TAG}"
1313
./autogen.sh
1414
mkdir build-linux && cd build-linux
15-
../contrib/configure-release --prefix=${CONDA_PREFIX} --with-sysroot --enable-cma \
15+
../contrib/configure-release --prefix="${CONDA_PREFIX}" --with-sysroot --enable-cma \
1616
--enable-mt --enable-numa --with-gnu-ld --with-rdmacm --with-verbs \
17-
--with-cuda=${CUDA_HOME} \
18-
${CONFIGURE_ARGS}
17+
--with-cuda="${CUDA_HOME}" \
18+
"${CONFIGURE_ARGS[@]}"
1919
make -j install

‎build.sh

+79-92
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ ARGS=$*
1616

1717
# NOTE: ensure all dir changes are relative to the location of this
1818
# script, and that this script resides in the repo dir!
19-
REPODIR=$(cd $(dirname $0); pwd)
20-
21-
RAPIDS_VERSION="$(sed -E -e 's/^([0-9]{2})\.([0-9]{2})\.([0-9]{2}).*$/\1.\2/' VERSION)"
19+
REPODIR=$(cd "$(dirname "$0")"; pwd)
2220

2321
# Valid args to this script (all possible targets and options) - only one per line
2422
VALIDARGS="
@@ -88,40 +86,40 @@ BUILD_DIRS="${LIBCUGRAPH_BUILD_DIR}
8886

8987
# Set defaults for vars modified by flags to this script
9088
VERBOSE_FLAG=""
91-
CMAKE_VERBOSE_OPTION=""
89+
CMAKE_VERBOSE_OPTION=()
9290
BUILD_TYPE=Release
93-
INSTALL_TARGET="--target install"
91+
INSTALL_TARGET=(--target install)
9492
BUILD_CPP_TESTS=ON
9593
BUILD_CPP_MG_TESTS=OFF
9694
BUILD_CPP_MTMG_TESTS=OFF
9795
BUILD_ALL_GPU_ARCH=0
98-
CMAKE_GENERATOR_OPTION="-G Ninja"
99-
PYTHON_ARGS_FOR_INSTALL="-m pip install --no-build-isolation --no-deps --config-settings rapidsai.disable-cuda=true"
96+
CMAKE_GENERATOR_OPTION=(-G Ninja)
97+
PYTHON_ARGS_FOR_INSTALL=(-m pip install --no-build-isolation --no-deps --config-settings rapidsai.disable-cuda=true)
10098

10199
# Set defaults for vars that may not have been defined externally
102100
# FIXME: if PREFIX is not set, check CONDA_PREFIX, but there is no fallback
103101
# from there!
104102
INSTALL_PREFIX=${PREFIX:=${CONDA_PREFIX}}
105-
PARALLEL_LEVEL=${PARALLEL_LEVEL:=`nproc`}
103+
PARALLEL_LEVEL=${PARALLEL_LEVEL:=$(nproc)}
106104
BUILD_ABI=${BUILD_ABI:=ON}
107105

108106
function hasArg {
109-
(( ${NUMARGS} != 0 )) && (echo " ${ARGS} " | grep -q " $1 ")
107+
(( NUMARGS != 0 )) && (echo " ${ARGS} " | grep -q " $1 ")
110108
}
111109

112110
function buildDefault {
113-
(( ${NUMARGS} == 0 )) || !(echo " ${ARGS} " | grep -q " [^-][a-zA-Z0-9\_\-]\+ ")
111+
(( NUMARGS == 0 )) || ! (echo " ${ARGS} " | grep -q " [^-][a-zA-Z0-9\_\-]\+ ")
114112
}
115113

116114
function cleanPythonDir {
117-
pushd $1 > /dev/null
118-
rm -rf dist dask-worker-space cugraph/raft *.egg-info
119-
find . -type d -name __pycache__ -print | xargs rm -rf
120-
find . -type d -name build -print | xargs rm -rf
121-
find . -type d -name dist -print | xargs rm -rf
115+
pushd "$1" > /dev/null
116+
rm -rf dist dask-worker-space cugraph/raft ./*.egg-info
117+
find . -type d -name __pycache__ -print0 | xargs -0 rm -rf
118+
find . -type d -name build -print0 | xargs -0 rm -rf
119+
find . -type d -name dist -print0 | xargs -0 rm -rf
122120
find . -type f -name "*.cpp" -delete
123121
find . -type f -name "*.cpython*.so" -delete
124-
find . -type d -name _external_repositories -print | xargs rm -rf
122+
find . -type d -name _external_repositories -print0 | xargs -0 rm -rf
125123
popd > /dev/null
126124
}
127125

@@ -131,7 +129,7 @@ if hasArg -h || hasArg --help; then
131129
fi
132130

133131
# Check for valid usage
134-
if (( ${NUMARGS} != 0 )); then
132+
if (( NUMARGS != 0 )); then
135133
for a in ${ARGS}; do
136134
if ! (echo "${VALIDARGS}" | grep -q "^[[:blank:]]*${a}$"); then
137135
echo "Invalid option: ${a}"
@@ -143,13 +141,13 @@ fi
143141
# Process flags
144142
if hasArg -v; then
145143
VERBOSE_FLAG="-v"
146-
CMAKE_VERBOSE_OPTION="--log-level=VERBOSE"
144+
CMAKE_VERBOSE_OPTION=(--log-level=VERBOSE)
147145
fi
148146
if hasArg -g; then
149147
BUILD_TYPE=Debug
150148
fi
151149
if hasArg -n; then
152-
INSTALL_TARGET=""
150+
INSTALL_TARGET=()
153151
fi
154152
if hasArg --allgpuarch; then
155153
BUILD_ALL_GPU_ARCH=1
@@ -164,33 +162,33 @@ if hasArg cpp-mgtests || hasArg all; then
164162
BUILD_CPP_MG_TESTS=ON
165163
fi
166164
if hasArg --cmake_default_generator; then
167-
CMAKE_GENERATOR_OPTION=""
165+
CMAKE_GENERATOR_OPTION=()
168166
fi
169167
if hasArg --pydevelop; then
170-
PYTHON_ARGS_FOR_INSTALL="${PYTHON_ARGS_FOR_INSTALL} -e"
168+
PYTHON_ARGS_FOR_INSTALL+=(-e)
171169
fi
172170

173171
SKBUILD_EXTRA_CMAKE_ARGS="${EXTRA_CMAKE_ARGS}"
174172

175173
# Replace spaces with semicolons in SKBUILD_EXTRA_CMAKE_ARGS
176-
SKBUILD_EXTRA_CMAKE_ARGS=$(echo ${SKBUILD_EXTRA_CMAKE_ARGS} | sed 's/ /;/g')
174+
SKBUILD_EXTRA_CMAKE_ARGS=${SKBUILD_EXTRA_CMAKE_ARGS// /;}
177175

178176
# If clean or uninstall targets given, run them prior to any other steps
179177
if hasArg uninstall; then
180178
if [[ "$INSTALL_PREFIX" != "" ]]; then
181-
rm -rf ${INSTALL_PREFIX}/include/cugraph
182-
rm -f ${INSTALL_PREFIX}/lib/libcugraph.so
183-
rm -rf ${INSTALL_PREFIX}/include/cugraph_c
184-
rm -f ${INSTALL_PREFIX}/lib/libcugraph_c.so
185-
rm -rf ${INSTALL_PREFIX}/include/cugraph_etl
186-
rm -f ${INSTALL_PREFIX}/lib/libcugraph_etl.so
187-
rm -rf ${INSTALL_PREFIX}/lib/cmake/cugraph
188-
rm -rf ${INSTALL_PREFIX}/lib/cmake/cugraph_etl
179+
rm -rf "${INSTALL_PREFIX}/include/cugraph"
180+
rm -f "${INSTALL_PREFIX}/lib/libcugraph.so"
181+
rm -rf "${INSTALL_PREFIX}/include/cugraph_c"
182+
rm -f "${INSTALL_PREFIX}/lib/libcugraph_c.so"
183+
rm -rf "${INSTALL_PREFIX}/include/cugraph_etl"
184+
rm -f "${INSTALL_PREFIX}/lib/libcugraph_etl.so"
185+
rm -rf "${INSTALL_PREFIX}/lib/cmake/cugraph"
186+
rm -rf "${INSTALL_PREFIX}/lib/cmake/cugraph_etl"
189187
fi
190188
# This may be redundant given the above, but can also be used in case
191189
# there are other installed files outside of the locations above.
192-
if [ -e ${LIBCUGRAPH_BUILD_DIR}/install_manifest.txt ]; then
193-
xargs rm -f < ${LIBCUGRAPH_BUILD_DIR}/install_manifest.txt > /dev/null 2>&1
190+
if [ -e "${LIBCUGRAPH_BUILD_DIR}/install_manifest.txt" ]; then
191+
xargs rm -f < "${LIBCUGRAPH_BUILD_DIR}/install_manifest.txt" > /dev/null 2>&1
194192
fi
195193
# uninstall cugraph and pylibcugraph installed from a prior install
196194
# FIXME: if multiple versions of these packages are installed, this only
@@ -204,17 +202,17 @@ if hasArg clean; then
204202
set +e
205203
# remove artifacts generated inplace
206204
if [[ -d ${REPODIR}/python ]]; then
207-
cleanPythonDir ${REPODIR}/python
205+
cleanPythonDir "${REPODIR}/python"
208206
fi
209207

210208
# If the dirs to clean are mounted dirs in a container, the contents should
211209
# be removed but the mounted dirs will remain. The find removes all
212210
# contents but leaves the dirs, the rmdir attempts to remove the dirs but
213211
# can fail safely.
214212
for bd in ${BUILD_DIRS}; do
215-
if [ -d ${bd} ]; then
216-
find ${bd} -mindepth 1 -delete
217-
rmdir ${bd} || true
213+
if [ -d "${bd}" ]; then
214+
find "${bd}" -mindepth 1 -delete
215+
rmdir "${bd}" || true
218216
fi
219217
done
220218
# Go back to failing on first error for all other operations
@@ -225,128 +223,117 @@ fi
225223
# Configure, build, and install libcugraph
226224
if buildDefault || hasArg libcugraph || hasArg all; then
227225
if hasArg --clean; then
228-
if [ -d ${LIBCUGRAPH_BUILD_DIR} ]; then
229-
find ${LIBCUGRAPH_BUILD_DIR} -mindepth 1 -delete
230-
rmdir ${LIBCUGRAPH_BUILD_DIR} || true
226+
if [ -d "${LIBCUGRAPH_BUILD_DIR}" ]; then
227+
find "${LIBCUGRAPH_BUILD_DIR}" -mindepth 1 -delete
228+
rmdir "${LIBCUGRAPH_BUILD_DIR}" || true
231229
fi
232230
else
233-
if (( ${BUILD_ALL_GPU_ARCH} == 0 )); then
231+
if (( BUILD_ALL_GPU_ARCH == 0 )); then
234232
CUGRAPH_CMAKE_CUDA_ARCHITECTURES="NATIVE"
235233
echo "Building for the architecture of the GPU in the system..."
236234
else
237235
CUGRAPH_CMAKE_CUDA_ARCHITECTURES="RAPIDS"
238236
echo "Building for *ALL* supported GPU architectures..."
239237
fi
240-
mkdir -p ${LIBCUGRAPH_BUILD_DIR}
241-
cd ${LIBCUGRAPH_BUILD_DIR}
238+
mkdir -p "${LIBCUGRAPH_BUILD_DIR}"
239+
cd "${LIBCUGRAPH_BUILD_DIR}"
242240
cmake -B "${LIBCUGRAPH_BUILD_DIR}" -S "${REPODIR}/cpp" \
243-
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
241+
-DCMAKE_INSTALL_PREFIX="${INSTALL_PREFIX}" \
244242
-DCMAKE_CUDA_ARCHITECTURES=${CUGRAPH_CMAKE_CUDA_ARCHITECTURES} \
245243
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
246244
-DBUILD_TESTS=${BUILD_CPP_TESTS} \
247245
-DBUILD_CUGRAPH_MG_TESTS=${BUILD_CPP_MG_TESTS} \
248-
-DBUILD_CUGRAPH_MTMG_TESTS=${BUILD_CPP_MTMG_TESTS} \
249-
${CMAKE_GENERATOR_OPTION} \
250-
${CMAKE_VERBOSE_OPTION}
251-
cmake --build "${LIBCUGRAPH_BUILD_DIR}" -j${PARALLEL_LEVEL} ${INSTALL_TARGET} ${VERBOSE_FLAG}
246+
-DBUILD_CUGRAPH_MTMG_TESTS=${BUILD_CPP_MTMG_TESTS} \
247+
"${CMAKE_GENERATOR_OPTION[@]}" \
248+
"${CMAKE_VERBOSE_OPTION[@]}"
249+
250+
cmake --build "${LIBCUGRAPH_BUILD_DIR}" "-j${PARALLEL_LEVEL}" "${INSTALL_TARGET[@]}" "${VERBOSE_FLAG}"
252251
fi
253252
fi
254253

255254
# Configure, build, and install libcugraph_etl
256255
if buildDefault || hasArg libcugraph_etl || hasArg all; then
257256
if hasArg --clean; then
258-
if [ -d ${LIBCUGRAPH_ETL_BUILD_DIR} ]; then
259-
find ${LIBCUGRAPH_ETL_BUILD_DIR} -mindepth 1 -delete
260-
rmdir ${LIBCUGRAPH_ETL_BUILD_DIR} || true
257+
if [ -d "${LIBCUGRAPH_ETL_BUILD_DIR}" ]; then
258+
find "${LIBCUGRAPH_ETL_BUILD_DIR}" -mindepth 1 -delete
259+
rmdir "${LIBCUGRAPH_ETL_BUILD_DIR}" || true
261260
fi
262261
else
263-
if (( ${BUILD_ALL_GPU_ARCH} == 0 )); then
262+
if (( BUILD_ALL_GPU_ARCH == 0 )); then
264263
CUGRAPH_CMAKE_CUDA_ARCHITECTURES="NATIVE"
265264
echo "Building for the architecture of the GPU in the system..."
266265
else
267266
CUGRAPH_CMAKE_CUDA_ARCHITECTURES="RAPIDS"
268267
echo "Building for *ALL* supported GPU architectures..."
269268
fi
270-
mkdir -p ${LIBCUGRAPH_ETL_BUILD_DIR}
271-
cd ${LIBCUGRAPH_ETL_BUILD_DIR}
272-
cmake -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
273-
-DCMAKE_CUDA_ARCHITECTURES=${CUGRAPH_CMAKE_CUDA_ARCHITECTURES} \
274-
-DDISABLE_DEPRECATION_WARNING=${BUILD_DISABLE_DEPRECATION_WARNING} \
269+
mkdir -p "${LIBCUGRAPH_ETL_BUILD_DIR}"
270+
cd "${LIBCUGRAPH_ETL_BUILD_DIR}"
271+
cmake -DCMAKE_INSTALL_PREFIX="${INSTALL_PREFIX}" \
272+
-DCMAKE_CUDA_ARCHITECTURES="${CUGRAPH_CMAKE_CUDA_ARCHITECTURES}" \
273+
-DDISABLE_DEPRECATION_WARNING="${BUILD_DISABLE_DEPRECATION_WARNING}" \
275274
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
276275
-DBUILD_TESTS=${BUILD_CPP_TESTS} \
277276
-DBUILD_CUGRAPH_MG_TESTS=${BUILD_CPP_MG_TESTS} \
278277
-DBUILD_CUGRAPH_MTMG_TESTS=${BUILD_CPP_MTMG_TESTS} \
279-
-DCMAKE_PREFIX_PATH=${LIBCUGRAPH_BUILD_DIR} \
280-
${CMAKE_GENERATOR_OPTION} \
281-
${CMAKE_VERBOSE_OPTION} \
282-
${REPODIR}/cpp/libcugraph_etl
283-
cmake --build "${LIBCUGRAPH_ETL_BUILD_DIR}" -j${PARALLEL_LEVEL} ${INSTALL_TARGET} ${VERBOSE_FLAG}
278+
-DCMAKE_PREFIX_PATH="${LIBCUGRAPH_BUILD_DIR}" \
279+
"${CMAKE_GENERATOR_OPTION[@]}" \
280+
"${CMAKE_VERBOSE_OPTION[@]}" \
281+
"${REPODIR}/cpp/libcugraph_etl"
282+
cmake --build "${LIBCUGRAPH_ETL_BUILD_DIR}" "-j${PARALLEL_LEVEL}" "${INSTALL_TARGET[@]}" "${VERBOSE_FLAG}"
284283
fi
285284
fi
286285

287286
# Build, and install pylibcugraph
288287
if buildDefault || hasArg pylibcugraph || hasArg all; then
289288
if hasArg --clean; then
290-
cleanPythonDir ${REPODIR}/python/pylibcugraph
289+
cleanPythonDir "${REPODIR}/python/pylibcugraph"
291290
else
292291
SKBUILD_CMAKE_ARGS="${SKBUILD_EXTRA_CMAKE_ARGS}" \
293-
python ${PYTHON_ARGS_FOR_INSTALL} ${REPODIR}/python/pylibcugraph
292+
python "${PYTHON_ARGS_FOR_INSTALL[@]}" "${REPODIR}/python/pylibcugraph"
294293
fi
295294
fi
296295

297296
# Build and install the cugraph Python package
298297
if buildDefault || hasArg cugraph || hasArg all; then
299298
if hasArg --clean; then
300-
cleanPythonDir ${REPODIR}/python/cugraph
299+
cleanPythonDir "${REPODIR}/python/cugraph"
301300
else
302301
SKBUILD_CMAKE_ARGS="${SKBUILD_EXTRA_CMAKE_ARGS}" \
303-
python ${PYTHON_ARGS_FOR_INSTALL} ${REPODIR}/python/cugraph
302+
python "${PYTHON_ARGS_FOR_INSTALL[@]}" "${REPODIR}/python/cugraph"
304303
fi
305304
fi
306305

307306
# Install the cugraph-service-client and cugraph-service-server Python packages
308307
if hasArg cugraph-service || hasArg all; then
309308
if hasArg --clean; then
310-
cleanPythonDir ${REPODIR}/python/cugraph-service
309+
cleanPythonDir "${REPODIR}/python/cugraph-service"
311310
else
312-
python ${PYTHON_ARGS_FOR_INSTALL} ${REPODIR}/python/cugraph-service/client
313-
python ${PYTHON_ARGS_FOR_INSTALL} ${REPODIR}/python/cugraph-service/server
311+
python "${PYTHON_ARGS_FOR_INSTALL[@]}" "${REPODIR}/python/cugraph-service/client"
312+
python "${PYTHON_ARGS_FOR_INSTALL[@]}" "${REPODIR}/python/cugraph-service/server"
314313
fi
315314
fi
316315

317316
# Build the docs
318317
if hasArg docs || hasArg all; then
319-
if [ ! -d ${LIBCUGRAPH_BUILD_DIR} ]; then
320-
mkdir -p ${LIBCUGRAPH_BUILD_DIR}
321-
cd ${LIBCUGRAPH_BUILD_DIR}
318+
if [ ! -d "${LIBCUGRAPH_BUILD_DIR}" ]; then
319+
mkdir -p "${LIBCUGRAPH_BUILD_DIR}"
320+
cd "${LIBCUGRAPH_BUILD_DIR}"
322321
cmake -B "${LIBCUGRAPH_BUILD_DIR}" -S "${REPODIR}/cpp" \
323-
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
324-
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
325-
${CMAKE_GENERATOR_OPTION} \
326-
${CMAKE_VERBOSE_OPTION}
322+
-DCMAKE_INSTALL_PREFIX="${INSTALL_PREFIX}" \
323+
-DCMAKE_BUILD_TYPE="${BUILD_TYPE}" \
324+
"${CMAKE_GENERATOR_OPTION[@]}" \
325+
"${CMAKE_VERBOSE_OPTION[@]}"
327326
fi
328327

329-
# for PROJECT in libwholegraph; do
330-
# XML_DIR="${REPODIR}/docs/cugraph/${PROJECT}"
331-
# rm -rf "${XML_DIR}"
332-
# mkdir -p "${XML_DIR}"
333-
# export XML_DIR_${PROJECT^^}="$XML_DIR"
334-
335-
# echo "downloading xml for ${PROJECT} into ${XML_DIR}. Environment variable XML_DIR_${PROJECT^^} is set to ${XML_DIR}"
336-
# curl -O "https://d1664dvumjb44w.cloudfront.net/${PROJECT}/xml_tar/${RAPIDS_VERSION}/xml.tar.gz"
337-
# tar -xzf xml.tar.gz -C "${XML_DIR}"
338-
# rm "./xml.tar.gz"
339-
# done
340-
341-
cd ${LIBCUGRAPH_BUILD_DIR}
342-
cmake --build "${LIBCUGRAPH_BUILD_DIR}" -j${PARALLEL_LEVEL} --target docs_cugraph ${VERBOSE_FLAG}
328+
cd "${LIBCUGRAPH_BUILD_DIR}"
329+
cmake --build "${LIBCUGRAPH_BUILD_DIR}" "-j${PARALLEL_LEVEL}" --target docs_cugraph ${VERBOSE_FLAG}
343330

344331
echo "making libcugraph doc dir"
345-
rm -rf ${REPODIR}/docs/cugraph/libcugraph
346-
mkdir -p ${REPODIR}/docs/cugraph/libcugraph
332+
rm -rf "${REPODIR}/docs/cugraph/libcugraph"
333+
mkdir -p "${REPODIR}/docs/cugraph/libcugraph"
347334

348335
export XML_DIR_LIBCUGRAPH="${REPODIR}/cpp/doxygen/xml"
349336

350-
cd ${REPODIR}/docs/cugraph
337+
cd "${REPODIR}/docs/cugraph"
351338
make html
352339
fi

0 commit comments

Comments
 (0)