Skip to content

Commit 904aef5

Browse files
committed
replace test on valid size with an assert
CreateElementUsingContext() never creates an element with an invalid size.
1 parent 1c72dc2 commit 904aef5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/EbmlElement.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ EbmlElement * EbmlElement::FindNextElement(IOCallback & DataStream, const EbmlSe
324324
///< \todo continue is misplaced
325325
if (Result != nullptr) {
326326
if (AllowDummyElt || !Result->IsDummy()) {
327+
assert(Result->ElementSpec().IsSizeValid(SizeFound));
327328
Result->SetSizeLength(_SizeLength);
328329

329330
Result->Size = SizeFound;
@@ -332,7 +333,7 @@ EbmlElement * EbmlElement::FindNextElement(IOCallback & DataStream, const EbmlSe
332333
// 0 : child
333334
// 1 : same level
334335
// + : further parent
335-
if (Result->ElementSpec().IsSizeValid(SizeFound) && (SizeFound == SizeUnknown || UpperLevel > 0 || MaxDataSize == 0 ||
336+
if ((SizeFound == SizeUnknown || UpperLevel > 0 || MaxDataSize == 0 ||
336337
MaxDataSize >= (IdStart + PossibleID_Length + _SizeLength + SizeFound))) {
337338
Result->ElementPosition = ParseStart + IdStart;
338339
Result->SizePosition = Result->ElementPosition + PossibleID_Length;

0 commit comments

Comments
 (0)