Skip to content

Commit ca441ce

Browse files
fix gui bug
1 parent 7522653 commit ca441ce

File tree

3 files changed

+20
-13
lines changed

3 files changed

+20
-13
lines changed

src/main/java/it/polimi/ingsw/gui/GameController.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import static it.polimi.ingsw.shared.Cards.CardColor.BLUE;
4242
import static it.polimi.ingsw.shared.Cards.CardColor.EMPTY;
4343
import static javafx.geometry.Pos.CENTER;
44-
// import static jdk.internal.org.jline.utils.Colors.s;
4544

4645
public class GameController extends GuiView implements Initializable {
4746

@@ -95,7 +94,7 @@ public class GameController extends GuiView implements Initializable {
9594
private Label shelfID3 = new Label();
9695

9796
//images
98-
ArrayList<Title> titles = new ArrayList<>();
97+
9998
@FXML
10099
public ImageView logo = new ImageView();
101100
@FXML
@@ -294,25 +293,25 @@ public void setMainBoard(){
294293

295294

296295
//TO FIX BOARD DIMENSION
297-
ImageView card = new ImageView(createImage(0, BLUE, titles));
296+
ImageView card = new ImageView(createImage(0, BLUE, helloApplication.getTitles()));
298297
card.setFitHeight(50);
299298
card.setFitWidth(50);
300299
card.setVisible(false);
301300
GridPane.setConstraints(card,0,0);
302301
mainBoardGrid.getChildren().add(card);
303-
card = new ImageView(createImage(0, BLUE, titles));
302+
card = new ImageView(createImage(0, BLUE, helloApplication.getTitles()));
304303
card.setFitHeight(50);
305304
card.setFitWidth(50);
306305
card.setVisible(false);
307306
GridPane.setConstraints(card,0,8);
308307
mainBoardGrid.getChildren().add(card);
309-
card = new ImageView(createImage(0, BLUE, titles));
308+
card = new ImageView(createImage(0, BLUE, helloApplication.getTitles()));
310309
card.setFitHeight(50);
311310
card.setFitWidth(50);
312311
card.setVisible(false);
313312
GridPane.setConstraints(card,8,8);
314313
mainBoardGrid.getChildren().add(card);
315-
card = new ImageView(createImage(0, BLUE, titles));
314+
card = new ImageView(createImage(0, BLUE, helloApplication.getTitles()));
316315
card.setFitHeight(50);
317316
card.setFitWidth(50);
318317
card.setVisible(false);
@@ -322,7 +321,7 @@ public void setMainBoard(){
322321
Card[][] mainBoard = player.getMainBoard().getBoard();
323322
for(int x=0;x<player.getMainBoard().getColumns();x++){
324323
for (int y=0;y<player.getMainBoard().getRows(); y++){
325-
card = new ImageView(createImage(mainBoard[x][y].getSketch(), mainBoard[x][y].getColor(), titles));
324+
card = new ImageView(createImage(mainBoard[x][y].getSketch(), mainBoard[x][y].getColor(), helloApplication.getTitles()));
326325
card.setFitHeight(50);
327326
card.setFitWidth(50);
328327
if(mainBoard[x][y].getColor().equals(EMPTY))card.setVisible(false);
@@ -363,7 +362,7 @@ public void setMyPlayerBoardGrid(){
363362

364363
for(int x=0;x<playerBoard.getColumns();x++){
365364
for (int y=0;y<playerBoard.getRows(); y++){
366-
ImageView card = new ImageView(createImage(cards[x][y].getSketch(), cards[x][y].getColor(), titles));
365+
ImageView card = new ImageView(createImage(cards[x][y].getSketch(), cards[x][y].getColor(), helloApplication.getTitles()));
367366
card.setFitHeight(42);
368367
card.setFitWidth(42);
369368
if(cards[x][y].getColor().equals(EMPTY))card.setVisible(false);
@@ -405,7 +404,7 @@ private void updatePlayerBoard(String playerID, int column, Card[] c, GridPane g
405404
y = y -c.length +1;
406405

407406
for(Card card: c){
408-
ImageView cardImg = new ImageView(createImage(card.getSketch(), card.getColor(), titles));
407+
ImageView cardImg = new ImageView(createImage(card.getSketch(), card.getColor(), helloApplication.getTitles()));
409408
cardImg.setFitHeight(size);
410409
cardImg.setFitWidth(size);
411410
GridPane.setConstraints(cardImg, column, player.getMainBoard().getColumns()-y);
@@ -436,7 +435,7 @@ public void setOtherPlayerBoard(){
436435

437436
for (int x = 0; x < playerBoard.getColumns(); x++) {
438437
for (int y = 0; y < playerBoard.getRows(); y++) {
439-
ImageView card = new ImageView(createImage(cards[x][y].getSketch(),cards[x][y].getColor(), titles));
438+
ImageView card = new ImageView(createImage(cards[x][y].getSketch(),cards[x][y].getColor(), helloApplication.getTitles()));
440439
card.setFitHeight(17);
441440
card.setFitWidth(17);
442441
if(cards[x][y].getColor().equals(EMPTY))card.setVisible(false);
@@ -532,7 +531,7 @@ private void MoveMode(){
532531
private void insertTails(int x, int y, int pose){
533532

534533
Card[][] mainBoard = player.getMainBoard().getBoard();
535-
ImageView card = new ImageView(createImage(mainBoard[x][y].getSketch(), mainBoard[x][y].getColor(), titles));
534+
ImageView card = new ImageView(createImage(mainBoard[x][y].getSketch(), mainBoard[x][y].getColor(), helloApplication.getTitles()));
536535
card.setFitHeight(60);
537536
card.setFitWidth(60);
538537
card.setId("takenCard");

src/main/java/it/polimi/ingsw/gui/HelloApplication.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import it.polimi.ingsw.client.View.UserInterface;
88
import it.polimi.ingsw.gui.supportClass.Message;
99
import it.polimi.ingsw.gui.supportClass.MessageTipe;
10+
import it.polimi.ingsw.gui.supportClass.Title;
1011
import it.polimi.ingsw.shared.Cards.Card;
1112
import it.polimi.ingsw.shared.JsonSupportClasses.PositionWithColor;
1213
import it.polimi.ingsw.shared.PlayerMode;
@@ -20,6 +21,7 @@
2021
import javafx.stage.Stage;
2122

2223
import java.io.IOException;
24+
import java.util.ArrayList;
2325

2426

2527
public class HelloApplication extends Application implements UserInterface {
@@ -55,6 +57,10 @@ public void setConnection(ConnectionManager connection) {
5557
public ConnectionManager getConnection() {
5658
return connection;
5759
}
60+
private final ArrayList<Title> titles = new ArrayList<>();
61+
public ArrayList<Title> getTitles() {
62+
return titles;
63+
}
5864

5965

6066
public void changeView(String viewName) throws IOException {
@@ -137,8 +143,6 @@ public void updateAll() {
137143
if(guiView instanceof GameController) {
138144
Platform.runLater(() -> {
139145
((GameController)guiView).setMainBoard();
140-
((GameController)guiView).setMyPlayerBoardGrid();
141-
((GameController)guiView).setOtherPlayerBoard();
142146
});
143147
return;
144148
}

src/main/java/it/polimi/ingsw/gui/HelloController.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.google.gson.JsonObject;
55
import it.polimi.ingsw.client.Connection.ClientRMI;
66
import it.polimi.ingsw.client.Connection.ClientSOCKET;
7+
import it.polimi.ingsw.gui.supportClass.Title;
78
import it.polimi.ingsw.shared.JsonSupportClasses.JsonUrl;
89
import javafx.event.ActionEvent;
910
import javafx.fxml.FXML;
@@ -24,6 +25,7 @@
2425

2526
import java.io.*;
2627
import java.net.URL;
28+
import java.util.ArrayList;
2729
import java.util.ResourceBundle;
2830

2931
public class HelloController extends GuiView implements Initializable {
@@ -49,6 +51,8 @@ public class HelloController extends GuiView implements Initializable {
4951
int RMIPort;
5052
String serverIP;
5153
Alert cntAlert = new Alert(Alert.AlertType.ERROR);
54+
55+
5256
private void jsonCreate() throws FileNotFoundException{
5357
InputStream inputStream = this.getClass().getClassLoader().getResourceAsStream(JsonUrl.getUrl("netConfig"));
5458
if(inputStream == null) throw new FileNotFoundException();

0 commit comments

Comments
 (0)