Skip to content

Commit 85a7bc7

Browse files
committed
fix: removed an if statement to validate if the member_list_strike exists before doin a loop inside it to filter by nowadays semester in get_all_membes route
1 parent 1ab07a8 commit 85a7bc7

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/modules/get_all_members/app/get_all_members_usecase.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@ def __call__(self,user_id: str, start_date: Optional[int] = None, end_date: Opti
7171
for member in members:
7272
member_user_id = member.user_id
7373

74-
member_list_strikes = self.strikerepo.get_strike_by_target_id(target_user_id=member_user_id)
75-
if member_list_strikes:
76-
member_list_strike_this_sem = [
77-
s for s in member_list_strikes
78-
if start_date <= s.occurred_date <= end_date
79-
]
74+
member_list_strikes = self.strikerepo.get_strike_by_target_id(target_user_id=member_user_id) or []
75+
76+
member_list_strike_this_sem = [
77+
s for s in member_list_strikes
78+
if start_date <= s.occurred_date <= end_date
79+
]
8080

8181
total_projects= len(member_projects[member_user_id])
8282

0 commit comments

Comments
 (0)