chore: cargo clippy

Author: MaxOhn

bathbot/src/commands/fun/bg_game/mod.rs

@@ -133,9 +133,10 @@ pub enum BgGameMode {
     Mania,
 }
 
-#[derive(Copy, Clone, Debug, CommandOption, CreateOption)]
+#[derive(Copy, Clone, Debug, CommandOption, CreateOption, Default)]
 pub enum GameDifficulty {
     #[option(name = "Normal", value = "normal")]
+    #[default]
     Normal,
     #[option(name = "Hard", value = "hard")]
     Hard,
@@ -153,12 +154,6 @@ impl GameDifficulty {
     }
 }
 
-impl Default for GameDifficulty {
-    fn default() -> Self {
-        Self::Normal
-    }
-}
-
 /// When users install the bot as an app, they can use the command even if it's
 /// disabled in a guild. This function makes sure that the command is not
 /// disabled.

bathbot/src/commands/fun/minesweeper.rs

@@ -155,10 +155,11 @@ impl Game {
     }
 }
 
-#[derive(Clone, Copy, Eq, PartialEq)]
+#[derive(Clone, Copy, Default, Eq, PartialEq)]
 enum Cell {
     Num(u8),
     Mine,
+    #[default]
     None,
 }
 
@@ -179,9 +180,3 @@ impl Display for Cell {
         }
     }
 }
-
-impl Default for Cell {
-    fn default() -> Self {
-        Self::None
-    }
-}

bathbot/src/commands/osu/map_search.rs

@@ -169,7 +169,7 @@ impl From<SearchLanguage> for Language {
     }
 }
 
-#[derive(Copy, Clone, CommandOption, CreateOption, Debug, Eq, PartialEq)]
+#[derive(Copy, Clone, CommandOption, CreateOption, Debug, Default, Eq, PartialEq)]
 pub enum SearchOrder {
     #[option(name = "Artist", value = "artist")]
     Artist,
@@ -182,19 +182,14 @@ pub enum SearchOrder {
     #[option(name = "Rating", value = "rating")]
     Rating,
     #[option(name = "Relevance", value = "relevance")]
+    #[default]
     Relevance,
     #[option(name = "Stars", value = "stars")]
     Stars,
     #[option(name = "Title", value = "title")]
     Title,
 }
 
-impl Default for SearchOrder {
-    fn default() -> Self {
-        Self::Relevance
-    }
-}
-
 impl From<SearchOrder> for BeatmapsetSearchSort {
     fn from(order: SearchOrder) -> Self {
         match order {

bathbot/src/commands/osu/match_compare.rs

@@ -28,36 +28,26 @@ pub struct MatchCompare {
     comparison: Option<MatchCompareComparison>,
 }
 
-#[derive(CommandOption, CreateOption)]
+#[derive(CommandOption, CreateOption, Default)]
 pub enum MatchCompareOutput {
     #[option(name = "Full", value = "full")]
     Full,
     #[option(name = "Paginated", value = "paginated")]
+    #[default]
     Paginated,
 }
 
-impl Default for MatchCompareOutput {
-    fn default() -> Self {
-        Self::Paginated
-    }
-}
-
-#[derive(Copy, Clone, CommandOption, CreateOption)]
+#[derive(Copy, Clone, CommandOption, CreateOption, Default)]
 pub enum MatchCompareComparison {
     #[option(name = "Compare players", value = "players")]
+    #[default]
     Players,
     #[option(name = "Compare teams", value = "teams")]
     Teams,
     #[option(name = "Compare both", value = "both")]
     Both,
 }
 
-impl Default for MatchCompareComparison {
-    fn default() -> Self {
-        Self::Players
-    }
-}
-
 async fn slash_matchcompare(mut command: InteractionCommand) -> Result<()> {
     let args = MatchCompare::from_interaction(command.input_data())?;
 

bathbot/src/commands/osu/osustats/mod.rs

@@ -132,7 +132,7 @@ pub struct OsuStatsBest {
     sort: Option<OsuStatsBestSort>,
 }
 
-#[derive(Copy, Clone, CommandOption, CreateOption)]
+#[derive(Copy, Clone, CommandOption, CreateOption, Default)]
 pub enum OsuStatsBestSort {
     #[option(name = "Accuracy", value = "acc")]
     Accuracy,
@@ -145,17 +145,12 @@ pub enum OsuStatsBestSort {
     #[option(name = "Misses", value = "miss")]
     Misses,
     #[option(name = "PP", value = "pp")]
+    #[default]
     Pp,
     #[option(name = "Score", value = "score")]
     Score,
 }
 
-impl Default for OsuStatsBestSort {
-    fn default() -> Self {
-        Self::Pp
-    }
-}
-
 async fn slash_osustats(mut command: InteractionCommand) -> Result<()> {
     match OsuStats::from_interaction(command.input_data())? {
         OsuStats::Count(args) => count((&mut command).into(), args).await,