Skip to content

Commit 25b1a26

Browse files
committed
Review pass through cpp2regex.h2
Up to line ~1600 Looking good, mainly formatting tweaks to follow the repo's style
1 parent 2a8994f commit 25b1a26

18 files changed

+1549
-1346
lines changed

include/cpp2regex.h

Lines changed: 780 additions & 693 deletions
Large diffs are not rendered by default.

include/cpp2regex.h2

Lines changed: 333 additions & 216 deletions
Large diffs are not rendered by default.

include/cpp2util.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
//
4545
//===========================================================================
4646

47-
#ifndef CPP2_UTIL_H
48-
#define CPP2_UTIL_H
47+
#ifndef CPP2_CPP2UTIL_H
48+
#define CPP2_CPP2UTIL_H
4949

5050
// If this implementation doesn't support source_location yet, disable it
5151
#include <version>

regression-tests/pure2-regex_13_posessive_modifier.cpp2 renamed to regression-tests/pure2-regex_13_possessive_modifier.cpp2

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ test: <M> (regex: M, id: std::string, regex_str: std::string, str: std::string,
150150
}
151151

152152

153-
test_tests_13_posessive_modifier: @regex type = {
153+
test_tests_13_possessive_modifier: @regex type = {
154154
regex_01 := R"(a++a)";
155155
regex_02 := R"(a*+a)";
156156
regex_03 := R"(a{1,5}+a)";
@@ -200,7 +200,7 @@ test_tests_13_posessive_modifier: @regex type = {
200200
regex_47 := R"(foo(aA)?+b)";
201201
regex_48 := R"(foo(aA|bB)?+b)";
202202
run: (this) = {
203-
std::cout << "Running tests_13_posessive_modifier:"<< std::endl;
203+
std::cout << "Running tests_13_possessive_modifier:"<< std::endl;
204204
test(regex_01, "01", R"(a++a)", "aaaaa", "n", R"(-)", "-");
205205
test(regex_02, "02", R"(a*+a)", "aaaaa", "n", R"(-)", "-");
206206
test(regex_03, "03", R"(a{1,5}+a)", "aaaaa", "n", R"(-)", "-");
@@ -253,5 +253,5 @@ test_tests_13_posessive_modifier: @regex type = {
253253
}
254254
}
255255
main: () = {
256-
test_tests_13_posessive_modifier().run();
256+
test_tests_13_possessive_modifier().run();
257257
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Running tests_13_posessive_modifier:
1+
Running tests_13_possessive_modifier:
22
01_n: OK regex: a++a parsed_regex: a++a str: aaaaa result_expr: - expected_results -
33
02_n: OK regex: a*+a parsed_regex: a*+a str: aaaaa result_expr: - expected_results -
44
03_n: OK regex: a{1,5}+a parsed_regex: a{1,5}+a str: aaaaa result_expr: - expected_results -

regression-tests/test-results/clang-12-c++20/pure2-regex_13_posessive_modifier.cpp.execution renamed to regression-tests/test-results/gcc-10-c++20/pure2-regex_13_possessive_modifier.cpp.execution

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Running tests_13_posessive_modifier:
1+
Running tests_13_possessive_modifier:
22
01_n: OK regex: a++a parsed_regex: a++a str: aaaaa result_expr: - expected_results -
33
02_n: OK regex: a*+a parsed_regex: a*+a str: aaaaa result_expr: - expected_results -
44
03_n: OK regex: a{1,5}+a parsed_regex: a{1,5}+a str: aaaaa result_expr: - expected_results -

regression-tests/test-results/gcc-10-c++20/pure2-regex_13_posessive_modifier.cpp.execution renamed to regression-tests/test-results/gcc-14-c++2b/pure2-regex_13_possessive_modifier.cpp.execution

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Running tests_13_posessive_modifier:
1+
Running tests_13_possessive_modifier:
22
01_n: OK regex: a++a parsed_regex: a++a str: aaaaa result_expr: - expected_results -
33
02_n: OK regex: a*+a parsed_regex: a*+a str: aaaaa result_expr: - expected_results -
44
03_n: OK regex: a{1,5}+a parsed_regex: a{1,5}+a str: aaaaa result_expr: - expected_results -

regression-tests/test-results/msvc-2022-c++latest/pure2-regex_13_posessive_modifier.cpp.output

Lines changed: 0 additions & 1 deletion
This file was deleted.

regression-tests/test-results/gcc-14-c++2b/pure2-regex_13_posessive_modifier.cpp.execution renamed to regression-tests/test-results/msvc-2022-c++latest/pure2-regex_13_possessive_modifier.cpp.execution

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Running tests_13_posessive_modifier:
1+
Running tests_13_possessive_modifier:
22
01_n: OK regex: a++a parsed_regex: a++a str: aaaaa result_expr: - expected_results -
33
02_n: OK regex: a*+a parsed_regex: a*+a str: aaaaa result_expr: - expected_results -
44
03_n: OK regex: a{1,5}+a parsed_regex: a{1,5}+a str: aaaaa result_expr: - expected_results -
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
pure2-regex_13_possessive_modifier.cpp

regression-tests/test-results/pure2-regex_13_posessive_modifier.cpp2.output

Lines changed: 0 additions & 2 deletions
This file was deleted.

regression-tests/test-results/pure2-regex_13_posessive_modifier.cpp renamed to regression-tests/test-results/pure2-regex_13_possessive_modifier.cpp

Lines changed: 412 additions & 412 deletions
Large diffs are not rendered by default.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
pure2-regex_13_possessive_modifier.cpp2... ok (all Cpp2, passes safety checks)
2+

source/reflect.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,7 @@ auto cpp2_union(meta::type_declaration& t) -> void;
767767
//
768768
auto print(cpp2::impl::in<meta::type_declaration> t) -> void;
769769

770-
#line 1445 "reflect.h2"
770+
#line 1446 "reflect.h2"
771771
//-----------------------------------------------------------------------
772772
//
773773
// regex - creates regular expressions from members
@@ -2093,21 +2093,20 @@ auto print(cpp2::impl::in<meta::type_declaration> t) -> void
20932093
std::cout << CPP2_UFCS(print)(t) << "\n";
20942094
}
20952095

2096-
#line 1459 "reflect.h2"
2096+
#line 1460 "reflect.h2"
20972097
auto regex_gen(meta::type_declaration& t) -> void
20982098
{
20992099
auto has_default {false};
21002100
auto prefix {"regex"};
2101-
std::string postfix {"_mod"}; // TODO: Remove mod syntax when 'm.initializer()' can be '("pat", "mod")'.
2102-
2101+
std::string postfix {"_mod"}; // TODO: remove mod syntax when 'm.initializer()' can be '("pat", "mod")'
21032102
std::map<std::string,std::string> expressions {};
21042103

21052104
for ( auto& m : CPP2_UFCS(get_member_objects)(t) )
21062105
{
21072106
std::string name {CPP2_UFCS(name)(m)};
21082107

2109-
if (CPP2_UFCS(starts_with)(name, prefix)) {
2110-
2108+
if (CPP2_UFCS(starts_with)(name, prefix))
2109+
{
21112110
if (!(CPP2_UFCS(has_initializer)(m))) {
21122111
CPP2_UFCS(error)(t, "Regular expression must have an initializer.");
21132112
}

source/reflect.h2

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,6 +1442,7 @@ print: (t: meta::type_declaration) =
14421442
std::cout << t.print() << "\n";
14431443
}
14441444

1445+
14451446
//-----------------------------------------------------------------------
14461447
//
14471448
// regex - creates regular expressions from members
@@ -1458,18 +1459,17 @@ print: (t: meta::type_declaration) =
14581459
//
14591460
regex_gen: (inout t: meta::type_declaration) =
14601461
{
1461-
has_default: = false;
1462-
prefix:= "regex";
1463-
postfix: std::string = "_mod"; // TODO: Remove mod syntax when 'm.initializer()' can be '("pat", "mod")'.
1464-
1465-
expressions: std::map<std::string, std::string> = ();
1462+
has_default := false;
1463+
prefix := "regex";
1464+
postfix : std::string = "_mod"; // TODO: remove mod syntax when 'm.initializer()' can be '("pat", "mod")'
1465+
expressions : std::map<std::string, std::string> = ();
14661466

14671467
for t.get_member_objects() do (inout m)
14681468
{
14691469
name: std::string = m.name();
14701470

1471-
if name.starts_with(prefix) {
1472-
1471+
if name.starts_with(prefix)
1472+
{
14731473
if !m.has_initializer() {
14741474
t.error("Regular expression must have an initializer.");
14751475
}

0 commit comments

Comments
 (0)