Skip to content

Commit 4f18d8c

Browse files
committed
Don't set click listener for category header and seek bar
1 parent f9a5759 commit 4f18d8c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

library/src/main/java/de/Maxr1998/modernpreferences/PreferencesAdapter.kt

+5-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@ import androidx.core.view.get
2929
import androidx.recyclerview.widget.LinearLayoutManager
3030
import androidx.recyclerview.widget.RecyclerView
3131
import de.Maxr1998.modernpreferences.helpers.emptyScreen
32-
import de.Maxr1998.modernpreferences.preferences.AccentButtonPreference
33-
import de.Maxr1998.modernpreferences.preferences.CategoryHeader
34-
import de.Maxr1998.modernpreferences.preferences.CollapsePreference
35-
import de.Maxr1998.modernpreferences.preferences.ImagePreference
32+
import de.Maxr1998.modernpreferences.preferences.*
3633
import kotlinx.android.parcel.Parcelize
3734
import java.util.*
3835
import kotlin.math.max
@@ -155,6 +152,10 @@ class PreferencesAdapter @VisibleForTesting constructor(
155152
val pref = currentScreen[position]
156153
pref.bindViews(holder)
157154

155+
// Category header and seek bar shouldn't be clickable
156+
if (pref is CategoryHeader || pref is SeekBarPreference)
157+
return
158+
158159
holder.itemView.setOnClickListener {
159160
if (pref is PreferenceScreen) {
160161
openScreen(pref) // Navigate to sub screen

library/src/main/res/layout/map_preference_category.xml

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ https://android.googlesource.com/platform/frameworks/base/+/master/core/res/res/
1717
android:layout_height="wrap_content"
1818
android:layout_marginTop="8dp"
1919
android:layout_marginBottom="8dp"
20+
android:clickable="false"
2021
android:clipToPadding="false"
2122
android:gravity="center_vertical"
2223
android:paddingStart="?android:listPreferredItemPaddingStart"

0 commit comments

Comments
 (0)