Skip to content

Generated files should not vary based on build path #9521

@mpg

Description

@mpg

We have a number of files that are not committed into git (except for releases) but instead generated by make generated_files. The intent is for the generation procedure to be reproducible: two people on different machines should generate the same files.

This is currently not the case for at least one reason: sometimes the generated files include the absolute path to some files (that we used for generated them, and are referenced in comments) - this happens with test_certs.h for example.

This task is to make sure that generated files don't include the build path, or otherwise have content that varies depending on the build path:

  • Add a test to all.sh about it (most probably, by extending component_check_generated_files(). For example, one could make a copy of the source tree in a subdirectory, generate files in that directory, then rename it, then run check-generated-files.sh, which should complain if the files have different contents after the renaming. This test should find (at least) an issue with test_certs.h.
  • Fix the issue with test_certs.h, and any other issue found by the above test.

Note about scope: this task is not about ensuring that generation is fully reproducible, it's only focusing on the specific issue of embedded paths.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugcomponent-platformPortability layer and build scriptssize-sEstimated task size: small (~2d)

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions