Skip to content

Commit e5287b0

Browse files
refactor: Update tap setting metadata (#185)
1 parent 5cad39f commit e5287b0

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

meltano.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ plugins:
55
extractors:
66
- name: tap-athena
77
namespace: tap_athena
8-
# TODO: To test using Meltano, replace with absolute path
9-
# to the tap-athena.sh script:
10-
executable: ./tap-athena.sh
8+
executable: -e .
119
capabilities:
1210
- state
1311
- catalog
@@ -16,9 +14,11 @@ plugins:
1614
# start_date: '2010-01-01T00:00:00Z'
1715
settings:
1816
- name: aws_access_key_id
19-
kind: password
17+
kind: string
18+
sensitive: true
2019
- name: aws_secret_access_key
21-
kind: password
20+
kind: string
21+
sensitive: true
2222
- name: aws_region
2323
kind: string
2424
- name: s3_staging_dir

tap_athena/tap.py

+8-1
Original file line numberDiff line numberDiff line change
@@ -19,30 +19,37 @@ class TapAthena(SQLTap):
1919
"aws_access_key_id",
2020
th.StringType,
2121
required=True,
22+
secret=True,
23+
title="AWS Access Key ID",
2224
description="AWS access key ID",
2325
),
2426
th.Property(
2527
"aws_secret_access_key",
2628
th.StringType,
2729
required=True,
30+
secret=True,
31+
title="AWS Secret Access Key",
2832
description="AWS secret access key",
2933
),
3034
th.Property(
3135
"aws_region",
3236
th.StringType,
3337
required=True,
34-
description="AWS region",
38+
title="AWS region",
39+
description="The AWS region",
3540
),
3641
th.Property(
3742
"s3_staging_dir",
3843
th.StringType,
3944
required=True,
45+
title="S3 staging directory",
4046
description="The S3 staging directory where output is written.",
4147
),
4248
th.Property(
4349
"schema_name",
4450
th.StringType,
4551
required=True,
52+
title="Schema Name",
4653
description="Athena schema name",
4754
),
4855
).to_dict()

0 commit comments

Comments
 (0)