Why does the tap use composite primary keys for some streams?

[steven-luabase]

For example:

tap-facebook/tap_facebook/streams/campaign.py

Line 73 in 9fc57d9

primary_keys = ["id", "updated_time"] # noqa: RUF012

Shouldn't just id be enough? Wouldn't some targets have duplicates in the resulting table if we use id and updated_time to check for uniqueness when merging/upserting?

[pgieser]

Also just starting to use this tap - looking at the history, looks like a bug introduced here c091370 - I can't figure any reason to add updated_time to the primary keys of ads, adsets, campaigns and adlabels streams.

[steven-luabase]

Yea I forked it and just removed updated_time from all PKs. Working as expected so far

[edgarrmondragon]

Does #409 look correct to you @pgieser @steven-luabase ?

[steven-luabase]

@edgarrmondragon yep we have those changes in our forked version. We just casted all timestamp-like fields to datetime and it seems to be working fine so far.