Skip to content

Commit 554ed05

Browse files
test: Update class-scoped fixtures to use @classmethod (#798)
SSIA. --------- Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
1 parent 52a3ace commit 554ed05

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

tap_postgres/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def _increment_stream_state(
296296
return
297297

298298
state_dict = self.get_context_state(context)
299-
new_value = latest_record.get(self.replication_key) # ty:ignore[invalid-argument-type]
299+
new_value = latest_record.get(self.replication_key)
300300
if new_value is None:
301301
return
302302

tests/test_core.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -119,32 +119,35 @@ class TestTapPostgres(TapPostgresTest): # ty:ignore[unsupported-base]
119119
sqlalchemy_url = SAMPLE_CONFIG["sqlalchemy_url"]
120120

121121
@pytest.fixture(scope="class")
122-
def resource(self):
123-
setup_test_table(self.table_name, self.sqlalchemy_url)
122+
@classmethod
123+
def resource(cls):
124+
setup_test_table(cls.table_name, cls.sqlalchemy_url)
124125
yield
125-
teardown_test_table(self.table_name, self.sqlalchemy_url)
126+
teardown_test_table(cls.table_name, cls.sqlalchemy_url)
126127

127128

128129
class TestTapPostgres_NOSQLALCHMY(TapPostgresTestNOSQLALCHEMY): # noqa: N801 # ty:ignore[unsupported-base]
129130
table_name = TABLE_NAME
130131
sqlalchemy_url = SAMPLE_CONFIG["sqlalchemy_url"]
131132

132133
@pytest.fixture(scope="class")
133-
def resource(self):
134-
setup_test_table(self.table_name, self.sqlalchemy_url)
134+
@classmethod
135+
def resource(cls):
136+
setup_test_table(cls.table_name, cls.sqlalchemy_url)
135137
yield
136-
teardown_test_table(self.table_name, self.sqlalchemy_url)
138+
teardown_test_table(cls.table_name, cls.sqlalchemy_url)
137139

138140

139141
class TestTapPostgresSelectedColumnsOnly(TapPostgresTestSelectedColumnsOnly): # ty:ignore[unsupported-base]
140142
table_name = TABLE_NAME_SELECTED_COLUMNS_ONLY
141143
sqlalchemy_url = SAMPLE_CONFIG["sqlalchemy_url"]
142144

143145
@pytest.fixture(scope="class")
144-
def resource(self):
145-
setup_test_table(self.table_name, self.sqlalchemy_url)
146+
@classmethod
147+
def resource(cls):
148+
setup_test_table(cls.table_name, cls.sqlalchemy_url)
146149
yield
147-
teardown_test_table(self.table_name, self.sqlalchemy_url)
150+
teardown_test_table(cls.table_name, cls.sqlalchemy_url)
148151

149152

150153
def test_temporal_datatypes():

0 commit comments

Comments
 (0)