Commit 945f77c
chore: Standardise on queryAll operation in Bulk API 2.0 implementation (#77)
## Description
Currently, the Bulk API 2.0 implementation uses `query` operation while
both REST API and Bulk API 1.0 use `queryAll`. This inconsistency means
that Bulk API 2.0 might miss deleted and archived records that are
captured by the other API types.
## Current Behavior
- REST API uses `queryAll`
- Bulk API 1.0 uses `queryAll`
- Bulk API 2.0 uses `query`
## Expected Behavior
All API types should use `queryAll` to ensure consistent behavior and
data completeness across different API implementations.
## Technical Details
The change required is in `tap_salesforce/salesforce/bulk2.py`, updating
the operation from "query" to "queryAll" in the `_create_job` method.
## References
- [Salesforce REST API queryAll
Documentation](https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_queryall.htm)
- [Salesforce Bulk API
Documentation](https://developer.salesforce.com/docs/atlas.en-us.api_asynch.meta/api_asynch/query_create_job.htm)
## Impact
This change will ensure that Bulk API 2.0 returns the same set of
records as the other API types, including deleted and archived records.
## Type
- [x] Chore
- [x] Documentation
---------
Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>1 parent 2b3fac1 commit 945f77c
3 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
0 commit comments