requests needs a timeout

[camerondavison]

This was solved in the singer tap like https://github.com/singer-io/tap-salesforce/pull/114/commits

By default requests does not have any connect timeout https://requests.readthedocs.io/en/latest/user/advanced/#timeouts but it should

This is the currently recommended way to set timeout for simple salesforce as far as I know

simple-salesforce/simple-salesforce#148 (comment)

---

This is causing problems for our cronjob which is periodically freezing due to some dropped packet that then leaves the connection open.

[edgarrmondragon]

Hi @camerondavison! PRs welcome, I think it should as easy as updating some lines here

tap-salesforce/tap_salesforce/salesforce/__init__.py

Lines 308 to 316 in 6ec2bd5

	def _make_request(self, http_method, url, headers=None, body=None, stream=False, params=None):
	if http_method == "GET":
	LOGGER.info("Making %s request to %s with params: %s", http_method, url, params)
	resp = self.session.get(url, headers=headers, stream=stream, params=params)
	elif http_method == "POST":
	LOGGER.info("Making %s request to %s with body %s", http_method, url, body)
	resp = self.session.post(url, headers=headers, data=body)
	else:
	raise TapSalesforceException("Unsupported HTTP method")