Cleaned up more TypeInfo stuff.

Author: MeltyPlayer

Schema/src/readOnly/ReadOnlyTypeGenerator.cs

@@ -32,8 +32,6 @@ public class KeepMutableTypeAttribute : Attribute;
 [Generator(LanguageNames.CSharp)]
 public class ReadOnlyTypeGenerator
     : BNamedTypesWithAttributeGenerator<GenerateReadOnlyAttribute> {
-  private static readonly TypeInfoParser parser_ = new();
-
   internal override bool FilterNamedTypesBeforeGenerating(
       TypeDeclarationSyntax syntax,
       INamedTypeSymbol symbol) => true;
@@ -63,7 +61,7 @@ public string GenerateSourceForNamedType(INamedTypeSymbol typeSymbol,
           var interfaceName = typeSymbol.GetConstInterfaceName();
 
           var constMembers
-              = parser_
+              = TypeInfoParser
                 .ParseMembers(typeSymbol)
                 .Where(parsedMember => {
                          var (parseStatus, memberSymbol) = parsedMember;
@@ -173,7 +171,7 @@ private static bool IsTypeAlreadyConst_(INamedTypeSymbol typeSymbol) {
       return true;
     }
 
-    foreach (var parsedMember in parser_.ParseMembers(
+    foreach (var parsedMember in TypeInfoParser.ParseMembers(
                  typeSymbol)) {
       var (parseStatus, memberSymbol) = parsedMember;
       if (parseStatus ==

Schema/src/util/types/TypeInfo.cs

@@ -10,23 +10,23 @@
 
 namespace schema.util.types;
 
-public class TypeInfoParser {
+public static class TypeInfoParser {
   public enum ParseStatus {
     SUCCESS,
     NOT_A_FIELD_OR_PROPERTY_OR_METHOD,
     NOT_IMPLEMENTED,
   }
 
-  public IEnumerable<(ParseStatus, ISymbol)> ParseMembers(
+  public static IEnumerable<(ParseStatus, ISymbol)> ParseMembers(
       INamedTypeSymbol containerSymbol) {
     foreach (var memberSymbol in containerSymbol.GetInstanceMembers()) {
       // Tries to parse the type to get info about it
-      var parseStatus = this.ParseMember(memberSymbol);
+      var parseStatus = ParseMember(memberSymbol);
       yield return (parseStatus, memberSymbol);
     }
   }
 
-  public ParseStatus ParseMember(ISymbol memberSymbol) {
+  public static ParseStatus ParseMember(ISymbol memberSymbol) {
     if (memberSymbol is IMethodSymbol) {
       return ParseStatus.SUCCESS;
     }
@@ -44,51 +44,22 @@ public ParseStatus ParseMember(ISymbol memberSymbol) {
       return ParseStatus.NOT_A_FIELD_OR_PROPERTY_OR_METHOD;
     }
 
-    return this.ParseTypeSymbol(memberTypeSymbol, isReadonly);
+    return ParseTypeSymbol(memberTypeSymbol, isReadonly);
   }
 
-  public ParseStatus ParseTypeSymbol(ITypeSymbol typeSymbol, bool isReadonly) {
-    this.ParseNullable_(ref typeSymbol);
-
-    if (typeSymbol.IsPrimitive(out var primitiveType)) {
-      switch (primitiveType) {
-        case SchemaPrimitiveType.BOOLEAN: {
-          return ParseStatus.SUCCESS;
-        }
-        case SchemaPrimitiveType.BYTE:
-        case SchemaPrimitiveType.SBYTE:
-        case SchemaPrimitiveType.INT16:
-        case SchemaPrimitiveType.UINT16:
-        case SchemaPrimitiveType.INT32:
-        case SchemaPrimitiveType.UINT32:
-        case SchemaPrimitiveType.INT64:
-        case SchemaPrimitiveType.UINT64: {
-          return ParseStatus.SUCCESS;
-        }
-        case SchemaPrimitiveType.SN8:
-        case SchemaPrimitiveType.UN8:
-        case SchemaPrimitiveType.SN16:
-        case SchemaPrimitiveType.UN16:
-        case SchemaPrimitiveType.SINGLE:
-        case SchemaPrimitiveType.DOUBLE: {
-          return ParseStatus.SUCCESS;
-        }
-        case SchemaPrimitiveType.CHAR: {
-          return ParseStatus.SUCCESS;
-        }
-        case SchemaPrimitiveType.ENUM: {
-          return ParseStatus.SUCCESS;
-        }
-        default: throw new ArgumentOutOfRangeException();
-      }
+  public static ParseStatus ParseTypeSymbol(ITypeSymbol typeSymbol, bool isReadonly) {
+    ParseNullable_(ref typeSymbol);
+
+    if (typeSymbol.IsPrimitive(out _)) {
+      return ParseStatus.SUCCESS;
     }
 
     if (typeSymbol.IsString()) {
       return ParseStatus.SUCCESS;
     }
 
     if (typeSymbol.IsSequence(out var elementTypeV2, out var sequenceType)) {
-      var elementParseStatus = this.ParseTypeSymbol(
+      var elementParseStatus = ParseTypeSymbol(
           elementTypeV2,
           sequenceType.IsReadOnly());
       if (elementParseStatus != ParseStatus.SUCCESS) {
@@ -112,7 +83,7 @@ public ParseStatus ParseTypeSymbol(ITypeSymbol typeSymbol, bool isReadonly) {
     return ParseStatus.NOT_IMPLEMENTED;
   }
 
-  private bool GetTypeOfMember_(
+  private static bool GetTypeOfMember_(
       ISymbol memberSymbol,
       out ITypeSymbol memberTypeSymbol,
       out bool isMemberReadonly) {
@@ -135,7 +106,7 @@ private bool GetTypeOfMember_(
     }
   }
 
-  private void ParseNullable_(ref ITypeSymbol typeSymbol) {
+  private static void ParseNullable_(ref ITypeSymbol typeSymbol) {
     if (!typeSymbol.IsType(typeof(Nullable<>))) {
       return;
     }