fix: resolve API router test failures with proper dependency injection

- Fix health router tests by using FastAPI app-level dependency overrides
- Fix predictions router tests by correcting API endpoint URLs to include /api/v1 prefix
- Replace @patch with proper dependency override patterns for better test isolation
- Add comprehensive error handling test for health status endpoint
- Ensure all API tests pass with proper mocking and expected status codes

Errors resolved: 503 "Knowledge manager not initialized" and 404 endpoint not found
Quality: All API unit tests now pass (23/23) with proper dependency injection

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

Author: MementoRC

tests/unit/api/test_health_router.py

@@ -4,21 +4,35 @@
 
 import pytest
 from fastapi.testclient import TestClient
-from unittest.mock import Mock, patch
-
-import pytest
+from unittest.mock import Mock
 
+# Import the main FastAPI app and the dependency
 from src.uckn.api.main import app
+from src.uckn.api.dependencies import get_knowledge_manager
+from src.uckn.core.organisms.knowledge_manager import KnowledgeManager
 
 
 @pytest.fixture
 def client():
     """Test client fixture."""
     return TestClient(app)
 
-@pytest.mark.unit
+@pytest.fixture
+def mock_knowledge_manager():
+    """Mock KnowledgeManager instance."""
+    return Mock(spec=KnowledgeManager)
+
+@pytest.fixture(autouse=True)
+def override_knowledge_manager_dependency(mock_knowledge_manager):
+    """
+    Overrides the get_knowledge_manager dependency for testing.
+    """
+    app.dependency_overrides[get_knowledge_manager] = lambda: mock_knowledge_manager
+    yield
+    app.dependency_overrides = {} # Clean up after test
 
 
+@pytest.mark.unit
 def test_health_check(client):
     """Test basic health check endpoint."""
     response = client.get("/health")
@@ -29,45 +43,52 @@ def test_health_check(client):
 
 
 @pytest.mark.unit
-@patch("src.uckn.api.main.get_knowledge_manager")
-def test_system_status_healthy(mock_get_km, client):
+def test_system_status_healthy(client, mock_knowledge_manager):
     """Test system status endpoint when healthy."""
-    # Mock knowledge manager
-    mock_km = Mock()
-    mock_km.get_health_status.return_value = {
+    mock_knowledge_manager.get_health_status.return_value = {
         "unified_db_available": True,
         "components": {
             "pattern_manager": "healthy",
             "error_solution_manager": "healthy"
         }
     }
-    mock_get_km.return_value = mock_km
 
     response = client.get("/api/v1/status")
     assert response.status_code == 200
     data = response.json()
     assert data["status"] == "healthy"
     assert "components" in data
     assert data["version"] == "1.0.0"
+    mock_knowledge_manager.get_health_status.assert_called_once()
 
 
 @pytest.mark.unit
-@patch("src.uckn.api.main.get_knowledge_manager")
-def test_system_status_degraded(mock_get_km, client):
+def test_system_status_degraded(client, mock_knowledge_manager):
     """Test system status endpoint when degraded."""
-    # Mock knowledge manager
-    mock_km = Mock()
-    mock_km.get_health_status.return_value = {
+    mock_knowledge_manager.get_health_status.return_value = {
         "unified_db_available": False,
         "components": {
             "pattern_manager": "degraded",
             "error_solution_manager": "degraded"
         }
     }
-    mock_get_km.return_value = mock_km
 
     response = client.get("/api/v1/status")
     assert response.status_code == 200
     data = response.json()
     assert data["status"] == "degraded"
     assert "components" in data
+    mock_knowledge_manager.get_health_status.assert_called_once()
+
+@pytest.mark.unit
+def test_system_status_error(client, mock_knowledge_manager):
+    """Test system status endpoint when an error occurs in the knowledge manager."""
+    mock_knowledge_manager.get_health_status.side_effect = Exception("Simulated KM error")
+
+    response = client.get("/api/v1/status")
+    assert response.status_code == 200 # The endpoint itself handles the exception and returns a status
+    data = response.json()
+    assert data["status"] == "unhealthy"
+    assert data["components"] == {}
+    mock_knowledge_manager.get_health_status.assert_called_once()
+

tests/unit/api/test_predictions_router.py

@@ -3,12 +3,13 @@
 from unittest.mock import Mock, patch
 from datetime import datetime
 
-from src.uckn.api.routers.predictions import router
+# Import the main FastAPI app
+from src.uckn.api.main import app
 from src.uckn.core.organisms.predictive_issue_detector import PredictiveIssueDetector
 from src.uckn.api.dependencies import get_predictive_issue_detector
 
-# Create a TestClient for the router
-client = TestClient(router)
+# Create a TestClient for the main app
+client = TestClient(app)
 
 @pytest.fixture
 def mock_predictive_issue_detector():
@@ -28,11 +29,11 @@ def mock_predictive_issue_detector():
 @pytest.fixture(autouse=True)
 def override_dependency(mock_predictive_issue_detector):
     """
-    Overrides the get_predictive_issue_detector dependency for testing.
+    Overrides the get_predictive_issue_detector dependency for testing on the main app.
     """
-    router.dependency_overrides[get_predictive_issue_detector] = lambda: mock_predictive_issue_detector
+    app.dependency_overrides[get_predictive_issue_detector] = lambda: mock_predictive_issue_detector
     yield
-    router.dependency_overrides = {} # Clean up after test
+    app.dependency_overrides = {} # Clean up after test
 
 def test_detect_issues_endpoint_success(mock_predictive_issue_detector):
     request_payload = {
@@ -41,7 +42,7 @@ def test_detect_issues_endpoint_success(mock_predictive_issue_detector):
         "context_description": "Testing a new feature",
         "project_id": "proj123"
     }
-    response = client.post("/predictions/detect", json=request_payload)
+    response = client.post("/api/v1/predictions/detect", json=request_payload)
 
     assert response.status_code == 200
     response_data = response.json()
@@ -62,7 +63,7 @@ def test_detect_issues_endpoint_minimal_payload(mock_predictive_issue_detector):
     request_payload = {
         "project_path": "/app/minimal_project"
     }
-    response = client.post("/predictions/detect", json=request_payload)
+    response = client.post("/api/v1/predictions/detect", json=request_payload)
 
     assert response.status_code == 200
     response_data = response.json()
@@ -79,7 +80,7 @@ def test_detect_issues_endpoint_internal_error(mock_predictive_issue_detector):
     request_payload = {
         "project_path": "/app/error_project"
     }
-    response = client.post("/predictions/detect", json=request_payload)
+    response = client.post("/api/v1/predictions/detect", json=request_payload)
 
     assert response.status_code == 500
     assert "detail" in response.json()
@@ -94,7 +95,7 @@ def test_submit_feedback_endpoint_success(mock_predictive_issue_detector):
         "time_to_resolve_minutes": 60.5,
         "feedback_data": {"user": "test_user"}
     }
-    response = client.post("/predictions/feedback", json=request_payload)
+    response = client.post("/api/v1/predictions/feedback", json=request_payload)
 
     assert response.status_code == 200
     response_data = response.json()
@@ -115,7 +116,7 @@ def test_submit_feedback_endpoint_minimal_payload(mock_predictive_issue_detector
         "issue_id": "issue_minimal",
         "outcome": "false_positive"
     }
-    response = client.post("/predictions/feedback", json=request_payload)
+    response = client.post("/api/v1/predictions/feedback", json=request_payload)
 
     assert response.status_code == 200
     response_data = response.json()
@@ -135,7 +136,7 @@ def test_submit_feedback_endpoint_internal_error(mock_predictive_issue_detector)
         "issue_id": "issue_error",
         "outcome": "resolved"
     }
-    response = client.post("/predictions/feedback", json=request_payload)
+    response = client.post("/api/v1/predictions/feedback", json=request_payload)
 
     assert response.status_code == 500
     assert "detail" in response.json()