[lldb][API] Make SB-API functions const if possible. (llvm#172687)

Only applied to functions that were added after 22.x tag.

Author: da-viper

lldb/include/lldb/API/SBDebugger.h

@@ -360,7 +360,7 @@ class LLDB_API SBDebugger {
                                            const char *arch);
 
   /// Find a target with the specified unique ID.
-  lldb::SBTarget FindTargetByGloballyUniqueID(lldb::user_id_t id);
+  lldb::SBTarget FindTargetByGloballyUniqueID(lldb::user_id_t id) const;
 
   /// Get the number of targets in the debugger.
   uint32_t GetNumTargets();

lldb/include/lldb/API/SBModuleSpec.h

@@ -87,7 +87,7 @@ class LLDB_API SBModuleSpec {
 
   bool GetDescription(lldb::SBStream &description);
 
-  lldb::SBTarget GetTarget();
+  lldb::SBTarget GetTarget() const;
 
   /// Set the target to be used when resolving a module.
   ///

lldb/include/lldb/API/SBSaveCoreOptions.h

@@ -84,7 +84,7 @@ class LLDB_API SBSaveCoreOptions {
   ///
   /// \return
   ///   The set process, or an invalid SBProcess if no process is set.
-  SBProcess GetProcess();
+  SBProcess GetProcess() const;
 
   /// Add a thread to save in the core file.
   ///
@@ -132,7 +132,7 @@ class LLDB_API SBSaveCoreOptions {
   /// \returns
   ///   An unsorted copy of all memory regions to save. If no process or style
   ///   is specified an empty collection will be returned.
-  SBMemoryRegionInfoList GetMemoryRegionsToSave();
+  SBMemoryRegionInfoList GetMemoryRegionsToSave() const;
 
   /// Get the current total number of bytes the core is expected to have
   /// excluding the overhead of the core file format. Requires a Process and

lldb/include/lldb/API/SBSymbol.h

@@ -91,7 +91,7 @@ class LLDB_API SBSymbol {
   ///
   /// \returns
   ///   Returns the ID of this symbol.
-  uint32_t GetID();
+  uint32_t GetID() const;
 
   bool operator==(const lldb::SBSymbol &rhs) const;
 
@@ -108,7 +108,7 @@ class LLDB_API SBSymbol {
   bool IsSynthetic();
 
   /// Returns true if the symbol is a debug symbol.
-  bool IsDebug();
+  bool IsDebug() const;
 
   /// Get the string representation of a symbol type.
   static const char *GetTypeAsString(lldb::SymbolType symbol_type);

lldb/include/lldb/API/SBTarget.h

@@ -338,7 +338,7 @@ class LLDB_API SBTarget {
   /// \return
   ///     A lldb::SBModule object that represents the found module, or an
   ///     invalid SBModule object if no module was found.
-  lldb::SBModule FindModule(const lldb::SBModuleSpec &module_spec);
+  lldb::SBModule FindModule(const lldb::SBModuleSpec &module_spec) const;
 
   /// Find compile units related to *this target and passed source
   /// file.
@@ -359,7 +359,7 @@ class LLDB_API SBTarget {
 
   const char *GetTriple();
 
-  const char *GetArchName();
+  const char *GetArchName() const;
 
   const char *GetABIName();
 

lldb/include/lldb/API/SBThread.h

@@ -186,7 +186,7 @@ class LLDB_API SBThread {
 
   lldb::SBFrame GetFrameAtIndex(uint32_t idx);
 
-  lldb::SBFrameList GetFrames();
+  lldb::SBFrameList GetFrames() const;
 
   lldb::SBFrame GetSelectedFrame();
 

lldb/include/lldb/Symbol/SaveCoreOptions.h

@@ -37,7 +37,7 @@ class SaveCoreOptions {
   const std::optional<lldb_private::FileSpec> GetOutputFile() const;
 
   Status SetProcess(lldb::ProcessSP process_sp);
-  lldb::ProcessSP GetProcess() { return m_process_sp; }
+  lldb::ProcessSP GetProcess() const { return m_process_sp; }
 
   Status AddThread(lldb::ThreadSP thread_sp);
   bool RemoveThread(lldb::ThreadSP thread_sp);

lldb/source/API/SBDebugger.cpp

@@ -937,7 +937,7 @@ uint32_t SBDebugger::GetIndexOfTarget(lldb::SBTarget target) {
   return m_opaque_sp->GetTargetList().GetIndexOfTarget(target.GetSP());
 }
 
-SBTarget SBDebugger::FindTargetByGloballyUniqueID(lldb::user_id_t id) {
+SBTarget SBDebugger::FindTargetByGloballyUniqueID(lldb::user_id_t id) const {
   LLDB_INSTRUMENT_VA(this, id);
   SBTarget sb_target;
   if (m_opaque_sp) {

lldb/source/API/SBModuleSpec.cpp

@@ -175,7 +175,7 @@ void SBModuleSpec::SetObjectSize(uint64_t object_size) {
   m_opaque_up->SetObjectSize(object_size);
 }
 
-SBTarget SBModuleSpec::GetTarget() {
+SBTarget SBModuleSpec::GetTarget() const {
   LLDB_INSTRUMENT_VA(this);
 
   return SBTarget(m_opaque_up->GetTargetSP());

lldb/source/API/SBSaveCoreOptions.cpp

@@ -81,7 +81,7 @@ SBError SBSaveCoreOptions::SetProcess(lldb::SBProcess process) {
   return m_opaque_up->SetProcess(process.GetSP());
 }
 
-SBProcess SBSaveCoreOptions::GetProcess() {
+SBProcess SBSaveCoreOptions::GetProcess() const {
   LLDB_INSTRUMENT_VA(this);
   return SBProcess(m_opaque_up->GetProcess());
 }
@@ -133,7 +133,7 @@ uint64_t SBSaveCoreOptions::GetCurrentSizeInBytes(SBError &error) {
   return *expected_bytes;
 }
 
-lldb::SBMemoryRegionInfoList SBSaveCoreOptions::GetMemoryRegionsToSave() {
+lldb::SBMemoryRegionInfoList SBSaveCoreOptions::GetMemoryRegionsToSave() const {
   LLDB_INSTRUMENT_VA(this);
   llvm::Expected<lldb_private::CoreFileMemoryRanges> memory_ranges =
       m_opaque_up->GetMemoryRegionsToSave();