fix adding builtin snippets

Author: Menrath

classes/snippets.php

@@ -196,6 +196,7 @@ private static function cleanup_header_comment($str) {
      *
      * @param string $file            Absolute path to the file.
      *
+     * @copyright forked from https://developer.wordpress.org/reference/functions/get_file_data/
      * @return string[] Array of file header values keyed by header name.
      */
     public static function get_snippet_meta_from_file($file) {
@@ -248,6 +249,7 @@ public static function add_builtin_snippets() {
         global $DB;
         $paths = self::get_builtin_snippet_paths();
 
+        // Get builtin snippets which are known in the database.
         $present = $DB->get_records(
             'theme_boost_union_snippets',
             ['source' => 'theme_boost_union'],
@@ -257,7 +259,8 @@ public static function add_builtin_snippets() {
             0,
         );
 
-        $sortorder = empty($present) ? 0 : $present[0]->sortorder + 1;
+        // Get the highest sortorder present.
+        $sortorder = empty($present) ? 0 : intval(reset($present)->sortorder) + 1;
 
         foreach ($paths as $path) {
             if (!array_key_exists($path, $present)) {
@@ -269,6 +272,7 @@ public static function add_builtin_snippets() {
                         'sortorder' => $sortorder,
                     ]
                 );
+                // We add each record with incrementing sortorder.
                 $sortorder += 1;
             }
         }

version.php

@@ -25,7 +25,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'theme_boost_union';
-$plugin->version = 2024060109;
+$plugin->version = 2024060110;
 $plugin->release = 'v4.4-r1';
 $plugin->requires = 2024042200;
 $plugin->supported = [404, 404];