Skip to content

Commit d7a32da

Browse files
committed
refactor: remove cmd / cmda handlers
1 parent 372d78c commit d7a32da

File tree

5 files changed

+11
-70
lines changed

5 files changed

+11
-70
lines changed

resbibman/core/serverConn.py

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -163,24 +163,23 @@ def deleteData(self, uid: str) -> bool:
163163
return self._checkRes(res)
164164

165165
def deleteTag(self, tag_to_be_deleted: str) -> bool:
166+
post_url = self.SERVER_URL + "/dataman/tag-delete"
166167
post_args = {
167168
"key": self.hash_key,
168-
"cmd": "deleteTagAll",
169-
"uuid": "_",
170-
"args": json.dumps([tag_to_be_deleted]),
171-
"kwargs": json.dumps({})
169+
"tag": tag_to_be_deleted
172170
}
173-
return self._remoteCMD(post_args)
171+
res = requests.post(post_url, data = post_args)
172+
return self._checkRes(res)
174173

175174
def renameTag(self, src_tag: str, dst_tag: str) -> bool:
175+
post_url = self.SERVER_URL + "/dataman/tag-rename"
176176
post_args = {
177177
"key": self.hash_key,
178-
"cmd": "renameTagAll",
179-
"uuid": "_",
180-
"args": json.dumps([src_tag, dst_tag]),
181-
"kwargs": json.dumps({})
178+
"oldTag": src_tag,
179+
"newTag": dst_tag
182180
}
183-
return self._remoteCMD(post_args)
181+
res = requests.post(post_url, data = post_args)
182+
return self._checkRes(res)
184183

185184
def postDiscussion(self, uid: str, name: str, content: str) -> bool:
186185
post_url = self.SERVER_URL + "/discussion_mod"
@@ -194,14 +193,6 @@ def postDiscussion(self, uid: str, name: str, content: str) -> bool:
194193
res = requests.post(url = post_url, data = post_args)
195194
return self._checkRes(res)
196195

197-
def _remoteCMD(self, post_args) -> bool:
198-
"""
199-
post command to remote/cmdA
200-
"""
201-
post_addr = "{}/cmdA".format(self.SERVER_URL)
202-
res = requests.post(post_addr, params = post_args)
203-
return self._checkRes(res)
204-
205196
def getDocURL(self, uid: str, dtype: Literal["pdf, hpack"]) -> str:
206197
if dtype == "pdf":
207198
return self.SERVER_URL + "/doc/{}".format(uid)

resbibman/server/handlers/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from .dataInfo import DataInfoHandler, DataListHandler
22
from .documents import DocHandler, HDocHandler
3-
from .commands import CMDArgHandler, CMDHandler
43
from .comment import CommentHandler
54
from .file import FileHandler
65
from .auth import AuthHandler

resbibman/server/handlers/commands.py

Lines changed: 0 additions & 47 deletions
This file was deleted.

resbibman/server/handlers/dataMan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def post(self):
155155
# only admin can rename tags
156156
raise tornado.web.HTTPError(403)
157157
self.db.renameTag(old_tag, new_tag)
158-
self.logger.info(f"Tag {old_tag} renamed to {new_tag}")
158+
self.logger.info(f"Tag [{old_tag}] renamed to [{new_tag}] by [{permission['identifier']}]")
159159
self.write("OK")
160160

161161
class TagDeleteHandler(RequestHandlerMixin, tornado.web.RequestHandler):
@@ -170,5 +170,5 @@ def post(self):
170170
# only admin can delete tags
171171
raise tornado.web.HTTPError(403)
172172
self.db.deleteTag(tag)
173-
self.logger.info(f"Tag {tag} deleted")
173+
self.logger.info(f"Tag [{tag}] deleted by [{permission['identifier']}]")
174174
self.write("OK")

resbibman/server/main.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ def __init__(self) -> None:
3535
(r"/comment/(.*)", CommentHandler, {"path": "/"}),
3636

3737
## For both clients
38-
# (r"/cmd/(.*)", CMDHandler), # will replace (reload-db)
39-
(r"/cmdA", CMDArgHandler), # will replace
4038
(r"/discussions/(.*)", DiscussionHandler),
4139
(r"/discussion_mod", DiscussionModHandler),
4240
(r"/summary", SummaryHandler), # may deprecate

0 commit comments

Comments
 (0)