fix: address critical issues in managed agents implementation

- Replace raw HTTP calls with proper SDK methods in CLI commands
- Fix ExecutionConfig constructor to remove invalid compute_provider param
- Map sandbox_type to proper code_sandbox_mode parameter
- Fix trace emission to use actual ContextTraceEmitter API methods
- Remove unnecessary getattr usage in tests per Ruff B009
- Add proper error exit codes for CLI command failures
- Agents use archive() instead of delete() per Anthropic SDK

Fixes all critical issues identified by CodeRabbit review.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>

Author: praisonai-triage-agent[bot]

src/praisonai/praisonai/cli/commands/managed.py

@@ -550,11 +550,12 @@ def sessions_delete(
 
     client = _get_client()
     try:
-        # For Anthropic managed agents, delete via API
-        response = client.delete(f"/v1/agent_sessions/{session_id}")
+        # Use SDK resource method
+        client.beta.sessions.delete(session_id)
         typer.secho(f"Session {session_id} deleted", fg="green")
     except Exception as e:
         typer.secho(f"Failed to delete session: {e}", fg="red")
+        raise typer.Exit(1)
 
 
 @agents_app.command("delete")
@@ -571,10 +572,12 @@ def agents_delete(
 
     client = _get_client()
     try:
-        response = client.delete(f"/v1/agents/{agent_id}")
-        typer.secho(f"Agent {agent_id} deleted", fg="green")
+        # Agents use archive, not delete
+        client.beta.agents.archive(agent_id)
+        typer.secho(f"Agent {agent_id} archived", fg="green")
     except Exception as e:
-        typer.secho(f"Failed to delete agent: {e}", fg="red")
+        typer.secho(f"Failed to archive agent: {e}", fg="red")
+        raise typer.Exit(1)
 
 
 @envs_app.command("update")
@@ -586,21 +589,23 @@ def envs_update(
     """Update a managed environment."""
     if not name and not description:
         typer.echo("Must specify at least --name or --description")
-        return
+        raise typer.Exit(0)
 
     client = _get_client()
     try:
-        data = {}
+        # Use SDK resource method
+        kwargs = {}
         if name:
-            data["name"] = name
+            kwargs["name"] = name
         if description:
-            data["description"] = description
+            kwargs["description"] = description
 
-        response = client.patch(f"/v1/environments/{env_id}", json=data)
+        response = client.beta.environments.update(env_id, **kwargs)
         typer.secho(f"Environment {env_id} updated", fg="green")
-        typer.echo(json.dumps(response.json(), indent=2))
+        typer.echo(str(response))
     except Exception as e:
         typer.secho(f"Failed to update environment: {e}", fg="red")
+        raise typer.Exit(1)
 
 
 @envs_app.command("delete")
@@ -617,10 +622,12 @@ def envs_delete(
 
     client = _get_client()
     try:
-        response = client.delete(f"/v1/environments/{env_id}")
+        # Use SDK resource method
+        client.beta.environments.delete(env_id)
         typer.secho(f"Environment {env_id} deleted", fg="green")
     except Exception as e:
         typer.secho(f"Failed to delete environment: {e}", fg="red")
+        raise typer.Exit(1)
 
 
 # ─────────────────────────────────────────────────────────────────────────────

src/praisonai/praisonai/integrations/managed_local.py

@@ -545,11 +545,15 @@ def _ensure_agent(self) -> Any:
         execution_config = None
         if self._compute:
             from praisonaiagents import ExecutionConfig
+            # Map sandbox_type to proper code_sandbox_mode
+            sandbox_type = self._cfg.get("sandbox_type", "subprocess")
+            code_sandbox_mode = "sandbox" if sandbox_type == "subprocess" else "direct"
             execution_config = ExecutionConfig(
                 code_execution=True,
-                code_mode=self._cfg.get("sandbox_type", "subprocess"),
-                compute_provider=self._compute
+                code_mode=self._cfg.get("code_mode", "safe"),
+                code_sandbox_mode=code_sandbox_mode
             )
+            # Compute provider is managed directly by this backend
 
         agent_kwargs: Dict[str, Any] = {
             "name": name,
@@ -923,16 +927,27 @@ def _emit_trace_event(self, event_type: str, data: Dict[str, Any]) -> None:
         try:
             from praisonaiagents.trace import get_context_emitter
             emitter = get_context_emitter()
-            if emitter and hasattr(emitter, 'emit_action'):
-                emitter.emit_action(
-                    action_type=event_type,
-                    data={
-                        **data,
-                        "agent_id": self.agent_id,
-                        "provider": self.provider,
-                        "timestamp": time.time()
-                    }
-                )
+            if emitter:
+                # Map managed event types to ContextTraceEmitter methods
+                enhanced_data = {
+                    **data,
+                    "agent_id": self.agent_id,
+                    "provider": self.provider,
+                    "timestamp": time.time()
+                }
+                
+                if event_type.startswith("managed.session"):
+                    if "created" in event_type or "start" in event_type:
+                        emitter.session_start(enhanced_data)
+                    elif "reset" in event_type:
+                        emitter.session_end(enhanced_data)
+                elif event_type.startswith("managed.execution"):
+                    if "start" in event_type:
+                        emitter.agent_start(enhanced_data)
+                    elif "complete" in event_type or "error" in event_type:
+                        emitter.agent_end(enhanced_data)
+                # For other events, we could add a generic emit if available
+                # or just log them for now
         except Exception as e:
             logger.debug("[local_managed] trace emit failed: %s", e)
 

src/praisonai/tests/unit/integrations/test_managed_agents.py

@@ -184,8 +184,8 @@ def test_managed_agent_protocol_compliance():
     assert hasattr(local_agent, 'reset_all')
 
     # Test method signatures exist and are callable
-    assert callable(getattr(local_agent, 'execute'))
-    assert callable(getattr(local_agent, 'stream'))
+    assert callable(local_agent.execute)
+    assert callable(local_agent.stream)
 
 
 @pytest.mark.asyncio