test: enforce fail-fast acquire_sync behavior in async contexts

Agent-Logs-Url: https://github.com/MervinPraison/PraisonAI/sessions/c9e7c913-a80d-474a-bd5d-731c129ad614

Co-authored-by: MervinPraison <454862+MervinPraison@users.noreply.github.com>

Author: Copilot

src/praisonai-agents/praisonaiagents/agent/concurrency.py

@@ -87,25 +87,26 @@ def acquire_sync(self, agent_name: str) -> None:
         """Synchronous acquire — for non-async code paths.
         
         Prefer async acquire() when possible.
+        If called while an event loop is already running in the current thread,
+        this method raises RuntimeError to avoid deadlock.
         """
         sem = self._get_semaphore(agent_name)
         if sem is None:
             return
         try:
             asyncio.get_running_loop()
-            # Running loop in current thread: blocking here can deadlock.
-            logger.warning(
-                f"acquire_sync('{agent_name}') called with a running event loop; "
-                "use async acquire() in async contexts."
-            )
-            return
         except RuntimeError:
             # No running loop — safe to create one
             loop = asyncio.new_event_loop()
             try:
                 loop.run_until_complete(sem.acquire())
             finally:
                 loop.close()
+        else:
+            raise RuntimeError(
+                f"acquire_sync('{agent_name}') cannot be called with a running event loop; "
+                "use async acquire() in async contexts."
+            )
 
     def release(self, agent_name: str) -> None:
         """Release concurrency slot for agent. No-op if unlimited."""

src/praisonai-agents/tests/unit/agent/test_agent_concurrency.py

@@ -109,10 +109,15 @@ def test_sync_acquire_release(self):
 
     @pytest.mark.asyncio
     async def test_sync_acquire_running_loop_noop(self):
-        """Sync acquire in async context should not block event loop."""
+        """Sync acquire in async context should fail fast without changing state."""
         from praisonaiagents.agent.concurrency import ConcurrencyRegistry
         reg = ConcurrencyRegistry()
         reg.set_limit("loop_agent", 1)
         await reg.acquire("loop_agent")
-        reg.acquire_sync("loop_agent")
+        with pytest.raises(RuntimeError, match="running event loop"):
+            reg.acquire_sync("loop_agent")
+        with pytest.raises(asyncio.TimeoutError):
+            await asyncio.wait_for(reg.acquire("loop_agent"), timeout=0.05)
+        reg.release("loop_agent")
+        await asyncio.wait_for(reg.acquire("loop_agent"), timeout=0.05)
         reg.release("loop_agent")