fix: address approval fallback regression and alias precedence in ApprovalSpec

Agent-Logs-Url: https://github.com/MervinPraison/PraisonAI/sessions/855181c2-fd9f-4360-b772-7f8102042df2

Co-authored-by: MervinPraison <454862+MervinPraison@users.noreply.github.com>

Author: Copilot

src/praisonai/praisonai/_approval_spec.py

@@ -105,8 +105,14 @@ def from_yaml(cls, node: Union[None, bool, str, Dict[str, Any]]) -> "ApprovalSpe
 
             # Handle legacy aliases
             backend = node.get("backend") or node.get("backend_name", "console")
-            approve_all_tools = node.get("approve_all_tools") or node.get("all_tools", False)
-            timeout_val = node.get("timeout") or node.get("approval_timeout")
+            if "approve_all_tools" in node:
+                approve_all_tools = node.get("approve_all_tools")
+            else:
+                approve_all_tools = node.get("all_tools", False)
+            if "timeout" in node:
+                timeout_val = node.get("timeout")
+            else:
+                timeout_val = node.get("approval_timeout")
 
             return cls(
                 enabled=node.get("enabled", True),
@@ -131,4 +137,4 @@ def to_dict(self) -> Dict[str, Any]:
             result["approve_level"] = self.approve_level
         if self.guardrails is not None:
             result["guardrails"] = self.guardrails
-        return result
+        return result

src/praisonai/praisonai/agents_generator.py

@@ -1219,9 +1219,9 @@ def _run_praisonai(self, config, topic, tools_dict):
                     try:
                         from praisonaiagents.approval.protocols import ApprovalConfig
                         approval_config = ApprovalConfig(
-                            backend=approval_dict.get('backend', None),
-                            all_tools=approval_dict.get('approve_all_tools', approval_dict.get('all_tools', False)),
-                            timeout=approval_dict.get('approval_timeout', approval_dict.get('timeout', 0))
+                            backend=spec.backend,
+                            all_tools=spec.approve_all_tools,
+                            timeout=spec.timeout
                         )
                     except ImportError:
                         # Last resort: disable approval for this agent
@@ -1350,4 +1350,4 @@ def _run_praisonai(self, config, topic, tools_dict):
         if AGENTOPS_AVAILABLE:
             agentops.end_session("Success")
 
-        return result
+        return result

src/praisonai/praisonai/bots/_approval_base.py

@@ -10,7 +10,6 @@
 
 from __future__ import annotations
 
-import asyncio
 import logging
 from typing import Set
 

src/praisonai/tests/unit/test_approval_spec.py

@@ -0,0 +1,17 @@
+from praisonai._approval_spec import ApprovalSpec
+
+
+def test_from_yaml_prefers_primary_keys_over_legacy_aliases():
+    spec = ApprovalSpec.from_yaml(
+        {
+            "enabled": True,
+            "backend": "console",
+            "approve_all_tools": False,
+            "all_tools": True,
+            "timeout": 0,
+            "approval_timeout": 30,
+        }
+    )
+
+    assert spec.approve_all_tools is False
+    assert spec.timeout == 0