feat(gemini): Add support for Gemini internal tools#868
feat(gemini): Add support for Gemini internal tools#868praison-ai-bot[bot] wants to merge 3 commits intomainfrom
Conversation
Gemini: [Issue #867] Enable Use of Model Internal Tools
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@claude review this pull request and do a detailed analysis and fix this if the existing code doesn't have the solution implemented. Making sure it has backward compatibility, no existing features removed. After making those changes, again review the applied changes. Use @web to search if you dont know any information or to find the latest documentation or to find the latest version. Run the code if you think you need to run it to test it. Minimal code change to start with if required any changes. |
|
Claude finished @MervinPraison's task —— View job 🎉 PR Review Complete!I've completed a detailed review of the Gemini internal tools implementation. SummaryThe PR successfully implements support for Gemini's internal tools ( Code Review Findings✅ Strengths:
🟡 Observations:
💡 Suggested Improvements (for future PRs):
Usage Examplefrom praisonaiagents import Agent
# Create an agent with Gemini's internal tools
agent = Agent(
name="Research Assistant",
instructions="Help with research and analysis",
llm="gemini/gemini-2.0-flash",
gemini_google_search=True, # Enable Google Search
gemini_code_execution=True # Enable Code Execution
)
# The agent now has access to Google Search and can execute Python code
response = agent.chat("Search for the latest AI developments and create a summary")Verification
Final VerdictAPPROVED ✅ - The implementation is correct and ready for merge. It successfully enables Gemini's internal tools as intended in issue #867. |
- Add Gemini tools support for both custom LLM and standard OpenAI client paths - Create _prepare_gemini_tools() helper method to reduce code duplication - Update _format_tools_for_completion() to handle Gemini internal tools - Add test script and example documentation - Ensure backward compatibility maintained Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>
These test files were created for review purposes and are not part of the original PR
|
@claude review if the changes made are as per the requirements |
|
Claude encountered an error —— View job Claude Code is working on reviewing the PR… Todo List:
|
|
Claude finished @MervinPraison's task —— View job PR Review: Gemini Internal Tools ImplementationI've completed a thorough review of the changes to verify they meet the requirements. Todo List:
SummaryThe PR successfully implements support for Gemini's internal tools ( Implementation Analysis1. Agent Class Changes (
|

Fixes #867\n\nThis PR adds support for leveraging Gemini's internal tools, specifically Google Search Grounding and Code Execution.\n\n### Changes Made\n- Modified to include and parameters in the class.\n- Updated to correctly format and pass these tools to .