Update windows SEH handlers in other threads (#580)

* Update windows SEH handlers in other threads

* Fix build

Author: Grant Karapetyan

source/MRMesh/MRLog.cpp

@@ -53,6 +53,24 @@ void removeOldLogs( const std::filesystem::path& dir, int hours = 24 )
 }
 
 #ifndef __EMSCRIPTEN__
+#ifdef _WIN32
+class SignalObserver : public tbb::task_scheduler_observer {
+public:
+    SignalObserver( std::function<void()> func )
+        : task_scheduler_observer(),
+        func_{ func }
+    {
+        observe( true ); // activate the observer
+    }
+    void on_scheduler_entry( bool ) override
+    {
+        func_();
+    }
+private:
+    std::function<void()> func_;
+};
+#endif
+
 void crashSignalHandler( int signal )
 {
     spdlog::critical( "Crash signal: {}", signal );
@@ -134,8 +152,14 @@ Logger::Logger()
 
 void setupLoggerByDefault()
 {
+#ifdef NDEBUG
 #ifndef __EMSCRIPTEN__
     printStacktraceOnCrash();
+#ifdef _WIN32
+    // observe tbb threads creation and add signals handlers for them
+    static SignalObserver tbbObserver( [] () { printStacktraceOnCrash(); } );
+#endif
+#endif
 #endif
     redirectSTDStreamsToLogger();
     // write log to console

source/MRPch/MRTBB.h

@@ -22,6 +22,7 @@
 #include <tbb/task_arena.h>
 #include <tbb/task_group.h>
 #include <tbb/global_control.h>
+#include <tbb/task_scheduler_observer.h>
 #pragma warning(pop)
 
 #ifdef __EMSCRIPTEN__

source/MRViewer/MRProgressBar.cpp

@@ -7,6 +7,10 @@
 #include "MRPch/MRWasm.h"
 #include <GLFW/glfw3.h>
 
+#ifdef _WIN32
+#include <excpt.h>
+#endif
+
 #if defined( __EMSCRIPTEN__ ) && !defined( __EMSCRIPTEN_PTHREADS__ )
 namespace
 {
@@ -119,6 +123,7 @@ void ProgressBar::orderWithMainThreadPostProcessing( const char* name, TaskWithM
 
         instance.progress_ = 0.0f;
 
+        instance.task_ = task;
         instance.currentTask_ = 0;
         if ( taskCount == 1 )
             instance.currentTask_ = 1;
@@ -132,15 +137,15 @@ void ProgressBar::orderWithMainThreadPostProcessing( const char* name, TaskWithM
         ImGui::OpenPopup( instance.setupId_ );
         instance.lastPostEvent_ = std::chrono::system_clock::now();
 #if !defined( __EMSCRIPTEN__ ) || defined( __EMSCRIPTEN_PTHREADS__ )
-        instance.thread_ = std::thread( [task, &instance] ()
+        instance.thread_ = std::thread( [&instance] ()
         {
             SetCurrentThreadName( "ProgressBar" );
-            instance.tryRunTask_( task );
+            instance.tryRunTaskWithSehHandler_();
         } );
 #else
-        staticTaskForLaterCall = [&instance, task] () 
+        staticTaskForLaterCall = [&instance] () 
         {
-            instance.tryRunTask_( task );
+            instance.tryRunTaskWithSehHandler_();
         };
         emscripten_async_call( asyncCallTask, nullptr, 200 );
 #endif
@@ -249,11 +254,14 @@ ProgressBar::~ProgressBar()
         thread_.join();
 }
 
-void ProgressBar::tryRunTask_( TaskWithMainThreadPostProcessing task )
+void ProgressBar::tryRunTask_()
 {
+#ifndef NDEBUG
+    onFinish_ = task_();
+#else
     try
     {
-        onFinish_ = task();
+        onFinish_ = task_();
     }
     catch ( const std::bad_alloc& badAllocE )
     {
@@ -273,6 +281,28 @@ void ProgressBar::tryRunTask_( TaskWithMainThreadPostProcessing task )
                 menu->showErrorModal( msg );
         };
     }
+#endif
+}
+
+void ProgressBar::tryRunTaskWithSehHandler_()
+{
+#if !defined(_WIN32) || !defined(NDEBUG)
+    tryRunTask_();
+#else
+    __try
+    {
+        tryRunTask_();
+    }
+    __except ( EXCEPTION_EXECUTE_HANDLER )
+    {
+        onFinish_ = []()
+        {
+            spdlog::error( "Unknown exception occurred" );
+            if ( auto menu = getViewerInstance().getMenuPlugin() )
+                menu->showErrorModal( "Unknown exception occurred" );
+        };
+    }
+#endif
     finish_();
 }
 

source/MRViewer/MRProgressBar.h

@@ -50,9 +50,10 @@ class ProgressBar
     ProgressBar();
     ~ProgressBar();
 
-    // cover task execution with try catch block
+    // cover task execution with try catch block (in release only)
     // if catches exception shows error in main thread overriding user defined main thread post processing
-    void tryRunTask_( TaskWithMainThreadPostProcessing task );
+    void tryRunTask_();
+    void tryRunTaskWithSehHandler_();
 
     void postEvent_();
     void finish_();
@@ -63,6 +64,7 @@ class ProgressBar
     std::chrono::time_point<std::chrono::system_clock> lastPostEvent_;
 
     std::thread thread_;
+    TaskWithMainThreadPostProcessing task_;
     std::function<void()> onFinish_;
 
     // needed to be able to call progress bar from any point, not only from ImGui frame scope

source/MRViewer/MRViewer.cpp

@@ -224,7 +224,7 @@ int launchDefaultViewer( const Viewer::LaunchParams& params, const ViewerSetup&
     setup.setupSettingsManager( &viewer, params.name );
     setup.setupConfiguration( &viewer );
     setup.setupExtendedLibraries();
-#ifdef __EMSCRIPTEN__
+#if defined(__EMSCRIPTEN__) || !defined(NDEBUG)
     return viewer.launch( params );
 #else
     int res = 0;