enhance error logging for carpeater detection

Author: MrAlders0n

android/local.properties

@@ -1,5 +1,5 @@
 sdk.dir=/opt/homebrew/share/android-commandlinetools
 flutter.sdk=/opt/homebrew/share/flutter
-flutter.buildMode=debug
+flutter.buildMode=release
 flutter.versionName=1.0.0
-flutter.versionCode=1
+flutter.versionCode=1769917500

ios/Flutter/Generated.xcconfig

@@ -2,14 +2,14 @@
 FLUTTER_ROOT=/opt/homebrew/share/flutter
 FLUTTER_APPLICATION_PATH=/Users/schnobbc/Documents/Github/MeshMapper_Flutter_App
 COCOAPODS_PARALLEL_CODE_SIGN=true
-FLUTTER_TARGET=/Users/schnobbc/Documents/Github/MeshMapper_Flutter_App/lib/main.dart
+FLUTTER_TARGET=lib/main.dart
 FLUTTER_BUILD_DIR=build
 FLUTTER_BUILD_NAME=1.0.0
-FLUTTER_BUILD_NUMBER=1
+FLUTTER_BUILD_NUMBER=1769917500
 EXCLUDED_ARCHS[sdk=iphonesimulator*]=i386
 EXCLUDED_ARCHS[sdk=iphoneos*]=armv7
-DART_DEFINES=RkxVVFRFUl9WRVJTSU9OPTMuMzguOQ==,RkxVVFRFUl9DSEFOTkVMPXN0YWJsZQ==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049NjczMjNkZTI4NQ==,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049NTg3YzE4Zjg3Mw==,RkxVVFRFUl9EQVJUX1ZFUlNJT049My4xMC44
+DART_DEFINES=QVBQX1ZFUlNJT049QVBQLTE3Njk5MTc1MDA=,RkxVVFRFUl9WRVJTSU9OPTMuMzguOQ==,RkxVVFRFUl9DSEFOTkVMPXN0YWJsZQ==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049NjczMjNkZTI4NQ==,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049NTg3YzE4Zjg3Mw==,RkxVVFRFUl9EQVJUX1ZFUlNJT049My4xMC44
 DART_OBFUSCATION=false
-TRACK_WIDGET_CREATION=true
-TREE_SHAKE_ICONS=false
+TRACK_WIDGET_CREATION=false
+TREE_SHAKE_ICONS=true
 PACKAGE_CONFIG=/Users/schnobbc/Documents/Github/MeshMapper_Flutter_App/.dart_tool/package_config.json

ios/Flutter/flutter_export_environment.sh

@@ -3,12 +3,12 @@
 export "FLUTTER_ROOT=/opt/homebrew/share/flutter"
 export "FLUTTER_APPLICATION_PATH=/Users/schnobbc/Documents/Github/MeshMapper_Flutter_App"
 export "COCOAPODS_PARALLEL_CODE_SIGN=true"
-export "FLUTTER_TARGET=/Users/schnobbc/Documents/Github/MeshMapper_Flutter_App/lib/main.dart"
+export "FLUTTER_TARGET=lib/main.dart"
 export "FLUTTER_BUILD_DIR=build"
 export "FLUTTER_BUILD_NAME=1.0.0"
-export "FLUTTER_BUILD_NUMBER=1"
-export "DART_DEFINES=RkxVVFRFUl9WRVJTSU9OPTMuMzguOQ==,RkxVVFRFUl9DSEFOTkVMPXN0YWJsZQ==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049NjczMjNkZTI4NQ==,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049NTg3YzE4Zjg3Mw==,RkxVVFRFUl9EQVJUX1ZFUlNJT049My4xMC44"
+export "FLUTTER_BUILD_NUMBER=1769917500"
+export "DART_DEFINES=QVBQX1ZFUlNJT049QVBQLTE3Njk5MTc1MDA=,RkxVVFRFUl9WRVJTSU9OPTMuMzguOQ==,RkxVVFRFUl9DSEFOTkVMPXN0YWJsZQ==,RkxVVFRFUl9HSVRfVVJMPWh0dHBzOi8vZ2l0aHViLmNvbS9mbHV0dGVyL2ZsdXR0ZXIuZ2l0,RkxVVFRFUl9GUkFNRVdPUktfUkVWSVNJT049NjczMjNkZTI4NQ==,RkxVVFRFUl9FTkdJTkVfUkVWSVNJT049NTg3YzE4Zjg3Mw==,RkxVVFRFUl9EQVJUX1ZFUlNJT049My4xMC44"
 export "DART_OBFUSCATION=false"
-export "TRACK_WIDGET_CREATION=true"
-export "TREE_SHAKE_ICONS=false"
+export "TRACK_WIDGET_CREATION=false"
+export "TREE_SHAKE_ICONS=true"
 export "PACKAGE_CONFIG=/Users/schnobbc/Documents/Github/MeshMapper_Flutter_App/.dart_tool/package_config.json"

ios/Podfile.lock

@@ -1,6 +1,8 @@
 PODS:
   - audio_session (0.0.1):
     - Flutter
+  - connectivity_plus (0.0.1):
+    - Flutter
   - DKImagePickerController/Core (4.3.9):
     - DKImagePickerController/ImageDataManager
     - DKImagePickerController/Resource
@@ -69,6 +71,7 @@ PODS:
 
 DEPENDENCIES:
   - audio_session (from `.symlinks/plugins/audio_session/ios`)
+  - connectivity_plus (from `.symlinks/plugins/connectivity_plus/ios`)
   - file_picker (from `.symlinks/plugins/file_picker/ios`)
   - Flutter (from `Flutter`)
   - flutter_background_service_ios (from `.symlinks/plugins/flutter_background_service_ios/ios`)
@@ -93,6 +96,8 @@ SPEC REPOS:
 EXTERNAL SOURCES:
   audio_session:
     :path: ".symlinks/plugins/audio_session/ios"
+  connectivity_plus:
+    :path: ".symlinks/plugins/connectivity_plus/ios"
   file_picker:
     :path: ".symlinks/plugins/file_picker/ios"
   Flutter:
@@ -122,6 +127,7 @@ EXTERNAL SOURCES:
 
 SPEC CHECKSUMS:
   audio_session: 9bb7f6c970f21241b19f5a3658097ae459681ba0
+  connectivity_plus: cb623214f4e1f6ef8fe7403d580fdad517d2f7dd
   DKImagePickerController: 946cec48c7873164274ecc4624d19e3da4c1ef3c
   DKPhotoGallery: b3834fecb755ee09a593d7c9e389d8b5d6deed60
   file_picker: a0560bc09d61de87f12d246fc47d2119e6ef37be

lib/providers/app_state_provider.dart

@@ -1108,6 +1108,14 @@ class AppStateProvider extends ChangeNotifier {
     // Create TX tracker (stored for use by PingService)
     _txTracker = TxTracker();
 
+    // Log TX carpeater drops to error log (without navigating to error tab)
+    _txTracker!.onCarpeaterDrop = (String repeaterId, String reason) {
+      debugLog('[APP] TX carpeater drop: repeater=$repeaterId, reason=$reason');
+      logError('TX Echo Dropped\nPossible carpeater: $repeaterId\n$reason',
+          severity: ErrorSeverity.warning, autoSwitch: false);
+    };
+    debugLog('[APP] TxTracker.onCarpeaterDrop callback SET');
+
     // Create RX logger (stored for use when enabling Passive Mode)
     _rxLogger = RxLogger(
       // Function to check if repeater should be ignored (carpeater filter)
@@ -1269,6 +1277,13 @@ class AppStateProvider extends ChangeNotifier {
         if (pos == null) return null;
         return (lat: pos.latitude, lon: pos.longitude);
       },
+
+      // Log carpeater drops to error log (without navigating to error tab)
+      onCarpeaterDrop: (String repeaterId, String reason) {
+        debugLog('[APP] Carpeater drop: repeater=$repeaterId, reason=$reason');
+        logError('RX Dropped\nPossible carpeater: $repeaterId\n$reason',
+            severity: ErrorSeverity.warning, autoSwitch: false);
+      },
     );
 
     // Create packet validator with ALL allowed channels (#wardriving, #testing, #ottawa, Public)
@@ -1628,13 +1643,16 @@ class AppStateProvider extends ChangeNotifier {
   }
 
   /// Log a user-facing error message
-  void logError(String message, {ErrorSeverity severity = ErrorSeverity.error}) {
+  /// Set [autoSwitch] to false to log without navigating to error log tab
+  void logError(String message, {ErrorSeverity severity = ErrorSeverity.error, bool autoSwitch = true}) {
     _errorLogEntries.add(UserErrorEntry(
       timestamp: DateTime.now(),
       message: message,
       severity: severity,
     ));
-    _requestErrorLogSwitch = true; // Auto-switch to error log
+    if (autoSwitch) {
+      _requestErrorLogSwitch = true; // Auto-switch to error log
+    }
     notifyListeners();
   }
 

lib/services/meshcore/rx_logger.dart

@@ -30,11 +30,16 @@ class RxLogger {
   /// Returns true if the repeater should be filtered out
   final bool Function(String repeaterId)? shouldIgnoreRepeater;
 
+  /// Callback for carpeater drops (for quiet error logging)
+  /// Called with repeater ID and reason when a packet is dropped due to carpeater detection
+  final void Function(String repeaterId, String reason)? onCarpeaterDrop;
+
   RxLogger({
     required this.onRxEntry,
     this.onObservation,
     required this.getGpsLocation,
     this.shouldIgnoreRepeater,
+    this.onCarpeaterDrop,
   });
 
   /// Start passive RX wardriving
@@ -67,14 +72,20 @@ class RxLogger {
         debugLog('[RX LOG] Ignoring: no path (direct transmission, not via repeater)');
         return false;
       }
-      
+
+      // Extract LAST hop from path (the repeater that directly delivered to us)
+      // Do this early so we have repeater ID for carpeater logging
+      // Mask to last byte only (0xFF) for consistent 2-character display
+      final lastHopId = metadata.lastHop! & 0xFF;
+      final repeaterId = lastHopId.toRadixString(16).padLeft(2, '0').toUpperCase();
+
       // Get current GPS location
       final gpsLocation = getGpsLocation();
       if (gpsLocation == null) {
         debugLog('[RX LOG] No GPS fix available, skipping entry');
         return false;
       }
-      
+
       // PACKET FILTER: Validate packet before logging
       final validation = await validator.validate(metadata);
       if (!validation.valid) {
@@ -83,12 +94,13 @@ class RxLogger {
             .join(' ');
         debugLog('[RX LOG] ❌ Packet dropped: ${validation.reason}');
         debugLog('[RX LOG] Dropped packet hex: $rawHex');
+
+        // Log carpeater drops to error log (without auto-switching)
+        if (validation.reason == 'carpeater-rssi') {
+          onCarpeaterDrop?.call(repeaterId, 'RSSI too strong (${metadata.rssi} dBm)');
+        }
         return false;
       }
-      
-      // Extract LAST hop from path (the repeater that directly delivered to us)
-      final lastHopId = metadata.lastHop!;
-      final repeaterId = lastHopId.toRadixString(16).padLeft(2, '0').toUpperCase();
 
       debugLog('[RX LOG] Packet heard via last hop: $repeaterId, '
           'SNR=${metadata.snr}, path_length=${metadata.pathLength}');

lib/services/meshcore/tx_tracker.dart

@@ -26,6 +26,10 @@ class TxTracker {
   /// Parameters: (repeaterId, snr, rssi, isNew) - isNew is true for first time seeing this repeater
   void Function(String repeaterId, double snr, int rssi, bool isNew)? onEchoReceived;
 
+  /// Callback for carpeater drops (for quiet error logging)
+  /// Called with repeater ID and reason when an echo is dropped due to carpeater detection
+  void Function(String repeaterId, String reason)? onCarpeaterDrop;
+
   /// Start tracking echoes for a sent ping
   /// 
   /// @param payload - The message text sent (for content verification)
@@ -94,10 +98,23 @@ class TxTracker {
       }
       debugLog('[TX LOG] Header validation passed: 0x${metadata.header.toRadixString(16).padLeft(2, '0')}');
 
-      // VALIDATION STEP 1.5: Check RSSI (carpeater failsafe)
+      // VALIDATION STEP 1.5: Path length check (must have hops to identify repeater)
+      // Moved before RSSI check so we can log the repeater ID on carpeater drops
+      if (metadata.pathLength == 0) {
+        debugLog('[TX LOG] Ignoring: no path (direct transmission, not a repeater echo)');
+        return false;
+      }
+
+      // Extract first hop (first repeater) for use in validation and logging
+      final firstHopId = metadata.firstHop!;
+      final pathHex = firstHopId.toRadixString(16).padLeft(2, '0');
+
+      // VALIDATION STEP 2: Check RSSI (carpeater failsafe)
       if (PacketValidator.isCarpeater(metadata.rssi)) {
         debugLog('[TX LOG] ❌ DROPPED: RSSI too strong (${metadata.rssi} ≥ ${PacketValidator.maxRssiThreshold}) '
-            '- possible carpeater (RSSI failsafe)');
+            '- possible carpeater (RSSI failsafe), repeater=$pathHex');
+        debugLog('[TX LOG] onCarpeaterDrop callback is ${onCarpeaterDrop != null ? "SET" : "NULL"}');
+        onCarpeaterDrop?.call(pathHex, 'RSSI too strong (${metadata.rssi} dBm)');
         return false; // Mark as handled (dropped)
       }
       debugLog('[TX LOG] ✓ RSSI OK (${metadata.rssi} < ${PacketValidator.maxRssiThreshold})');
@@ -174,15 +191,7 @@ class TxTracker {
         debugWarn('[MESSAGE_CORRELATION] Proceeding without message content verification (less reliable)');
       }
 
-      // VALIDATION STEP 4: Path length check (must have hops)
-      if (metadata.pathLength == 0) {
-        debugLog('[TX LOG] Ignoring: no path (direct transmission, not a repeater echo)');
-        return false;
-      }
-
-      // Extract first hop (first repeater)
-      final firstHopId = metadata.firstHop!;
-      final pathHex = firstHopId.toRadixString(16).padLeft(2, '0');
+      // Path length and first hop already validated/extracted earlier (before RSSI check)
 
       debugLog('[PING] Repeater echo accepted: first_hop=$pathHex, SNR=${metadata.snr}, '
           'full_path_length=${metadata.pathLength}');