Cleanup of trajectory class #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data structures and results data structures
alperyeg
reviewed
Sep 19, 2020
Member
alperyeg
left a comment
alperyeg
left a comment
There was a problem hiding this comment.
An important cleanup step. Makes the trajectory easier to handle with.
| # (index of individual within one generation) | ||
| traj.v_idx = run_index | ||
| ind_index = traj.par.ind_idx | ||
| ind_index = traj.parameters.ind_idx |
Member
There was a problem hiding this comment.
Not sure if it is too much to do but maybe having an individual_indexinstead ind_idx is much clearer.
| self._parameters.parameter_group = {} | ||
| self._parameters.parameter = {} | ||
| self.individual = Individual() | ||
| self.individuals = {} |
Member
There was a problem hiding this comment.
I think we should make individuals optional. Or more clearer keeping the history of all individuals should be optional. For example later on the specific individual will be added into the individuals dictionary per generation which can make a big overhead if the individual is big.
Member
|
@sdiazpier how is the status of the cleanup? There are additionally conflicts now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #2 Removed unnecessary functions, parameter data structures and results data structures