Skip to content

Commit 1442b21

Browse files
committed
ci: remove prepare job and consolidate changelog validation into a single job
1 parent 54741b9 commit 1442b21

1 file changed

Lines changed: 1 addition & 30 deletions

File tree

.github/workflows/build-lint-test.yml

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,9 @@ on:
44
workflow_call:
55

66
jobs:
7-
prepare:
8-
name: Prepare
9-
runs-on: ubuntu-latest
10-
strategy:
11-
matrix:
12-
node-version: [18.x, 20.x, 22.x]
13-
outputs:
14-
child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
15-
steps:
16-
- name: Checkout and setup environment
17-
uses: MetaMask/action-checkout-and-setup@v1
18-
with:
19-
is-high-risk-environment: true
20-
cache-node-modules: ${{ matrix.node-version == '22.x' }}
21-
- name: Fetch workspace package names
22-
id: workspace-package-names
23-
run: |
24-
echo "child-workspace-package-names=$(yarn workspaces list --no-private --json | jq --slurp --raw-output 'map(.name) | @json')" >> "$GITHUB_OUTPUT"
25-
shell: bash
26-
277
lint:
288
name: Lint (${{ matrix.script }})
299
runs-on: ubuntu-latest
30-
needs: prepare
3110
strategy:
3211
matrix:
3312
node-version: [22.x]
@@ -54,17 +33,12 @@ jobs:
5433
validate-changelog:
5534
name: Validate changelog
5635
runs-on: ubuntu-latest
57-
needs: prepare
58-
strategy:
59-
matrix:
60-
node-version: [22.x]
61-
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
6236
steps:
6337
- name: Checkout and setup environment
6438
uses: MetaMask/action-checkout-and-setup@v1
6539
with:
6640
is-high-risk-environment: true
67-
- run: yarn workspace ${{ matrix.package-name }} changelog:validate
41+
- run: yarn workspaces foreach --all --no-private --parallel run changelog:validate
6842
- name: Require clean working directory
6943
shell: bash
7044
run: |
@@ -76,7 +50,6 @@ jobs:
7650
build:
7751
name: Build
7852
runs-on: ubuntu-latest
79-
needs: prepare
8053
strategy:
8154
matrix:
8255
node-version: [22.x]
@@ -97,8 +70,6 @@ jobs:
9770
test:
9871
name: Test
9972
runs-on: ubuntu-latest
100-
needs:
101-
- prepare
10273
strategy:
10374
matrix:
10475
node-version: [18.x, 20.x, 22.x]

0 commit comments

Comments
 (0)