chore: add name and state properties to SnapKeyring to support modular initialisation (#379)

This adds a `name` and `state` property to `SnapKeyring`. The name is
set to the TypeScript literal "SnapKeyring" and the state is always
`null`. These properties are required for modular initialisation in the
clients. Blocking MetaMask/metamask-extension#35987.

---------

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

Author: Mrtenz

packages/keyring-snap-bridge/CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add `name` and `state` properties to `SnapKeyring` to allow modular initialisation in the clients ([#379](https://github.com/MetaMask/accounts/pull/379))
+
+### Changed
+
+- `SnapKeyring` no longer extend `EventEmitter` ([#379](https://github.com/MetaMask/accounts/pull/379))
+
 ## [17.1.0]
 
 ### Changed

packages/keyring-snap-bridge/src/SnapKeyring.ts

@@ -51,7 +51,6 @@ import {
   KnownCaipNamespace,
   toCaipChainId,
 } from '@metamask/utils';
-import { EventEmitter } from 'events';
 import { v4 as uuid } from 'uuid';
 
 import { transformAccount } from './account';
@@ -74,6 +73,7 @@ import type {
   SnapKeyringEvents,
   SnapKeyringMessenger,
 } from './SnapKeyringMessenger';
+import { SNAP_KEYRING_NAME } from './SnapKeyringMessenger';
 import type { SnapMessage } from './types';
 import { SnapMessageStruct } from './types';
 import {
@@ -154,11 +154,16 @@ function normalizeAccountAddress(account: KeyringAccount): string {
 /**
  * Keyring bridge implementation to support Snaps.
  */
-export class SnapKeyring extends EventEmitter {
+export class SnapKeyring {
   static type: string = SNAP_KEYRING_TYPE;
 
   type: string;
 
+  // Name and state are required for modular initialisation.
+  name: typeof SNAP_KEYRING_NAME = SNAP_KEYRING_NAME;
+
+  state = null;
+
   /**
    * Messenger to dispatch requests to the Snaps controller.
    */
@@ -225,7 +230,6 @@ export class SnapKeyring extends EventEmitter {
     callbacks: SnapKeyringCallbacks;
     isAnyAccountTypeAllowed?: boolean;
   }) {
-    super();
     this.type = SnapKeyring.type;
     this.#messenger = messenger;
     this.#snapClient = new KeyringInternalSnapClient({ messenger });

packages/keyring-snap-bridge/src/SnapKeyringMessenger.ts

@@ -40,8 +40,10 @@ export type SnapKeyringAllowedActions =
   | SnapControllerGetSnap
   | SnapControllerIsMinimumPlatformVersion;
 
+export const SNAP_KEYRING_NAME = 'SnapKeyring';
+
 export type SnapKeyringMessenger = RestrictedMessenger<
-  'SnapKeyring',
+  typeof SNAP_KEYRING_NAME,
   SnapKeyringAllowedActions,
   SnapKeyringEvents,
   SnapKeyringAllowedActions['type'],