feat: refine EthAddressStruct in order to make it compatible with the Hex type from @metamask/utils (#405)

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?

Are there any issues or other links reviewers should consult to
understand this pull request better? For instance:

* Fixes #12345
* See: #67890
-->

## Examples

<!--
Are there any examples of this change being used in another repository?

When considering changes to the MetaMask module template, it's strongly
preferred that the change be experimented with in another repository
first. This gives reviewers a better sense of how the change works,
making it less likely the change will need to be reverted or adjusted
later.
-->

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Type `EthAddressStruct` as `Hex` and update tests and changelog
accordingly.
> 
> - **Keyring API**:
> - **Types**: Update `EthAddressStruct` to `definePattern<Hex>` and
import `Hex` in `src/eth/types.ts`.
> - **Changelog**: Note the `EthAddressStruct` refinement for `Hex`
compatibility.
> - **Snap Bridge Tests**:
> - Import `Hex` and cast Ethereum addresses/`to` fields to `Hex` in
`SnapKeyring.test.ts` to align with new typing.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
11df2a0. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: mathieuartu

packages/keyring-api/CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Add `KeyringWrapper` base class to adapt legacy keyrings to `KeyringV2` ([#398](https://github.com/MetaMask/accounts/pull/398))
 
+### Changed
+
+- Refine `EthAddressStruct` in order to make it compatible with the `Hex` type from `@metamask/utils` ([#405](https://github.com/MetaMask/accounts/pull/405))
+
 ## [21.3.0]
 
 ### Added

packages/keyring-api/src/eth/types.ts

@@ -1,7 +1,7 @@
 import { object } from '@metamask/keyring-utils';
 import type { Infer } from '@metamask/superstruct';
 import { nonempty, array, enums, literal } from '@metamask/superstruct';
-import { definePattern } from '@metamask/utils';
+import { definePattern, type Hex } from '@metamask/utils';
 
 import { EthScope } from '.';
 import {
@@ -12,7 +12,7 @@ import {
 
 export const EthBytesStruct = definePattern('EthBytes', /^0x[0-9a-f]*$/iu);
 
-export const EthAddressStruct = definePattern(
+export const EthAddressStruct = definePattern<Hex>(
   'EthAddress',
   /^0x[0-9a-f]{40}$/iu,
 );

packages/keyring-snap-bridge/src/SnapKeyring.test.ts

@@ -42,7 +42,7 @@ import type { HandleSnapRequest } from '@metamask/snaps-controllers';
 import { type SnapId } from '@metamask/snaps-sdk';
 import type { HandlerType } from '@metamask/snaps-utils';
 import { assert } from '@metamask/superstruct';
-import type { Json } from '@metamask/utils';
+import type { Hex, Json } from '@metamask/utils';
 import { KnownCaipNamespace, toCaipChainId } from '@metamask/utils';
 import { v4 as uuid } from 'uuid';
 
@@ -154,7 +154,7 @@ describe('SnapKeyring', () => {
   };
   const ethErc4337Account = {
     id: 'fc926fff-f515-4eb5-9952-720bbd9b9849',
-    address: '0x2f15b30952aebe0ed5fdbfe5bf16fb9ecdb31d9a'.toLowerCase(),
+    address: '0x2f15b30952aebe0ed5fdbfe5bf16fb9ecdb31d9a'.toLowerCase() as Hex,
     options: {},
     methods: ETH_4337_METHODS,
     scopes: [EthScope.Testnet],
@@ -1976,12 +1976,12 @@ describe('SnapKeyring', () => {
     it('calls eth_prepareUserOperation', async () => {
       const baseTxs = [
         {
-          to: '0x0c54fccd2e384b4bb6f2e405bf5cbc15a017aafb',
+          to: '0x0c54fccd2e384b4bb6f2e405bf5cbc15a017aafb' as Hex,
           value: '0x0',
           data: '0x',
         },
         {
-          to: '0x660265edc169bab511a40c0e049cc1e33774443d',
+          to: '0x660265edc169bab511a40c0e049cc1e33774443d' as Hex,
           value: '0x0',
           data: '0x619a309f',
         },
@@ -2751,7 +2751,7 @@ describe('SnapKeyring', () => {
   describe('prepareUserOperation', () => {
     const mockIntents = [
       {
-        to: '0x0c54fccd2e384b4bb6f2e405bf5cbc15a017aafb',
+        to: '0x0c54fccd2e384b4bb6f2e405bf5cbc15a017aafb' as Hex,
         value: '0x0',
         data: '0x',
       },