fix: disable some eslint rule globally

Author: ccharly

.eslintrc.js

@@ -58,6 +58,10 @@ module.exports = {
       rules: {
         // Enable rules that are disabled in `@metamask/eslint-config-typescript`
         '@typescript-eslint/no-explicit-any': 'error',
+
+        // This rule triggers false positives and doesn't add real type-safety value.
+        // See: https://typescript-eslint.io/rules/no-redundant-type-constituents/#when-not-to-use-it
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
       },
     },
     {
@@ -97,6 +101,10 @@ module.exports = {
         // works on the original repository, so there might be some side-effects now that
         // we are building in a monorepo)
         '@typescript-eslint/restrict-template-expressions': 'off',
+
+        // This rule triggers false positives and doesn't add real type-safety value.
+        // See: https://typescript-eslint.io/rules/no-redundant-type-constituents/#when-not-to-use-it
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
       },
     },
     // @metamask/keyring-eth-hd
@@ -175,6 +183,10 @@ module.exports = {
         'jsdoc/tag-lines': 'off',
         'n/no-callback-literal': 'off',
         'promise/no-multiple-resolved': 'off',
+
+        // This rule triggers false positives and doesn't add real type-safety value.
+        // See: https://typescript-eslint.io/rules/no-redundant-type-constituents/#when-not-to-use-it
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
       },
     },
     // @metamask/keyring-snap-bridge
@@ -189,6 +201,10 @@ module.exports = {
         // works on the original repository, so there might be some side-effects now that
         // we are building in a monorepo)
         '@typescript-eslint/restrict-template-expressions': 'off',
+
+        // This rule triggers false positives and doesn't add real type-safety value.
+        // See: https://typescript-eslint.io/rules/no-redundant-type-constituents/#when-not-to-use-it
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
       },
     },
     // @metamask/keyring-snap-sdk
@@ -215,6 +231,10 @@ module.exports = {
         // works on the original repository, so there might be some side-effects now that
         // we are building in a monorepo)
         '@typescript-eslint/restrict-template-expressions': 'off',
+
+        // This rule triggers false positives and doesn't add real type-safety value.
+        // See: https://typescript-eslint.io/rules/no-redundant-type-constituents/#when-not-to-use-it
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
       },
     },
   ],

packages/keyring-eth-trezor/src/trezor-keyring-v2.ts

@@ -89,8 +89,6 @@ const DERIVATION_PATH_PATTERN = /^(m\/44'\/(?:60'|1')(?:\/\d+'?)*)\/(\d+)$/u;
 export type TrezorKeyringV2Options = {
   legacyKeyring: TrezorKeyring;
   entropySource: EntropySourceId;
-  // FIXME: eslint is complaning about `Trezor` and `OneKey` being `any`, so disable this for now:
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   type?: KeyringType.Trezor | KeyringType.OneKey;
 };
 

packages/keyring-internal-api/src/types.ts

@@ -1,6 +1,6 @@
-// FIXME: eslint is complaning about some unions here, so disable this for now:
+// FIXME: eslint is complaning about our account union even if those accounts
+// types should all be different, so we disable this for now:
 /* eslint-disable @typescript-eslint/no-duplicate-type-constituents */
-/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
 
 import {
   BtcAccountType,

packages/keyring-snap-bridge/src/SnapKeyring.ts

@@ -914,8 +914,6 @@ export class SnapKeyring {
     snapId: SnapId,
     scope: CaipChainId,
     request: JsonRpcRequest,
-    // FIXME: eslint is complaning about `ResolvedAccountAddress` being `any`, so disable this for now:
-    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   ): Promise<ResolvedAccountAddress | null> {
     // We do check that the incoming Snap ID is known by the keyring.
     if (!this.hasSnapId(snapId)) {

packages/keyring-snap-bridge/src/account.ts

@@ -91,8 +91,6 @@ export function assertKeyringAccount<
  * @returns A valid transformed `KeyringAccount`.
  */
 export function transformAccount(
-  // FIXME: eslint is complaning about `Infer` (from `KeyringAccount`) being `any`, so disable this for now:
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   accountToTransform: KeyringAccountV1 | KeyringAccount,
 ): KeyringAccount {
   // To keep the retro-compatibility with older keyring-api versions, we identify the account's

packages/keyring-snap-bridge/src/migrations/v1.ts

@@ -25,8 +25,6 @@ import {
  * @returns True if the account is v1, false otherwise.
  */
 export function isAccountV1(
-  // FIXME: eslint is complaning about `Infer` (used for `KeyringAccount`) being `any`, so disable this for now:
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   account: KeyringAccountV1 | KeyringAccount,
 ): boolean {
   return is(account, KeyringAccountV1Struct);

packages/keyring-snap-client/src/KeyringClient.ts

@@ -157,8 +157,6 @@ export class KeyringClient implements Keyring {
   async resolveAccountAddress(
     scope: CaipChainId,
     request: JsonRpcRequest,
-    // FIXME: eslint is complaning about `ResolvedAccountAddress` being `any`, so disable this for now:
-    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   ): Promise<ResolvedAccountAddress | null> {
     return strictMask(
       await this.send({