fix: dmk naming

Author: montelaidev

packages/hw-wallet-sdk/src/dmk-error-mappings.test.ts

@@ -2,7 +2,7 @@ import {
   DMK_ERROR_MAPPINGS,
   DMK_ERROR_TAG_MAPPINGS,
   DMK_MESSAGE_PATTERNS,
-  getDMKErrorFromTag,
+  getDmkErrorFromTag,
 } from './dmk-error-mappings';
 import type { ErrorMapping } from './hardware-error-mappings';
 import { Category, ErrorCode, Severity } from './hardware-errors-enums';
@@ -164,13 +164,13 @@ describe('DMK_MESSAGE_PATTERNS', () => {
   });
 });
 
-describe('getDMKErrorFromTag', () => {
+describe('getDmkErrorFromTag', () => {
   it('returns DeviceDisconnected for DeviceSessionNotFound tag', () => {
     const error = {
       _tag: 'DeviceSessionNotFound',
       message: 'Session not found',
     };
-    expect(getDMKErrorFromTag(error)).toStrictEqual({
+    expect(getDmkErrorFromTag(error)).toStrictEqual({
       code: ErrorCode.DeviceDisconnected,
       tag: 'DeviceSessionNotFound',
     });
@@ -181,7 +181,7 @@ describe('getDMKErrorFromTag', () => {
       _tag: 'ConnectionOpeningError',
       message: 'Failed to open connection',
     };
-    expect(getDMKErrorFromTag(error)).toStrictEqual({
+    expect(getDmkErrorFromTag(error)).toStrictEqual({
       code: ErrorCode.BluetoothConnectionFailed,
       tag: 'ConnectionOpeningError',
     });
@@ -192,7 +192,7 @@ describe('getDMKErrorFromTag', () => {
       _tag: 'DeviceDisconnectedWhileSendingError',
       message: 'Disconnected',
     };
-    expect(getDMKErrorFromTag(error)).toStrictEqual({
+    expect(getDmkErrorFromTag(error)).toStrictEqual({
       code: ErrorCode.DeviceDisconnected,
       tag: 'DeviceDisconnectedWhileSendingError',
     });
@@ -203,7 +203,7 @@ describe('getDMKErrorFromTag', () => {
       _tag: 'DeviceLockedError',
       message: 'Device is locked',
     };
-    expect(getDMKErrorFromTag(error)).toStrictEqual({
+    expect(getDmkErrorFromTag(error)).toStrictEqual({
       code: ErrorCode.AuthenticationDeviceLocked,
       tag: 'DeviceLockedError',
     });
@@ -214,43 +214,43 @@ describe('getDMKErrorFromTag', () => {
       _tag: 'SessionRefresherError',
       message: 'Session refresh failed',
     };
-    expect(getDMKErrorFromTag(error)).toStrictEqual({
+    expect(getDmkErrorFromTag(error)).toStrictEqual({
       code: ErrorCode.DeviceDisconnected,
       tag: 'SessionRefresherError',
     });
   });
 
   it('returns null when _tag is not a recognised DMK tag', () => {
     const error = { _tag: 'SomeUnknownTag', message: 'Unknown' };
-    expect(getDMKErrorFromTag(error)).toBeNull();
+    expect(getDmkErrorFromTag(error)).toBeNull();
   });
 
   it('returns null when _tag is missing', () => {
     const error = { message: 'No tag here' };
-    expect(getDMKErrorFromTag(error)).toBeNull();
+    expect(getDmkErrorFromTag(error)).toBeNull();
   });
 
   it('returns null when _tag is not a string', () => {
     const error = { _tag: 42, message: 'Numeric tag' };
-    expect(getDMKErrorFromTag(error)).toBeNull();
+    expect(getDmkErrorFromTag(error)).toBeNull();
   });
 
   it('returns null for null input', () => {
-    expect(getDMKErrorFromTag(null)).toBeNull();
+    expect(getDmkErrorFromTag(null)).toBeNull();
   });
 
   it('returns null for undefined input', () => {
-    expect(getDMKErrorFromTag(undefined)).toBeNull();
+    expect(getDmkErrorFromTag(undefined)).toBeNull();
   });
 
   it('returns null for primitive input', () => {
-    expect(getDMKErrorFromTag('string error')).toBeNull();
-    expect(getDMKErrorFromTag(42)).toBeNull();
+    expect(getDmkErrorFromTag('string error')).toBeNull();
+    expect(getDmkErrorFromTag(42)).toBeNull();
   });
 
   it('returns null for empty string _tag', () => {
     const error = { _tag: '', message: 'Empty tag' };
-    expect(getDMKErrorFromTag(error)).toBeNull();
+    expect(getDmkErrorFromTag(error)).toBeNull();
   });
 
   it('handles errors with additional properties beyond _tag', () => {
@@ -260,7 +260,7 @@ describe('getDMKErrorFromTag', () => {
       name: 'SomeError',
       stack: 'trace...',
     };
-    expect(getDMKErrorFromTag(error)).toStrictEqual({
+    expect(getDmkErrorFromTag(error)).toStrictEqual({
       code: ErrorCode.AuthenticationDeviceLocked,
       tag: 'DeviceLockedError',
     });

packages/keyring-eth-ledger-bridge/src/dmk/ledger-dmk-bridge.test.ts

@@ -148,8 +148,12 @@ describe('LedgerDmkBridge', () => {
     bridge = new LedgerDmkBridge({ transportFactory: mockTransportFactory });
   });
 
-  afterEach(() => {
-    jest.clearAllMocks();
+  afterEach(async () => {
+    // Cancel any pending session-monitoring retry timers before mocks are
+    // reset. With `resetMocks: true`, an orphaned retry would call
+    // `getDeviceSessionState()` after it returns `undefined`, crashing on `.pipe`.
+    await bridge.destroy();
+    jest.useRealTimers();
   });
 
   describe('constructor', () => {

packages/keyring-eth-ledger-bridge/src/errors.test.ts

@@ -4,7 +4,7 @@ import {
 } from '@metamask/hw-wallet-sdk';
 
 import {
-  createDMKError,
+  createDmkError,
   createLedgerError,
   createKeyringStateError,
   isKnownLedgerError,
@@ -123,32 +123,32 @@ describe('createKeyringStateError', () => {
   });
 });
 
-describe('createDMKError', () => {
+describe('createDmkError', () => {
   describe('known DMK tags', () => {
     it('creates HardwareWalletError for DeviceSessionNotFound', () => {
-      const error = createDMKError('DeviceSessionNotFound');
+      const error = createDmkError('DeviceSessionNotFound');
 
       expect(error).toBeInstanceOf(HardwareWalletError);
       expect(error.code).toBe(ErrorCodeEnum.DeviceDisconnected);
       expect(error.message).toBe('DMK device session not found');
     });
 
     it('creates HardwareWalletError for DeviceLockedError', () => {
-      const error = createDMKError('DeviceLockedError');
+      const error = createDmkError('DeviceLockedError');
 
       expect(error).toBeInstanceOf(HardwareWalletError);
       expect(error.code).toBe(ErrorCodeEnum.AuthenticationDeviceLocked);
     });
 
     it('creates HardwareWalletError for ConnectionOpeningError', () => {
-      const error = createDMKError('ConnectionOpeningError');
+      const error = createDmkError('ConnectionOpeningError');
 
       expect(error).toBeInstanceOf(HardwareWalletError);
       expect(error.code).toBe(ErrorCodeEnum.BluetoothConnectionFailed);
     });
 
     it('includes context in message when provided', () => {
-      const error = createDMKError(
+      const error = createDmkError(
         'DeviceSessionNotFound',
         'during signTransaction',
       );
@@ -159,7 +159,7 @@ describe('createDMKError', () => {
     });
 
     it('uses the mapping userMessage', () => {
-      const error = createDMKError('DeviceLockedError');
+      const error = createDmkError('DeviceLockedError');
 
       expect(error.userMessage).toBe(
         'Please unlock your Ledger device to continue.',
@@ -169,15 +169,15 @@ describe('createDMKError', () => {
 
   describe('unknown DMK tags', () => {
     it('creates fallback error for unknown tag without context', () => {
-      const error = createDMKError('SomeUnknownTag');
+      const error = createDmkError('SomeUnknownTag');
 
       expect(error).toBeInstanceOf(HardwareWalletError);
       expect(error.code).toBe(ErrorCodeEnum.Unknown);
       expect(error.message).toBe('Unknown DMK error: SomeUnknownTag');
     });
 
     it('creates fallback error for unknown tag with context', () => {
-      const error = createDMKError('SomeUnknownTag', 'while connecting');
+      const error = createDmkError('SomeUnknownTag', 'while connecting');
 
       expect(error.message).toBe(
         'Unknown DMK error: SomeUnknownTag (while connecting)',