refactor: move mapping type

Author: montelaidev

packages/hw-wallet-sdk/src/hardware-error-mappings.ts

@@ -1,6 +1,14 @@
 import { ErrorCode, Severity, Category } from './hardware-errors-enums';
 
-export const LEDGER_ERROR_MAPPINGS = {
+export type ErrorMapping = {
+  code: ErrorCode;
+  message: string;
+  severity: Severity;
+  category: Category;
+  userMessage?: string;
+};
+
+export const LEDGER_ERROR_MAPPINGS: Record<string, ErrorMapping> = {
   '0x9000': {
     code: ErrorCode.Success,
     message: 'Operation successful',

packages/keyring-eth-ledger-bridge/src/errors.ts

@@ -1,22 +1,12 @@
 import {
-  type ErrorCode,
-  type Severity,
-  type Category,
+  ErrorMapping,
+  ErrorCode,
+  Severity,
+  Category,
   HardwareWalletError,
   LEDGER_ERROR_MAPPINGS,
-  ErrorCode as ErrorCodeEnum,
-  Severity as SeverityEnum,
-  Category as CategoryEnum,
 } from '@metamask/hw-wallet-sdk';
 
-type LedgerErrorMapping = {
-  code: ErrorCode;
-  message: string;
-  severity: Severity;
-  category: Category;
-  userMessage?: string;
-};
-
 /**
  * Factory function to create a HardwareWalletError from a Ledger error code.
  *
@@ -49,9 +39,9 @@ export function createLedgerError(
     : `Unknown Ledger error: ${ledgerErrorCode}`;
 
   return new HardwareWalletError(fallbackMessage, {
-    code: ErrorCodeEnum.Unknown,
-    severity: SeverityEnum.Err,
-    category: CategoryEnum.Unknown,
+    code: ErrorCode.Unknown,
+    severity: Severity.Err,
+    category: Category.Unknown,
     userMessage: fallbackMessage,
   });
 }
@@ -74,9 +64,6 @@ export function isKnownLedgerError(ledgerErrorCode: string): boolean {
  */
 export function getLedgerErrorMapping(
   ledgerErrorCode: string,
-): LedgerErrorMapping | undefined {
-  const mappings = LEDGER_ERROR_MAPPINGS as {
-    [key: string]: LedgerErrorMapping;
-  };
-  return mappings[ledgerErrorCode];
+): ErrorMapping | undefined {
+  return LEDGER_ERROR_MAPPINGS[ledgerErrorCode];
 }

packages/keyring-eth-ledger-bridge/src/index.ts

@@ -8,15 +8,3 @@ export type * from './type';
 export * from './ledger-hw-app';
 export * from './errors';
 export * from './ledger-error-handler';
-
-// Re-export HardwareWalletError and related types from hw-wallet-sdk for convenience
-export {
-  HardwareWalletError,
-  ErrorCode,
-  Severity,
-  Category,
-  LEDGER_ERROR_MAPPINGS,
-  BLE_ERROR_MAPPINGS,
-  MOBILE_ERROR_MAPPINGS,
-} from '@metamask/hw-wallet-sdk';
-export type { HardwareWalletErrorOptions } from '@metamask/hw-wallet-sdk';