Skip to content

Commit a18c779

Browse files
committed
chore: fix lint
1 parent deea5da commit a18c779

5 files changed

Lines changed: 35 additions & 116 deletions

File tree

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ This repository contains the following packages [^fn1]:
1515
- [`@metamask/account-api`](packages/account-api)
1616
- [`@metamask/eth-hd-keyring`](packages/keyring-eth-hd)
1717
- [`@metamask/eth-ledger-bridge-keyring`](packages/keyring-eth-ledger-bridge)
18+
- [`@metamask/eth-onekey-keyring`](packages/keyring-eth-onekey)
1819
- [`@metamask/eth-qr-keyring`](packages/keyring-eth-qr)
1920
- [`@metamask/eth-simple-keyring`](packages/keyring-eth-simple)
2021
- [`@metamask/eth-snap-keyring`](packages/keyring-snap-bridge)
@@ -40,6 +41,7 @@ linkStyle default opacity:0.5
4041
keyring_api(["@metamask/keyring-api"]);
4142
eth_hd_keyring(["@metamask/eth-hd-keyring"]);
4243
eth_ledger_bridge_keyring(["@metamask/eth-ledger-bridge-keyring"]);
44+
eth_onekey_keyring(["@metamask/eth-onekey-keyring"]);
4345
eth_qr_keyring(["@metamask/eth-qr-keyring"]);
4446
eth_simple_keyring(["@metamask/eth-simple-keyring"]);
4547
eth_trezor_keyring(["@metamask/eth-trezor-keyring"]);

packages/keyring-eth-onekey/jest.config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ module.exports = merge(baseConfig, {
2323
// An object that configures minimum threshold enforcement for coverage results
2424
coverageThreshold: {
2525
global: {
26-
branches: 74.2,
26+
branches: 74.31,
2727
functions: 91.25,
28-
lines: 92.78,
29-
statements: 92.83,
28+
lines: 92.83,
29+
statements: 92.88,
3030
},
3131
},
3232
});

packages/keyring-eth-onekey/src/onekey-keyring.test.ts

Lines changed: 19 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -20,25 +20,25 @@ import { OneKeyWebBridge } from './onekey-web-bridge';
2020

2121
const CONNECT_SRC = 'https://jssdk.onekey.so/1.1.5/';
2222
const fakeAccounts = [
23-
'0xF30952A1c534CDE7bC471380065726fa8686dfB3',
24-
'0x44fe3Cf56CaF651C4bD34Ae6dbcffa34e9e3b84B',
25-
'0x8Ee3374Fa705C1F939715871faf91d4348D5b906',
26-
'0xEF69e24dE9CdEe93C4736FE29791E45d5D4CFd6A',
27-
'0xC668a5116A045e9162902795021907Cb15aa2620',
28-
'0xbF519F7a6D8E72266825D770C60dbac55a3baeb9',
29-
'0x0258632Fe2F91011e06375eB0E6f8673C0463204',
30-
'0x4fC1700C0C61980aef0Fb9bDBA67D8a25B5d4335',
31-
'0xeEC5D417152aE295c047FB0B0eBd7c7090dDedEb',
32-
'0xd3f978B9eEEdB68A38CF252B3779afbeb3623fDf',
33-
'0xd819fE2beD53f44825F66873a159B687736d3092',
34-
'0xE761dA62f053ad9eE221d325657535991Ab659bD',
35-
'0xd4F1686961642340a80334b5171d85Bbd390c691',
36-
'0x6772C4B1E841b295960Bb4662dceD9bb71726357',
37-
'0x41bEAD6585eCA6c79B553Ca136f0DFA78A006899',
23+
'0x73d0385F4d8E00C5e6504C6030F47BF6212736A8',
24+
'0xFA01a39f8Abaeb660c3137f14A310d0b414b2A15',
25+
'0x574BbB36871bA6b78E27f4B4dCFb76eA0091880B',
26+
'0xba98D6a5ac827632E3457De7512d211e4ff7e8bD',
27+
'0x1f815D67006163E502b8eD4947C91ad0A62De24e',
28+
'0xf69619a3dCAA63757A6BA0AF3628f5F6C42c50d2',
29+
'0xA8664Df3D5E74BE57c19fC7005BBcd0F5328041e',
30+
'0xf2252f414e727d652d5a488fE4BFf7e64478737F',
31+
'0x5708Ae081b48ad7bA8c50ca3D4fa0238d544D6FA',
32+
'0x12eF7dfb86f6D5E3e0521b72472ca02D2a3814F4',
33+
'0x9115Fa64b8B9864D6545Fc00d62B6A9Cbb876be7',
34+
'0x8B6cF2eA1A54E054EFC35E4244Ac507c479bb5F6',
35+
'0x6C480ba4409dd5FF29Cbd3ED67152B791750a708',
36+
'0x5f2E5ddEd3DBD431deCc406Ae999F277B625Ba25',
37+
'0x8a143C4CCed2ce826DE598Dbbf7C706cD6DB0Ccd',
3838
] as const;
3939

4040
const fakeXPubKey =
41-
'xpub6FnCn6nSzZAw5Tw7cgR9bi15UV96gLZhjDstkXXxvCLsUXBGXPdSnLFbdpq8p9HmGsApME5hQTZ3emM2rnY5agb9rXpVGyy3bdW6EEgAtqt';
41+
'xpub6CNFa58kEQJu2hwMVoofpDEKVVSg6gfwqBqE2zHAianaUnQkrJzJJ42iLDp7Dmg2aP88qCKoFZ4jidk3tECdQuF4567NGHDfe7iBRwHxgke';
4242
const fakeHdKey = HDKey.fromExtendedKey(fakeXPubKey);
4343
const fakeTx = new EthereumTx({
4444
nonce: '0x00',
@@ -1143,12 +1143,7 @@ describe('OneKeyKeyring', function () {
11431143
const unlockResult = 'unlocked';
11441144
const unlockSpy = sinon.stub(keyring, 'unlock').resolves(unlockResult);
11451145

1146-
// Mock bridge methods to avoid actual hardware calls (33-byte public key)
1147-
keyring.hdk.publicKey = Buffer.from(`02${'0'.repeat(64)}`, 'hex'); // 33 bytes
1148-
keyring.hdk.chainCode = Buffer.from(
1149-
'123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01',
1150-
'hex',
1151-
); // 32 bytes
1146+
keyring.hdk = fakeHdKey;
11521147

11531148
const accounts = await keyring.addAccounts(1);
11541149
expect(accounts).toHaveLength(1);
@@ -1164,11 +1159,7 @@ describe('OneKeyKeyring', function () {
11641159
const unlockResult = 'unlocked';
11651160
const unlockSpy = sinon.stub(keyring, 'unlock').resolves(unlockResult);
11661161

1167-
keyring.hdk.publicKey = Buffer.from(`02${'0'.repeat(64)}`, 'hex'); // 33 bytes
1168-
keyring.hdk.chainCode = Buffer.from(
1169-
'123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01',
1170-
'hex',
1171-
); // 32 bytes
1162+
keyring.hdk = fakeHdKey;
11721163

11731164
const accounts = await keyring.addAccounts(1);
11741165
expect(accounts).toHaveLength(1);
@@ -1191,11 +1182,7 @@ describe('OneKeyKeyring', function () {
11911182
keyring.hdPath = "m/44'/60'/x'/0/0"; // Ledger Live path (not in ALLOWED_HD_PATHS but we set directly)
11921183

11931184
const unlockSpy = sinon.stub(keyring, 'unlock').resolves('unlocked');
1194-
keyring.hdk.publicKey = Buffer.from(`02${'0'.repeat(64)}`, 'hex');
1195-
keyring.hdk.chainCode = Buffer.from(
1196-
'123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01',
1197-
'hex',
1198-
);
1185+
keyring.hdk = fakeHdKey;
11991186

12001187
// This should trigger the Ledger Live error paths during addAccounts
12011188
try {

packages/keyring-eth-onekey/src/onekey-keyring.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -640,6 +640,9 @@ export class OneKeyKeyring extends EventEmitter {
640640
if (this.#isLedgerLiveHdPath()) {
641641
throw new Error('Ledger Live is not supported');
642642
}
643+
if (this.#isStandardBip44HdPath()) {
644+
return `${pathBase}/0/${index}`;
645+
}
643646
return `${pathBase}/${index}`;
644647
}
645648

yarn.lock

Lines changed: 8 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -5282,14 +5282,7 @@ __metadata:
52825282
languageName: node
52835283
linkType: hard
52845284

5285-
"bignumber.js@npm:^9.0.0, bignumber.js@npm:^9.0.1, bignumber.js@npm:^9.1.2, bignumber.js@npm:^9.3.0":
5286-
version: 9.3.0
5287-
resolution: "bignumber.js@npm:9.3.0"
5288-
checksum: 10/60b79efcf7b56b925fca8eebd10d1f4b70aa2bf6eade7f5af0266f0092226dd2abcd9a3ee315ecb39459750d5a630ce3980b707e5d7bea32c97ffd378e8cc159
5289-
languageName: node
5290-
linkType: hard
5291-
5292-
"bignumber.js@npm:^9.0.2":
5285+
"bignumber.js@npm:^9.0.0, bignumber.js@npm:^9.0.1, bignumber.js@npm:^9.0.2, bignumber.js@npm:^9.1.2, bignumber.js@npm:^9.3.0":
52935286
version: 9.3.1
52945287
resolution: "bignumber.js@npm:9.3.1"
52955288
checksum: 10/1be0372bf0d6d29d0a49b9e6a9cefbd54dad9918232ad21fcd4ec39030260773abf0c76af960c6b3b98d3115a3a71e61c6a111812d1395040a039cfa178e0245
@@ -6518,16 +6511,7 @@ __metadata:
65186511
languageName: node
65196512
linkType: hard
65206513

6521-
"es-define-property@npm:^1.0.0":
6522-
version: 1.0.0
6523-
resolution: "es-define-property@npm:1.0.0"
6524-
dependencies:
6525-
get-intrinsic: "npm:^1.2.4"
6526-
checksum: 10/f66ece0a887b6dca71848fa71f70461357c0e4e7249696f81bad0a1f347eed7b31262af4a29f5d726dc026426f085483b6b90301855e647aa8e21936f07293c6
6527-
languageName: node
6528-
linkType: hard
6529-
6530-
"es-define-property@npm:^1.0.1":
6514+
"es-define-property@npm:^1.0.0, es-define-property@npm:^1.0.1":
65316515
version: 1.0.1
65326516
resolution: "es-define-property@npm:1.0.1"
65336517
checksum: 10/f8dc9e660d90919f11084db0a893128f3592b781ce967e4fccfb8f3106cb83e400a4032c559184ec52ee1dbd4b01e7776c7cd0b3327b1961b1a4a7008920fe78
@@ -7438,7 +7422,7 @@ __metadata:
74387422
languageName: node
74397423
linkType: hard
74407424

7441-
"follow-redirects@npm:^1.15.4":
7425+
"follow-redirects@npm:^1.15.4, follow-redirects@npm:^1.15.6":
74427426
version: 1.15.11
74437427
resolution: "follow-redirects@npm:1.15.11"
74447428
peerDependenciesMeta:
@@ -7448,16 +7432,6 @@ __metadata:
74487432
languageName: node
74497433
linkType: hard
74507434

7451-
"follow-redirects@npm:^1.15.6":
7452-
version: 1.15.9
7453-
resolution: "follow-redirects@npm:1.15.9"
7454-
peerDependenciesMeta:
7455-
debug:
7456-
optional: true
7457-
checksum: 10/e3ab42d1097e90d28b913903841e6779eb969b62a64706a3eb983e894a5db000fbd89296f45f08885a0e54cd558ef62e81be1165da9be25a6c44920da10f424c
7458-
languageName: node
7459-
linkType: hard
7460-
74617435
"for-each@npm:^0.3.3":
74627436
version: 0.3.3
74637437
resolution: "for-each@npm:0.3.3"
@@ -7477,18 +7451,7 @@ __metadata:
74777451
languageName: node
74787452
linkType: hard
74797453

7480-
"form-data@npm:^4.0.0":
7481-
version: 4.0.0
7482-
resolution: "form-data@npm:4.0.0"
7483-
dependencies:
7484-
asynckit: "npm:^0.4.0"
7485-
combined-stream: "npm:^1.0.8"
7486-
mime-types: "npm:^2.1.12"
7487-
checksum: 10/7264aa760a8cf09482816d8300f1b6e2423de1b02bba612a136857413fdc96d7178298ced106817655facc6b89036c6e12ae31c9eb5bdc16aabf502ae8a5d805
7488-
languageName: node
7489-
linkType: hard
7490-
7491-
"form-data@npm:^4.0.4":
7454+
"form-data@npm:^4.0.0, form-data@npm:^4.0.4":
74927455
version: 4.0.4
74937456
resolution: "form-data@npm:4.0.4"
74947457
dependencies:
@@ -7589,20 +7552,7 @@ __metadata:
75897552
languageName: node
75907553
linkType: hard
75917554

7592-
"get-intrinsic@npm:^1.1.3, get-intrinsic@npm:^1.2.4":
7593-
version: 1.2.4
7594-
resolution: "get-intrinsic@npm:1.2.4"
7595-
dependencies:
7596-
es-errors: "npm:^1.3.0"
7597-
function-bind: "npm:^1.1.2"
7598-
has-proto: "npm:^1.0.1"
7599-
has-symbols: "npm:^1.0.3"
7600-
hasown: "npm:^2.0.0"
7601-
checksum: 10/85bbf4b234c3940edf8a41f4ecbd4e25ce78e5e6ad4e24ca2f77037d983b9ef943fd72f00f3ee97a49ec622a506b67db49c36246150377efcda1c9eb03e5f06d
7602-
languageName: node
7603-
linkType: hard
7604-
7605-
"get-intrinsic@npm:^1.2.6":
7555+
"get-intrinsic@npm:^1.2.4, get-intrinsic@npm:^1.2.6":
76067556
version: 1.3.0
76077557
resolution: "get-intrinsic@npm:1.3.0"
76087558
dependencies:
@@ -7823,16 +7773,7 @@ __metadata:
78237773
languageName: node
78247774
linkType: hard
78257775

7826-
"gopd@npm:^1.0.1":
7827-
version: 1.0.1
7828-
resolution: "gopd@npm:1.0.1"
7829-
dependencies:
7830-
get-intrinsic: "npm:^1.1.3"
7831-
checksum: 10/5fbc7ad57b368ae4cd2f41214bd947b045c1a4be2f194a7be1778d71f8af9dbf4004221f3b6f23e30820eb0d052b4f819fe6ebe8221e2a3c6f0ee4ef173421ca
7832-
languageName: node
7833-
linkType: hard
7834-
7835-
"gopd@npm:^1.2.0":
7776+
"gopd@npm:^1.0.1, gopd@npm:^1.2.0":
78367777
version: 1.2.0
78377778
resolution: "gopd@npm:1.2.0"
78387779
checksum: 10/94e296d69f92dc1c0768fcfeecfb3855582ab59a7c75e969d5f96ce50c3d201fd86d5a2857c22565764d5bb8a816c7b1e58f133ec318cd56274da36c5e3fb1a1
@@ -7876,21 +7817,7 @@ __metadata:
78767817
languageName: node
78777818
linkType: hard
78787819

7879-
"has-proto@npm:^1.0.1":
7880-
version: 1.0.1
7881-
resolution: "has-proto@npm:1.0.1"
7882-
checksum: 10/eab2ab0ed1eae6d058b9bbc4c1d99d2751b29717be80d02fd03ead8b62675488de0c7359bc1fdd4b87ef6fd11e796a9631ad4d7452d9324fdada70158c2e5be7
7883-
languageName: node
7884-
linkType: hard
7885-
7886-
"has-symbols@npm:^1.0.3":
7887-
version: 1.0.3
7888-
resolution: "has-symbols@npm:1.0.3"
7889-
checksum: 10/464f97a8202a7690dadd026e6d73b1ceeddd60fe6acfd06151106f050303eaa75855aaa94969df8015c11ff7c505f196114d22f7386b4a471038da5874cf5e9b
7890-
languageName: node
7891-
linkType: hard
7892-
7893-
"has-symbols@npm:^1.1.0":
7820+
"has-symbols@npm:^1.0.3, has-symbols@npm:^1.1.0":
78947821
version: 1.1.0
78957822
resolution: "has-symbols@npm:1.1.0"
78967823
checksum: 10/959385c98696ebbca51e7534e0dc723ada325efa3475350951363cce216d27373e0259b63edb599f72eb94d6cde8577b4b2375f080b303947e560f85692834fa
@@ -7934,7 +7861,7 @@ __metadata:
79347861
languageName: node
79357862
linkType: hard
79367863

7937-
"hasown@npm:^2.0.0, hasown@npm:^2.0.2":
7864+
"hasown@npm:^2.0.2":
79387865
version: 2.0.2
79397866
resolution: "hasown@npm:2.0.2"
79407867
dependencies:

0 commit comments

Comments
 (0)