refactor(account-api)!: rename getGroupIndexFromMultichainAccountId -> getGroupIndexFromMultichainAccountGroupId (#336)

We forgot to rename this function when removing the old implementation.

Author: ccharly

packages/account-api/CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- **BREAKING:** Rename `getGroupIndexFromMultichainAccountId` to `getGroupIndexFromMultichainAccountGroupId` ([#336](https://github.com/MetaMask/accounts/pull/336))
+  - This function was not following the same naming convention (this is an oversight from previous release).
+
 ## [0.6.0]
 
 ### Changed

packages/account-api/src/api/multichain/group.ts

@@ -95,7 +95,7 @@ export function isMultichainAccountGroupId(
  * @param id - Multichain account ID.
  * @returns The multichain account index if extractable, undefined otherwise.
  */
-export function getGroupIndexFromMultichainAccountId(
+export function getGroupIndexFromMultichainAccountGroupId(
   id: MultichainAccountGroupId,
 ): number {
   const matched = id.match(MULTICHAIN_ACCOUNT_GROUP_ID_REGEX);

packages/account-api/src/index.test.ts

@@ -15,7 +15,7 @@ import {
   toAccountGroupId,
   toAccountWalletId,
   toDefaultAccountGroupId,
-  getGroupIndexFromMultichainAccountId,
+  getGroupIndexFromMultichainAccountGroupId,
   isBip44Account,
   toMultichainAccountWalletId,
   toMultichainAccountGroupId,
@@ -163,15 +163,17 @@ describe('index', () => {
         const walletId = toMultichainAccountWalletId('test');
         const groupId = toMultichainAccountGroupId(walletId, groupIndex);
 
-        expect(getGroupIndexFromMultichainAccountId(groupId)).toBe(groupIndex);
+        expect(getGroupIndexFromMultichainAccountGroupId(groupId)).toBe(
+          groupIndex,
+        );
       });
 
       it('throws if it cannot extract group index', () => {
         const walletId = toAccountWalletId(AccountWalletType.Keyring, 'test');
         const groupId = toAccountGroupId(walletId, 'test');
 
         expect(() =>
-          getGroupIndexFromMultichainAccountId(
+          getGroupIndexFromMultichainAccountGroupId(
             // Force the error case even though, type wise, this should not
             // be possible!
             groupId as unknown as MultichainAccountGroupId,