Revert "fix: remove @typescript-eslint/no-redundant-type-constituents directives (#407)"

This reverts commit 6133e50.

Author: ccharly

jest.config.packages.js

@@ -88,8 +88,6 @@ module.exports = {
   moduleNameMapper: {
     '^@metamask/(.+)$': [
       '<rootDir>/../$1/src',
-      // While still unclear why, adding the line below seems to fix the @typescript-eslint/no-redundant-type-constituents errors throughout the monorepo
-      '<rootDir>/packages/$1/src',
       // Some @metamask/* packages we are referencing aren't in this monorepo,
       // so in that case use their published versions
       '<rootDir>/../../node_modules/@metamask/$1',

packages/keyring-api/src/api/keyring.ts

@@ -1,3 +1,6 @@
+/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
+// This rule seems to be triggering a false positive on the `KeyringAccount`.
+
 import type { AccountId, JsonRpcRequest } from '@metamask/keyring-utils';
 import type { Json } from '@metamask/utils';
 

packages/keyring-api/src/api/v2/wrapper/keyring-account-registry.ts

@@ -22,6 +22,7 @@ export class KeyringAccountRegistry<
    * @param accountId - The account ID to look up.
    * @returns The KeyringAccount, or undefined if not found.
    */
+  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   get(accountId: AccountId): KeyringAccountType | undefined {
     return this.#accountById.get(accountId);
   }
@@ -42,6 +43,7 @@ export class KeyringAccountRegistry<
    * @param address - The address to look up.
    * @returns The account ID, or undefined if not found.
    */
+  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   getAccountId(address: string): AccountId | undefined {
     return this.#idByAddress.get(address);
   }

packages/keyring-api/src/events.ts

@@ -1,3 +1,6 @@
+/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
+// FIXME: This rule seems to be triggering a false positive on the `KeyringEvents`.
+
 import {
   exactOptional,
   object,

packages/keyring-internal-api/src/eth/EthKeyring.ts

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
+
 import type {
   KeyringExecutionContext,
   EthBaseTransaction,

packages/keyring-internal-api/src/types.ts

@@ -1,3 +1,8 @@
+/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
+/* eslint-disable @typescript-eslint/no-duplicate-type-constituents */
+// FIXME: Those rules seem to be triggering a false positive on the `InternalAccountStructs`
+// and `InternalAccountTypes`.
+
 import {
   BtcAccountType,
   EthAccountType,

packages/keyring-snap-bridge/src/SnapKeyring.ts

@@ -1,3 +1,7 @@
+/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
+// This rule seems to be triggering a false positive. Possibly eslint is not
+// inferring the `EthMethod`, `BtcMethod`, and `InternalAccount` types correctly.
+
 import type { TypedTransaction } from '@ethereumjs/tx';
 import { TransactionFactory } from '@ethereumjs/tx';
 import type { TypedDataV1, TypedMessage } from '@metamask/eth-sig-util';

packages/keyring-snap-bridge/src/account.ts

@@ -91,6 +91,7 @@ export function assertKeyringAccount<
  * @returns A valid transformed `KeyringAccount`.
  */
 export function transformAccount(
+  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   accountToTransform: KeyringAccountV1 | KeyringAccount,
 ): KeyringAccount {
   // To keep the retro-compatibility with older keyring-api versions, we identify the account's

packages/keyring-snap-bridge/src/migrations/v1.ts

@@ -25,6 +25,7 @@ import {
  * @returns True if the account is v1, false otherwise.
  */
 export function isAccountV1(
+  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   account: KeyringAccountV1 | KeyringAccount,
 ): boolean {
   return is(account, KeyringAccountV1Struct);

packages/keyring-snap-client/src/KeyringClient.ts

@@ -157,6 +157,8 @@ export class KeyringClient implements Keyring {
   async resolveAccountAddress(
     scope: CaipChainId,
     request: JsonRpcRequest,
+    // FIXME: eslint is complaning about `ResolvedAccountAddress` being `any`, so disable this for now:
+    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   ): Promise<ResolvedAccountAddress | null> {
     return strictMask(
       await this.send({