refactor(account-api)!: remove multichain account implementations#333
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
4 tasks
hmalik88
approved these changes
Jul 30, 2025
ccharly
added a commit
to MetaMask/core
that referenced
this pull request
Jul 31, 2025
…,Group}` implementations (#6216) ## Explanation Moving the implementations out of `@metamask/account-api` to have them closer to the service (which makes more sense too). Beware, `MultichainAccount` has been renamed to `MultichainAccountGroup` to emphasis more on the the "group" aspect of multichain accounts. ## References - MetaMask/accounts#333 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the current multichain implementation and move it to the
MultichainAccountService.We still keep some type definitions, so we can re-use them without having to depend on the service itself.
Lastly, the naming convention used for "multichain accounts" was a bit off compared to
AccountGroup, so the name has been updated fromMultichainAccount*toMultichainAccountGroup*.