From 36c22e769a93fd160be00d6a99309b9573a9f46b Mon Sep 17 00:00:00 2001 From: Hassan Malik Date: Wed, 29 Apr 2026 09:09:06 -0400 Subject: [PATCH 1/3] feat: add token approval type --- packages/keyring-api/src/api/transaction.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/keyring-api/src/api/transaction.ts b/packages/keyring-api/src/api/transaction.ts index de87bc640..367464cb0 100644 --- a/packages/keyring-api/src/api/transaction.ts +++ b/packages/keyring-api/src/api/transaction.ts @@ -165,6 +165,11 @@ export enum TransactionType { */ StakeWithdraw = 'stake:withdraw', + /** + * Represents a token approval transaction. + */ + Approve = 'token:approve', + /** * The transaction type is unknown. It's not possible to determine the * transaction type based on the information available. @@ -355,6 +360,7 @@ export const TransactionStruct = object({ `${TransactionType.BridgeReceive}`, `${TransactionType.StakeDeposit}`, `${TransactionType.StakeWithdraw}`, + `${TransactionType.Approve}`, `${TransactionType.Unknown}`, ]), From 2a64cdcb85f2f678547cf97fcd7978640ba63d5d Mon Sep 17 00:00:00 2001 From: Hassan Malik Date: Wed, 29 Apr 2026 09:12:21 -0400 Subject: [PATCH 2/3] chore: add changelog entry --- packages/keyring-api/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/keyring-api/CHANGELOG.md b/packages/keyring-api/CHANGELOG.md index 5b68fae75..57cd3794a 100644 --- a/packages/keyring-api/CHANGELOG.md +++ b/packages/keyring-api/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Added + +- Add `TransactionType.Approve` for token approval transactions ([#537](https://github.com/MetaMask/accounts/pull/537)) + ## [23.0.1] ### Fixed From 785d6b5b4feecdf8d4a305f581320d7b6438cfc9 Mon Sep 17 00:00:00 2001 From: Hassan Malik Date: Wed, 29 Apr 2026 12:02:26 -0400 Subject: [PATCH 3/3] refactor: rename enum --- packages/keyring-api/CHANGELOG.md | 2 +- packages/keyring-api/src/api/transaction.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/keyring-api/CHANGELOG.md b/packages/keyring-api/CHANGELOG.md index 7923e069e..2a978c97a 100644 --- a/packages/keyring-api/CHANGELOG.md +++ b/packages/keyring-api/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added -- Add `TransactionType.Approve` for token approval transactions ([#537](https://github.com/MetaMask/accounts/pull/537)) +- Add `TransactionType.TokenApprove` for token approval transactions ([#537](https://github.com/MetaMask/accounts/pull/537)) ## [23.0.1] diff --git a/packages/keyring-api/src/api/transaction.ts b/packages/keyring-api/src/api/transaction.ts index 367464cb0..012ad521c 100644 --- a/packages/keyring-api/src/api/transaction.ts +++ b/packages/keyring-api/src/api/transaction.ts @@ -168,7 +168,7 @@ export enum TransactionType { /** * Represents a token approval transaction. */ - Approve = 'token:approve', + TokenApprove = 'token:approve', /** * The transaction type is unknown. It's not possible to determine the @@ -360,7 +360,7 @@ export const TransactionStruct = object({ `${TransactionType.BridgeReceive}`, `${TransactionType.StakeDeposit}`, `${TransactionType.StakeWithdraw}`, - `${TransactionType.Approve}`, + `${TransactionType.TokenApprove}`, `${TransactionType.Unknown}`, ]),