chore: make sure we dont cache errors

Author: juanmigdr

packages/assets-controllers/src/TokenListService.ts

@@ -48,8 +48,12 @@ export class TokenListService {
    * @returns A map of lowercase token address → token metadata.
    */
   async fetchTokensByChainId(chainId: Hex): Promise<TokenListMap> {
-    return await this.#queryClient.fetchQuery({
-      queryKey: ['TokenListService:fetchTokensByChainId', chainId],
+    const queryKey = ['TokenListService:fetchTokensByChainId', chainId];
+    // On failure, TanStack Query v5 sets isInvalidated=true and leaves state.data
+    // undefined, so the next fetchQuery call always triggers a fresh network request
+    // rather than serving the cached error. No manual cache eviction is needed.
+    return this.#queryClient.fetchQuery({
+      queryKey,
       queryFn: async () => {
         const list = (await fetchTokenListByChainId(
           chainId,

packages/assets-controllers/src/TokensController.ts

@@ -53,7 +53,7 @@ import {
   TOKEN_METADATA_NO_SUPPORT_ERROR,
   TokenRwaData,
 } from './token-service';
-import type { TokenListToken } from './TokenListController';
+import type { TokenListMap, TokenListToken } from './TokenListController';
 import type { TokenListService } from './TokenListService';
 import type { Token } from './TokenRatesController';
 import type { TokensControllerMethodActions } from './TokensController-method-action-types';
@@ -278,13 +278,24 @@ export class TokensController extends BaseController<
     // Fetch all chain data concurrently before touching state so the async gap
     // is as short as possible and we never hold a stale T0 snapshot while
     // awaiting individual chain requests.
-    const chainDataEntries = await Promise.all(
+    // Promise.allSettled ensures a transient error on one chain does not
+    // prevent other chains from being enriched.
+    const results = await Promise.allSettled(
       chainIds.map(async (chainId) => {
         const data = await tokenListService.fetchTokensByChainId(chainId);
         return [chainId, data] as const;
       }),
     );
-    const chainDataMap = Object.fromEntries(chainDataEntries);
+    const chainDataMap = Object.fromEntries(
+      results
+        .filter(
+          (
+            result,
+          ): result is PromiseFulfilledResult<readonly [Hex, TokenListMap]> =>
+            result.status === 'fulfilled',
+        )
+        .map((result) => result.value),
+    );
 
     // Read selectedAddress inside the updater so it reflects the live account
     // at the moment the state write happens, not a snapshot taken before the