fix: introduce newAccountAssets

Author: sahar-fehri

packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.ts

@@ -56,6 +56,19 @@ export type AssetMetadataResponse = {
     [asset: CaipAssetType]: FungibleAssetMetadata;
   };
 };
+export type AccountId = string;
+export type NewAccountAssets = {
+  accountId: AccountId;
+  assets: CaipAssetType[];
+}[];
+export type MultichainAssetsControllerNewAccountAssetsEvent = {
+  type: `${typeof controllerName}:newAccountAssets`;
+  payload: [
+    {
+      newAccountAssets: NewAccountAssets;
+    },
+  ];
+};
 
 /**
  * Constructs the default {@link MultichainAssetsController} state. This allows
@@ -102,7 +115,8 @@ export type MultichainAssetsControllerActions =
  * Events emitted by {@link MultichainAssetsController}.
  */
 export type MultichainAssetsControllerEvents =
-  MultichainAssetsControllerStateChangeEvent;
+  | MultichainAssetsControllerStateChangeEvent
+  | MultichainAssetsControllerNewAccountAssetsEvent;
 
 /**
  * A function executed within a mutually exclusive lock, with
@@ -318,6 +332,14 @@ export class MultichainAssetsController extends BaseController<
       this.update((state) => {
         state.accountsAssets[account.id] = assets;
       });
+      this.messagingSystem.publish(`${controllerName}:newAccountAssets`, {
+        newAccountAssets: [
+          {
+            accountId: account.id,
+            assets,
+          },
+        ],
+      });
     }
   }
 

packages/assets-controllers/src/MultichainAssetsController/index.ts

@@ -8,6 +8,7 @@ export type {
   MultichainAssetsControllerGetStateAction,
   MultichainAssetsControllerStateChangeEvent,
   MultichainAssetsControllerActions,
-  MultichainAssetsControllerEvents,
   MultichainAssetsControllerMessenger,
+  MultichainAssetsControllerNewAccountAssetsEvent,
+  MultichainAssetsControllerEvents,
 } from './MultichainAssetsController';

packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.test.ts

@@ -483,14 +483,6 @@ describe('MultichainBalancesController', () => {
       const mockSolanaAccountId1 = mockListSolanaAccounts[0].id;
       const mockSolanaAccountId2 = mockListSolanaAccounts[1].id;
 
-      const existingBalancesState = {
-        [mockSolanaAccountId1]: {
-          'solana:EtWTRABZaYq6iMfeYKouRu166VU2xqa1/token:newToken55': {
-            amount: '5.00000000',
-            unit: 'SOL',
-          },
-        },
-      };
       const { controller, messenger, mockSnapHandleRequest } = setupController({
         state: {
           balances: {},

packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.ts

@@ -27,8 +27,10 @@ import { HandlerType } from '@metamask/snaps-utils';
 import type { Json, JsonRpcRequest } from '@metamask/utils';
 import type { Draft } from 'immer';
 
+
 import type {
   MultichainAssetsControllerGetStateAction,
+  MultichainAssetsControllerNewAccountAssetsEvent,
   MultichainAssetsControllerState,
   MultichainAssetsControllerStateChangeEvent,
 } from '../MultichainAssetsController';
@@ -108,7 +110,8 @@ type AllowedEvents =
   | AccountsControllerAccountRemovedEvent
   | AccountsControllerAccountBalancesUpdatesEvent
   | MultichainAssetsControllerStateChangeEvent
-  | AccountsControllerAccountAssetListUpdatedEvent;
+  | AccountsControllerAccountAssetListUpdatedEvent
+  | MultichainAssetsControllerNewAccountAssetsEvent;
 /**
  * Messenger type for the MultichainBalancesController.
  */
@@ -177,7 +180,7 @@ export class MultichainBalancesController extends BaseController<
         this.#handleOnAccountBalancesUpdated(balanceUpdate),
     );
     // We only care about new added assets to fetch balances for.
-    this.messagingSystem.subscribe(
+    /*     this.messagingSystem.subscribe(
       'AccountsController:accountAssetListUpdated',
       async (event: AccountAssetListUpdatedEventPayload) => {
         const assetsToUpdate = event.assets;
@@ -191,6 +194,13 @@ export class MultichainBalancesController extends BaseController<
           await this.#updateBalancesForAccounts(accountsAndAssetsToUpdate);
         }
       },
+    ); */
+
+    this.messagingSystem.subscribe(
+      'MultichainAssetsController:newAccountAssets',
+      async ({ newAccountAssets }) => {
+        console.log('🚀 ~ newAccountAssets:', newAccountAssets);
+      },
     );
   }