Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[preferences-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency #4478

Open
kanthesha opened this issue Jun 28, 2024 · 0 comments · May be fixed by #4479
Open

[preferences-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency #4478

kanthesha opened this issue Jun 28, 2024 · 0 comments · May be fixed by #4479
Assignees
@kanthesha
Labels
bug Something isn't working team-wallet-framework

Comments

@kanthesha
Copy link
Contributor

It's already a peer dependency, so it should be a runtime dependency too.
@kanthesha kanthesha added bug Something isn't working team-wallet-framework labels Jun 28, 2024
@kanthesha kanthesha self-assigned this Jun 28, 2024
@kanthesha kanthesha changed the title Copy of [accounts-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency [preferences-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency Jun 28, 2024
@kanthesha kanthesha linked a pull request Jun 28, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanthesha kanthesha

Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preferences-controller: moved keyring controller to runtime dependency MetaMask/core
1 participant
@kanthesha