Skip to content

Preview build publishing workflow in a topic PR may fail if release PR has been merged to main but new version has not been published yet #5308

Open
@mcmire

Description

@mcmire

If you merge a release PR that bumps the version of a package that has dependents such as @metamask/base-controller, but you do not approve the release yet (i.e., the new version is not published), then when you open a PR and attempt to publish preview builds, the workflow will fail during the step that changes all of the workspace package names to their preview equivalent. Because of this, Yarn attempts to resolve dependencies to their published version instead of their local version, and when it does this, it isn't able to find the published version.

To fix this, we could consider overwriting all interdependencies to use the preview build versions by renaming them from @metamask/ to @metamask-previews/ and adjusting their versions.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions