feat(network-controller): connect NetworkController to ConnectivityController#7627
Merged
cryptodev-2s merged 14 commits intomainfrom Jan 15, 2026
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
1a810fe to
b590b43
Compare
NetworkController to ConnectivityController
b590b43 to
1bdba27
Compare
mcmire
reviewed
Jan 14, 2026
1bdba27 to
753eb65
Compare
…CTIVITY_STATUSES - Rename ConnectivityStatus constant to CONNECTIVITY_STATUSES - Export ConnectivityStatus as a type instead of enum - Update all references to use CONNECTIVITY_STATUSES - Export CONNECTIVITY_STATUSES from index
5c3f070 to
35be87b
Compare
Contributor
Author
|
@metamaskbot publish-preview |
3d671df to
be34729
Compare
Contributor
Author
|
@metamaskbot publish-preview |
…ntroller - Add ConnectivityController:getState action handler requirement - Suppress rpcEndpointUnavailable and rpcEndpointDegraded events when offline - Update NetworkController to check connectivity status before publishing events - Add tests for offline event suppression
…fline - Add isOffline check to RpcService retry filter policy to prevent retries when offline - Suppress rpcEndpointUnavailable and rpcEndpointDegraded events when offline - Add tests to verify retries don't happen when offline - Add tests to verify events are suppressed when offline - Update CHANGELOG with breaking change documentation
e3d5f1f to
d59bf85
Compare
…rk-controller-to-connectivity
Contributor
Author
|
@metamaskbot publish-preview |
mcmire
reviewed
Jan 15, 2026
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Had some comments, but they are minor. This looks good in general.
packages/network-controller/src/create-network-client-tests/rpc-endpoint-events.test.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/src/rpc-service/rpc-service.test.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/src/rpc-service/rpc-service.test.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/src/rpc-service/rpc-service.test.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/src/rpc-service/rpc-service.test.ts
Outdated
Show resolved
Hide resolved
0af1e4f to
46c0f95
Compare
packages/network-controller/src/rpc-service/rpc-service.test.ts
Outdated
Show resolved
Hide resolved
46c0f95 to
b048b72
Compare
b048b72 to
c0b3840
Compare
5d44b9b to
24c8e00
Compare
24c8e00 to
75b0aaa
Compare
Contributor
Author
|
@metamaskbot publish-preview |
salimtb
approved these changes
Jan 15, 2026
cryptotavares
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Connects
NetworkControllertoConnectivityControllerto prevent retries and suppress RPC endpoint error events when the user is offline.Changes
NetworkControllernow depends on theConnectivityControllerto prevent retries and suppress events when the user is offline.NetworkController:rpcEndpointUnavailableandNetworkController:rpcEndpointDegradedevents are suppressed since retries don't occur and circuit breakers don't trigger.Breaking Changes
ConnectivityController:getStateaction handler to be registered on the messengerConnectivityController:getStateaction handler on your root messenger that returns an object with aconnectivityStatusproperty ('online'or'offline').ConnectivityController:getStateaction from your root messenger to theNetworkControllerMessengerusingrootMessenger.delegate({ messenger: networkControllerMessenger, actions: ['ConnectivityController:getState'] }).References
Checklist
Note
Overview
Connects
NetworkControllertoConnectivityControllerso RPC retries are prevented when offline and related events are suppressed.@metamask/connectivity-controller; updates README dependency graphConnectivityController:getState) and propagatesisOfflinetoRpcService/RpcServiceChainNetworkController:rpcEndpointUnavailableandNetworkController:rpcEndpointDegradedBreaking change
ConnectivityController:getStateon the root messenger to theNetworkControllerMessengerTests
isOfflinethrough existing testsWritten by Cursor Bugbot for commit a0ee480. This will update automatically on new commits. Configure here.