fix: ignore incoming transactions in nonce filtering#7637
Merged
matthewwalsh0 merged 2 commits intomainfrom Jan 15, 2026
Merged
fix: ignore incoming transactions in nonce filtering#7637matthewwalsh0 merged 2 commits intomainfrom
matthewwalsh0 merged 2 commits intomainfrom
Conversation
Update markNonceDuplicatesDropped in TransactionController to only consider transactions where isTransfer is undefined, consistent with the behavior in PendingTransactionTracker. This prevents transfer transactions (which are derived from regular transactions) from being incorrectly marked as dropped when they share the same nonce as a confirmed transaction. Co-authored-by: matthew.walsh <matthew.walsh@consensys.net>
|
Cursor Agent can help with this pull request. Just |
isTransfer filteringCo-authored-by: matthew.walsh <matthew.walsh@consensys.net>
pedronfigueiredo
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Ignore incoming transactions in nonce filtering, to avoid transactions incorrectly marked as
dropped.References
Checklist
Note
Prevents transfer-designated transactions from being marked as dropped when another same-nonce tx confirms.
TransactionControllerto ignore transactions whereisTransferis defined in same-nonce filtering (TransactionController.ts)isTransfertransaction and assert it is not marked as dropped (TransactionController.test.ts)CHANGELOG.mdunder UnreleasedWritten by Cursor Bugbot for commit 89dfd06. This will update automatically on new commits. Configure here.