Skip to content

Comments

fix: ignore incoming transactions in nonce filtering#7637

Merged
matthewwalsh0 merged 2 commits intomainfrom
cursor/nonce-duplicate-istransfer-filtering-8d61
Jan 15, 2026
Merged

fix: ignore incoming transactions in nonce filtering#7637
matthewwalsh0 merged 2 commits intomainfrom
cursor/nonce-duplicate-istransfer-filtering-8d61

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jan 15, 2026

Explanation

Ignore incoming transactions in nonce filtering, to avoid transactions incorrectly marked as dropped.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Open in Cursor Open in Web


Note

Prevents transfer-designated transactions from being marked as dropped when another same-nonce tx confirms.

  • Update TransactionController to ignore transactions where isTransfer is defined in same-nonce filtering (TransactionController.ts)
  • Extend test to include an isTransfer transaction and assert it is not marked as dropped (TransactionController.test.ts)
  • Document fix in CHANGELOG.md under Unreleased

Written by Cursor Bugbot for commit 89dfd06. This will update automatically on new commits. Configure here.

Update markNonceDuplicatesDropped in TransactionController to only consider
transactions where isTransfer is undefined, consistent with the behavior
in PendingTransactionTracker.

This prevents transfer transactions (which are derived from regular
transactions) from being incorrectly marked as dropped when they share
the same nonce as a confirmed transaction.

Co-authored-by: matthew.walsh <matthew.walsh@consensys.net>
@cursor
Copy link

cursor bot commented Jan 15, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@matthewwalsh0 matthewwalsh0 changed the title Nonce duplicate isTransfer filtering fix: ignore incoming transactions in nonce filtering Jan 15, 2026
Co-authored-by: matthew.walsh <matthew.walsh@consensys.net>
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review January 15, 2026 12:56
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners January 15, 2026 12:56
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 10534e0 Jan 15, 2026
290 checks passed
@matthewwalsh0 matthewwalsh0 deleted the cursor/nonce-duplicate-istransfer-filtering-8d61 branch January 15, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants