Skip to content

Commit ecb6b4b

Browse files
chore: Updated Icon libraries (#603)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR updates the icon asset libraries for both `@metamask/design-system-react` and `@metamask/design-system-react-native` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #602 ## **Manual testing steps** 1. Run `yarn storybook` or `yarn storybook:ios` from root 2. Check Icon components to make sure they're still functional 3. Run `yarn generate-icons` from root and make sure there are no errors ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/a6a4d457-f310-44bc-9f37-7a50d4da63c4 https://github.com/user-attachments/assets/a1d36fc6-1c86-46cc-ba77-a1c13ba58b45 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: George Marshall <[email protected]>
1 parent cdfd389 commit ecb6b4b

File tree

780 files changed

+867
-810
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

780 files changed

+867
-810
lines changed

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
"changelog:validate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:validate",
2121
"create-component:react": "yarn workspace @metamask/design-system-react create-component",
2222
"create-package": "ts-node scripts/create-package",
23+
"generate-icons": "yarn generate-icons:react && yarn generate-icons:react-native",
24+
"generate-icons:react": "yarn workspace @metamask/design-system-react generate-icons",
25+
"generate-icons:react-native": "yarn workspace @metamask/design-system-react-native generate-icons",
2326
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn constraints && yarn lint:dependencies",
2427
"lint:clear-cache": "rimraf .eslintcache",
2528
"lint:dependencies": "depcheck && yarn dedupe --check",

packages/design-system-react-native/src/components/Icon/Icon.assets.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ import FingerprintSVG from './assets/fingerprint.svg';
105105
import FireSVG from './assets/fire.svg';
106106
import FirstPageSVG from './assets/first-page.svg';
107107
import FlagSVG from './assets/flag.svg';
108+
import FlashSlashSVG from './assets/flash-slash.svg';
108109
import FlashSVG from './assets/flash.svg';
109110
import FlaskSVG from './assets/flask.svg';
110111
import FlowerSVG from './assets/flower.svg';
@@ -151,6 +152,7 @@ import MinusBoldSVG from './assets/minus-bold.svg';
151152
import MinusSquareSVG from './assets/minus-square.svg';
152153
import MinusSVG from './assets/minus.svg';
153154
import MobileSVG from './assets/mobile.svg';
155+
import MoneyBagSVG from './assets/money-bag.svg';
154156
import MoneySVG from './assets/money.svg';
155157
import MonitorSVG from './assets/monitor.svg';
156158
import MoreHorizontalSVG from './assets/more-horizontal.svg';
@@ -380,6 +382,7 @@ export const assetByIconName: AssetByIconName = {
380382
[IconName.Fire]: FireSVG,
381383
[IconName.FirstPage]: FirstPageSVG,
382384
[IconName.Flag]: FlagSVG,
385+
[IconName.FlashSlash]: FlashSlashSVG,
383386
[IconName.Flash]: FlashSVG,
384387
[IconName.Flask]: FlaskSVG,
385388
[IconName.Flower]: FlowerSVG,
@@ -426,6 +429,7 @@ export const assetByIconName: AssetByIconName = {
426429
[IconName.MinusSquare]: MinusSquareSVG,
427430
[IconName.Minus]: MinusSVG,
428431
[IconName.Mobile]: MobileSVG,
432+
[IconName.MoneyBag]: MoneyBagSVG,
429433
[IconName.Money]: MoneySVG,
430434
[IconName.Monitor]: MonitorSVG,
431435
[IconName.MoreHorizontal]: MoreHorizontalSVG,
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)