Skip to content

Commit fe45cfd

Browse files
chore: fixing github pages failing jekyll build (#643)
### **Description** This PR addresses an issue with GitHub Pages deployment where Jekyll was attempting to process our Storybook static files, resulting in build failures. The issue was occurring because Jekyll was trying to interpret React/JSX code blocks in our README.md files as Liquid template syntax. The fix adds a `.nojekyll` file to the Storybook static directory, which instructs GitHub Pages to skip Jekyll processing entirely. ### **Related issues** Fixes: #644 ### **Manual testing steps** 1. Merge this PR to main 2. Verify that the GitHub Pages deployment succeeds without Jekyll errors 3. Confirm the Storybook site loads correctly ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A # **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR # **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent cd49025 commit fe45cfd

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/build-storybook-main.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ jobs:
2525
yarn build
2626
2727
- name: Build Storybook
28-
run: yarn build-storybook
28+
run: |
29+
yarn build-storybook
30+
touch storybook-static/.nojekyll
2931
3032
- name: Upload artifact
3133
id: upload

0 commit comments

Comments
 (0)