Skip to content

Commit 7a1c453

Browse files
committed
Update dropdown behaviour.
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
1 parent f341ae4 commit 7a1c453

2 files changed

Lines changed: 24 additions & 16 deletions

File tree

src/components/SidebarVersionDropdown/SidebarVersionDropdown.module.css

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* Dropdown container */
21
.dropdown {
32
position: relative;
43
padding-left: var(--ifm-menu-link-padding-horizontal);
@@ -9,7 +8,6 @@
98
margin-bottom: 1rem;
109
}
1110

12-
/* Version item (label and chevron) */
1311
.versionItem {
1412
display: flex;
1513
align-items: center;
@@ -27,21 +25,19 @@
2725
color: var(--ifm-color-primary);
2826
}
2927

30-
/* Chevron */
3128
.chevron {
3229
font-size: 2.2rem;
3330
line-height: 1;
3431
display: inline-block;
35-
margin-left: 0.5rem;
32+
margin-left: 0rem;
33+
padding-right: 20px;
3634
}
3735

38-
/* Version label */
3936
.label {
4037
flex: 1;
4138
line-height: 1.5;
4239
}
4340

44-
/* Menu */
4541
.menu {
4642
position: absolute;
4743
top: 100%;
@@ -56,7 +52,6 @@
5652
min-width: 180px;
5753
}
5854

59-
/* Menu item */
6055
.menuItem {
6156
padding: 0.75rem 1rem;
6257
font-size: 1.4rem;
@@ -69,22 +64,34 @@
6964
background: var(--ifm-hover-overlay);
7065
}
7166

72-
/* Dark mode support */
67+
.menuItem.hovered {
68+
background: var(--ifm-hover-overlay);
69+
}
70+
71+
.menuItem.selected {
72+
color: var(--ifm-color-primary) !important;
73+
background: var(--general-gray-light);
74+
}
75+
7376
[data-theme='dark'] .menu {
74-
background: var(--general-black-light) !important; /* Dark background for menu */
75-
border-color: var(--general-white) !important; /* Light border */
77+
background: var(--general-black-light) !important;
78+
border-color: var(--general-white) !important;
7679
}
7780

7881
[data-theme='dark'] .menuItem {
79-
color: var(--general-white) !important; /* Text color in dark mode */
80-
background: var(--general-black-light) !important; /* Dark background for menu items */
82+
color: var(--general-white) !important;
83+
background: var(--general-black-light) !important;
8184
}
8285

8386
[data-theme='dark'] .menuItem:hover {
84-
background: var(--general-black-mid) !important; /* Slightly lighter background for hover */
87+
background: var(--general-black-mid) !important;
88+
}
89+
90+
[data-theme='dark'] .menuItem.selected {
91+
color: var(--ifm-color-primary) !important;
92+
background: var(--general-black-mid) !important;
8593
}
8694

87-
/* Dark mode styling for dropdown */
8895
[data-theme='dark'] .dropdown {
89-
border-bottom: 1px solid var(--general-white); /* Light border for dropdown in dark mode */
96+
border-bottom: 1px solid var(--general-white);
9097
}

src/components/SidebarVersionDropdown/SidebarVersionDropdown.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,15 @@ export default function SidebarVersionDropdown({ pluginId = 'gator' }: { pluginI
6868
onKeyDown={(e) => e.key === 'Enter' && toggleDropdown()}
6969
>
7070
<span className={styles.label}>Version: {getVersionLabel(currentVersion)}</span>
71-
<span className={clsx('menu__caret', styles.chevron)} aria-hidden></span>
71+
<span className={clsx(styles.chevron)} aria-hidden></span> {/* Custom class applied here */}
7272
</div>
7373
{open && (
7474
<ul className={styles.menu} role="menu">
7575
{allVersions.map((version) => (
7676
<li
7777
key={version}
7878
className={clsx(styles.menuItem, {
79+
[styles.selected]: version === currentVersion, // Apply selected class for current version
7980
[styles.hovered]: hoveredVersion === version, // Apply dynamic hover class
8081
})}
8182
onClick={() => handleSelect(version)}

0 commit comments

Comments
 (0)