feat: Remove failed transaction retry icon button (#32024)

## **Description**

There is an issue where after a transaction fails, using the retry
button may result in a successful transaction, but the transaction would
continue to say "Failed" in the transaction list. This seems to be an
outstanding bug.

We are hiding the retry button until further notice. I chose to comment
these out rather than setting showRetry to make it more explicit that it
is unused code.

This retry button was shown in the TransactionListItemDetails when the
failed transaction was neither a swap nor a smart transaction.

The speedup and cancel buttons continue to exist. Speedup reuses the
same logic as the Retry logic.

## **Related issues**

Fixes: #28615

## **Manual testing steps**

1. Submit a failed transaction
  a. e.g. Use Arbitrum One network
  b. Go to the test-dapp
c. Send a EIP-1559 or Legacy Transaction (with gas specified by the
dapp)
2. Go to MM > Activity
3. Click on the Failed transaction

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

![CleanShot 2025-04-11 at 09 40
46](https://github.com/user-attachments/assets/4d1ecb74-2a3a-4674-81ea-c56fcd99f0f2)

### **After**

![CleanShot 2025-04-15 at 18 12
17](https://github.com/user-attachments/assets/b15eee49-4cfb-4bb5-ba06-94e8a2f6b314)

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: digiwand

CHANGELOG.md

@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Update multichain network controller to implement `getNetworksWithActivityByAccounts` method and add state management for networks with activity ([#31414](https://github.com/MetaMask/metamask-extension/pull/31414))
 - Update security and privacy policy description to reflect Solana account handling ([#32231](https://github.com/MetaMask/metamask-extension/pull/32231))
 - Updates the Solana modal by adding a learn more link, UI tweaks and auto selects a solana account when it exists. ([#32087](https://github.com/MetaMask/metamask-extension/pull/32087))
+- Hide failed transaction retry button ([#32024](https://github.com/MetaMask/metamask-extension/pull/32024))
 
 ### Fixed
 - updates display decimals in Bridge experience 'More Quotes' section ([#32080](https://github.com/MetaMask/metamask-extension/pull/32080))

ui/components/app/transaction-list-item-details/transaction-list-item-details.component.js

@@ -33,7 +33,12 @@ export default class TransactionListItemDetails extends PureComponent {
     onRetry: PropTypes.func,
     showCancel: PropTypes.bool,
     showSpeedUp: PropTypes.bool,
-    showRetry: PropTypes.bool,
+    /**
+     * Disabling the retry button until further notice
+     *
+     * @see {@link https://github.com/MetaMask/metamask-extension/issues/28615}
+     */
+    // showRetry: PropTypes.bool,
     isEarliestNonce: PropTypes.bool,
     primaryCurrency: PropTypes.string,
     transactionGroup: PropTypes.object,
@@ -147,7 +152,7 @@ export default class TransactionListItemDetails extends PureComponent {
       transactionGroup,
       primaryCurrency,
       showSpeedUp,
-      showRetry,
+      // showRetry,
       recipientAddress,
       recipientName,
       senderAddress,
@@ -187,7 +192,7 @@ export default class TransactionListItemDetails extends PureComponent {
                   detailsModal
                 />
               )}
-              {showRetry && (
+              {/* {showRetry && (
                 <Tooltip title={t('retryTransaction')}>
                   <Button
                     type="raised"
@@ -198,7 +203,7 @@ export default class TransactionListItemDetails extends PureComponent {
                     <i className="fa fa-sync"></i>
                   </Button>
                 </Tooltip>
-              )}
+              )} */}
             </div>
           </div>
           <div className="transaction-list-item-details__header">

ui/components/app/transaction-list-item-details/transaction-list-item-details.component.test.js

@@ -92,7 +92,13 @@ describe('TransactionListItemDetails Component', () => {
     });
   });
 
-  describe('Retry button', () => {
+  /**
+   * Disabling the retry button until further notice
+   *
+   * @see {@link https://github.com/MetaMask/metamask-extension/issues/28615}
+   */
+  // eslint-disable-next-line jest/no-disabled-tests
+  describe.skip('Retry button', () => {
     it('should render retry button with showRetry prop', async () => {
       const { queryByTestId } = await render({ showRetry: true });
 

ui/components/app/transaction-list-item/transaction-list-item.component.js

@@ -60,7 +60,7 @@ import EditGasPopover from '../../../pages/confirmations/components/edit-gas-pop
 import { MetaMetricsContext } from '../../../contexts/metametrics';
 import { ActivityListItem } from '../../multichain';
 import { abortTransactionSigning } from '../../../store/actions';
-import { getIsSmartTransaction } from '../../../../shared/modules/selectors';
+// import { getIsSmartTransaction } from '../../../../shared/modules/selectors';
 import {
   useBridgeTxHistoryData,
   FINAL_NON_CONFIRMED_STATUSES,
@@ -86,9 +86,7 @@ function TransactionListItemInner({
   const [showRetryEditGasPopover, setShowRetryEditGasPopover] = useState(false);
   const { supportsEIP1559 } = useGasFeeContext();
   const { openModal } = useTransactionModalContext();
-  const isSmartTransaction = useSelector((state) =>
-    getIsSmartTransaction(state, chainId),
-  );
+  // const isSmartTransaction = useSelector(getIsSmartTransaction);
   const dispatch = useDispatch();
 
   // Bridge transactions
@@ -193,10 +191,19 @@ function TransactionListItemInner({
   const isSignatureReq = category === TransactionGroupCategory.signatureRequest;
   const isApproval = category === TransactionGroupCategory.approval;
   const isUnapproved = status === TransactionStatus.unapproved;
-  const isSwap = [
-    TransactionGroupCategory.swap,
-    TransactionGroupCategory.swapAndSend,
-  ].includes(category);
+
+  /**
+   * Disabling the retry button until further notice
+   *
+   * @see {@link https://github.com/MetaMask/metamask-extension/issues/28615}
+   */
+  // const isSwap = [
+  //   TransactionGroupCategory.swap,
+  //   TransactionGroupCategory.swapAndSend,
+  // ].includes(category);
+  // const showRetry =
+  //   status === TransactionStatus.failed && !isSwap && !isSmartTransaction;
+
   const isSigning = status === TransactionStatus.approved;
   const isSubmitting = status === TransactionStatus.signed;
 
@@ -366,11 +373,7 @@ function TransactionListItemInner({
           senderAddress={senderAddress}
           recipientAddress={recipientAddress}
           onRetry={retryTransaction}
-          showRetry={
-            status === TransactionStatus.failed &&
-            !isSwap &&
-            !isSmartTransaction
-          }
+          // showRetry={showRetry}
           showSpeedUp={shouldShowSpeedUp}
           isEarliestNonce={isEarliestNonce}
           onCancel={cancelTransaction}