Skip to content

Commit 57d564d

Browse files
authored
chore: Remove broken MV3 perf stats (#29408)
## **Description** Remove broken MV3 reports. These reports relied upon data from the `mv3-perf-stats` E2E test job, which itself relied upon the `user-data-dir` chromedriver setting removed in #24696. They have been broken since that PR. These reports were very useful in prioritizing MV3 work at the time, but we haven't needed them recently. The `mv3-stats` E2E test suite has also been removed (this is an older version of `mv3-perf-stats` that has been unused for even longer), along with the charts that were used for this report. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29408?quickstart=1) ## **Related issues** Relates to #28572 ## **Manual testing steps** Check that the `metamaskbot` comment no longer has the links to these broken reports. They look like this: - mv3: Background Module Init Stats - mv3: UI Init Stats - mv3: Module Load Stats ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent f64a2d0 commit 57d564d

15 files changed

+0
-9563
lines changed

.circleci/config.yml

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,6 @@ workflows:
278278
- user-actions-benchmark:
279279
requires:
280280
- prep-build-test
281-
- stats-module-load-init:
282-
requires:
283-
- prep-build-test
284281
- job-publish-prerelease:
285282
requires:
286283
- prep-deps
@@ -294,7 +291,6 @@ workflows:
294291
- prep-build-ts-migration-dashboard
295292
- benchmark
296293
- user-actions-benchmark
297-
- stats-module-load-init
298294
- all-tests-pass
299295
- job-publish-release:
300296
filters:
@@ -1271,44 +1267,6 @@ jobs:
12711267
paths:
12721268
- test-artifacts
12731269

1274-
stats-module-load-init:
1275-
executor: node-browsers-small
1276-
steps:
1277-
- run: *shallow-git-clone-and-enable-vnc
1278-
- run: sudo corepack enable
1279-
- attach_workspace:
1280-
at: .
1281-
- run:
1282-
name: Move test build to dist
1283-
command: mv ./dist-test ./dist
1284-
- run:
1285-
name: Move test zips to builds
1286-
command: mv ./builds-test ./builds
1287-
- run:
1288-
name: Run page load benchmark
1289-
command: |
1290-
mkdir -p test-artifacts/chrome/
1291-
cp -R development/charts/flamegraph test-artifacts/chrome/initialisation
1292-
cp -R development/charts/flamegraph/chart test-artifacts/chrome/initialisation/background
1293-
cp -R development/charts/flamegraph/chart test-artifacts/chrome/initialisation/ui
1294-
cp -R development/charts/table test-artifacts/chrome/load_time
1295-
- run:
1296-
name: Run page load benchmark
1297-
command: yarn mv3:stats:chrome --out test-artifacts/chrome
1298-
- run:
1299-
name: Install jq
1300-
command: sudo apt install jq -y
1301-
- run:
1302-
name: Record bundle size at commit
1303-
command: ./.circleci/scripts/bundle-stats-commit.sh
1304-
- store_artifacts:
1305-
path: test-artifacts
1306-
destination: test-artifacts
1307-
- persist_to_workspace:
1308-
root: .
1309-
paths:
1310-
- test-artifacts
1311-
13121270
job-publish-prerelease:
13131271
executor: node-browsers-medium
13141272
steps:

.prettierignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ node_modules/**/*
66
/app/vendor/**
77
/builds/**/*
88
/coverage/**/*
9-
/development/charts/**
109
/development/chromereload.js
1110
/development/ts-migration-dashboard/filesToConvert.json
1211
/development/ts-migration-dashboard/build/**

.vscode/cspell.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"devcontainers",
4848
"endregion",
4949
"ensdomains",
50-
"flamegraph",
5150
"FONTCONFIG",
5251
"hardfork",
5352
"hexstring",

development/charts/flamegraph/chart/index.html

Lines changed: 0 additions & 167 deletions
This file was deleted.

0 commit comments

Comments
 (0)