fix: use BN from bn.js instead of ethereumjs-util

Author: legobeat

app/scripts/migrations/088.ts

@@ -1,5 +1,5 @@
 import { hasProperty, Hex, isObject, isStrictHexString } from '@metamask/utils';
-import { BN } from 'ethereumjs-util';
+import BN from 'bn.js';
 import { cloneDeep, mapKeys } from 'lodash';
 import log from 'loglevel';
 
@@ -302,6 +302,6 @@ function toHex(value: number | string | BN): Hex {
   }
   const hexString = BN.isBN(value)
     ? value.toString(16)
-    : new BN(value.toString(), 10).toString(16);
+    : new BN(value.toString(10), 10).toString(16);
   return `0x${hexString}`;
 }

shared/modules/conversion.utils.ts

@@ -1,6 +1,7 @@
 import { Hex } from '@metamask/utils';
 import { BigNumber } from 'bignumber.js';
-import { addHexPrefix, BN } from 'ethereumjs-util';
+import BN from 'bn.js';
+import { addHexPrefix } from 'ethereumjs-util';
 import { EtherDenomination } from '../constants/common';
 import { Numeric, NumericValue } from './Numeric';
 

ui/helpers/utils/util.test.js

@@ -1,5 +1,6 @@
 import Bowser from 'bowser';
-import { BN, toChecksumAddress } from 'ethereumjs-util';
+import BN from 'bn.js';
+import { toChecksumAddress } from 'ethereumjs-util';
 import { CHAIN_IDS } from '../../../shared/constants/network';
 import { addHexPrefixToObjectValues } from '../../../shared/lib/swaps-utils';
 import { toPrecisionWithoutTrailingZeros } from '../../../shared/lib/transactions-controller-utils';